From patchwork Tue Nov 7 22:13:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matt Turner X-Patchwork-Id: 835843 X-Patchwork-Delegate: jeffrey.t.kirsher@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jpXA+PyM"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yX8MW4l7lz9s5L for ; Thu, 9 Nov 2017 01:49:27 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A33DA257B1; Wed, 8 Nov 2017 14:49:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 68LZlwlLZGMU; Wed, 8 Nov 2017 14:49:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 95B8E230F6; Wed, 8 Nov 2017 14:49:22 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2B8FC1C02F3 for ; Tue, 7 Nov 2017 22:13:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 1E2ED8296A for ; Tue, 7 Nov 2017 22:13:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dWnwYzA5YmTR for ; Tue, 7 Nov 2017 22:13:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by whitealder.osuosl.org (Postfix) with ESMTPS id 8476A8288A for ; Tue, 7 Nov 2017 22:13:42 +0000 (UTC) Received: by mail-pg0-f68.google.com with SMTP id s2so559107pge.10 for ; Tue, 07 Nov 2017 14:13:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yHz8hgfvK5QobDw8MMRzA5sdCgJ7dwazTK+WL1gh9ko=; b=jpXA+PyMq0C9Ob3H6ImgDA9jtfI8k+Exmw+mDGwyVT9yKoP5sHUkF3dHMKM4azLru8 9oWX7pTwG0QHgLDTGb9vQ3jsVbK6vqORCSss5vLh2wf9A+e5NK/v2Au744wHOKyOhDq+ t11IqMymFm8YrBU9j8IxtT5tOnyWlfwRRhtMyVj0k/kzJFJy+yFGjAPeHCHMjKs9bFfi H7jPbZaP1SR9E3iyKoC/KPvFHFbCkx7zGaAKVaA8SASSccqzxh0FkgO2DDCYP+ActL5+ ap3lL/DNIKe46XfN68+051vKs9kvyGzLdxiT1JvJF12LJLyzFI1MWQqPfxrt8n//yTRb 5+HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yHz8hgfvK5QobDw8MMRzA5sdCgJ7dwazTK+WL1gh9ko=; b=Kake6wKqot83dWVcRKd09YXQrFQZpzW49xTCrFScB+0wc64+vKPqGvIEcWQwzRBiac rmj1toT/iJ8S9iPJg8/DcQViceI0e9JNcXSsypvCPagLD96q8/7JiaaNBjgaZCL5CVX3 3ePTr/s6dRdwMDVZpQTGva1PDivc4+c93/BYUdLEmqVCD/69sST/2pPvQZAwxcsm4IaM 3YIjmbCg9fhaOAfOcPQbaKW3dkwMJwxF3vbJ/wLMHbwZFxVpCclXvzuU5GRnbiyi3A5S +5gpFuUsyNfeOFPZqsPIgkI1dO3n7rV/yndB5KGNDYn3hcrtpkmfPONmAhZwqwEbY5GS WD0w== X-Gm-Message-State: AJaThX6BNSU/jWX0/5PuZ8wvyJEZL4eMvpR+vb9UcrOz3E3bTooGfVSs 2YozZgM8EpTbHJ3n9943GJS1MR4S X-Google-Smtp-Source: ABhQp+SuSO1qdOixIuObbnRj9ivoddQQ6oUneakgEqPVkphHT5/P4XgjIffUXuczPH8P5ARoV0K9dQ== X-Received: by 10.98.89.82 with SMTP id n79mr212762pfb.133.1510092821886; Tue, 07 Nov 2017 14:13:41 -0800 (PST) Received: from localhost ([108.161.26.224]) by smtp.gmail.com with ESMTPSA id m195sm4474297pga.13.2017.11.07.14.13.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Nov 2017 14:13:38 -0800 (PST) From: Matt Turner To: intel-wired-lan@lists.osuosl.org Date: Tue, 7 Nov 2017 14:13:30 -0800 Message-Id: <20171107221332.28283-1-mattst88@gmail.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 08 Nov 2017 14:49:21 +0000 Subject: [Intel-wired-lan] [PATCH 1/3] e1000e: Set HTHRESH when PTHRESH is used X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matt Turner Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" From: Matt Turner According to section 12.0.3.4.13 "Receive Descriptor Control - RXDCTL" of the Intel® 82579 Gigabit Ethernet PHY Datasheet v2.1: "HTHRESH should be given a non zero value when ever PTHRESH is used." In RXDCTL(0), PTHRESH lives at bits 5:0, and HTHREST lives at bits 13:8. Set only bit 8 of HTHREST as is done in e1000_flush_rx_ring(). Found by inspection. Signed-off-by: Matt Turner Tested-by: Aaron Brown --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 2dcb5463d9b8..286d0277284e 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -3285,7 +3285,7 @@ static void e1000_configure_rx(struct e1000_adapter *adapter) if (adapter->flags & FLAG_IS_ICH) { u32 rxdctl = er32(RXDCTL(0)); - ew32(RXDCTL(0), rxdctl | 0x3); + ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8)); } pm_qos_update_request(&adapter->pm_qos_req, lat);