[2/3] e1000e: Alert the user that C-states will be disabled by enabling jumbo frames

Message ID 20171107221332.28283-2-mattst88@gmail.com
State Superseded
Headers show
Series
  • [1/3] e1000e: Set HTHRESH when PTHRESH is used
Related show

Commit Message

Matt Turner Nov. 7, 2017, 10:13 p.m.
From: Matt Turner <matt.turner@intel.com>

I personally spent a long time trying to decypher why my CPU would not
reach deeper C-states. Let's just tell the next user what's going on.

Signed-off-by: Matt Turner <matt.turner@intel.com>
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Neftin, Sasha Nov. 9, 2017, 9:36 a.m. | #1
On 11/8/2017 00:13, Matt Turner wrote:
> From: Matt Turner <matt.turner@intel.com>
>
> I personally spent a long time trying to decypher why my CPU would not
> reach deeper C-states. Let's just tell the next user what's going on.
>
> Signed-off-by: Matt Turner <matt.turner@intel.com>
> ---
>   drivers/net/ethernet/intel/e1000e/netdev.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index 286d0277284e..4dcff481c4b4 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -3288,6 +3288,9 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)
>   			ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8));
>   		}
>   
> +		dev_info(&adapter->pdev->dev,
> +			 "Some CPU C-states have been disabled in order to "
> +			 "enable jumbo frames\n");
>   		pm_qos_update_request(&adapter->pm_qos_req, lat);
>   	} else {
>   		pm_qos_update_request(&adapter->pm_qos_req,

Ack. Let's accept this comments.
Shannon Nelson Nov. 9, 2017, 10:14 p.m. | #2
On 11/9/2017 1:36 AM, Neftin, Sasha wrote:
> On 11/8/2017 00:13, Matt Turner wrote:
>> From: Matt Turner <matt.turner@intel.com>
>>
>> I personally spent a long time trying to decypher why my CPU would not
>> reach deeper C-states. Let's just tell the next user what's going on.
>>
>> Signed-off-by: Matt Turner <matt.turner@intel.com>
>> ---
>>   drivers/net/ethernet/intel/e1000e/netdev.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c 
>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>> index 286d0277284e..4dcff481c4b4 100644
>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>> @@ -3288,6 +3288,9 @@ static void e1000_configure_rx(struct 
>> e1000_adapter *adapter)
>>               ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8));
>>           }
>> +        dev_info(&adapter->pdev->dev,
>> +             "Some CPU C-states have been disabled in order to "
>> +             "enable jumbo frames\n");
>>           pm_qos_update_request(&adapter->pm_qos_req, lat);
>>       } else {
>>           pm_qos_update_request(&adapter->pm_qos_req,
> 
> Ack. Let's accept this comments.

But let's make that a single string, not split between lines.
sln


> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Patch

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 286d0277284e..4dcff481c4b4 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -3288,6 +3288,9 @@  static void e1000_configure_rx(struct e1000_adapter *adapter)
 			ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8));
 		}
 
+		dev_info(&adapter->pdev->dev,
+			 "Some CPU C-states have been disabled in order to "
+			 "enable jumbo frames\n");
 		pm_qos_update_request(&adapter->pm_qos_req, lat);
 	} else {
 		pm_qos_update_request(&adapter->pm_qos_req,