[1/1] ntp: implicitly enable openssl-random

Message ID 20171108131839.27491-1-aduskett@gmail.com
State Accepted, archived
Headers show
Series
  • [1/1] ntp: implicitly enable openssl-random
Related show

Commit Message

Adam Duskett Nov. 8, 2017, 1:18 p.m.
If OpenSSL is selected, --enable-openssl-random should be implicitly
set as well.

Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
 package/ntp/ntp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Nov. 11, 2017, 10:35 p.m. | #1
Hello,

On Wed,  8 Nov 2017 08:18:39 -0500, Adam Duskett wrote:
> If OpenSSL is selected, --enable-openssl-random should be implicitly
> set as well.

So you meant "explicitly", right ?

Thomas
Thomas Petazzoni Nov. 22, 2017, 9:55 p.m. | #2
Hello,

On Sat, 11 Nov 2017 23:35:06 +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed,  8 Nov 2017 08:18:39 -0500, Adam Duskett wrote:
> > If OpenSSL is selected, --enable-openssl-random should be implicitly
> > set as well.  
> 
> So you meant "explicitly", right ?

Ping ?

Thanks,

Thomas
Peter Korsgaard Feb. 4, 2018, 3:22 p.m. | #3
>>>>> "Adam" == Adam Duskett <aduskett@gmail.com> writes:

 > If OpenSSL is selected, --enable-openssl-random should be implicitly
 > set as well.

 > Signed-off-by: Adam Duskett <aduskett@gmail.com>

Committed after fixing/extending the commit message to explain that this
is just for consistency with the disable case, thanks.

Patch

diff --git a/package/ntp/ntp.mk b/package/ntp/ntp.mk
index 6605c3b85b..26d186e976 100644
--- a/package/ntp/ntp.mk
+++ b/package/ntp/ntp.mk
@@ -24,7 +24,7 @@  NTP_CONF_OPTS = \
 NTP_AUTORECONF = YES
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
-NTP_CONF_OPTS += --with-crypto
+NTP_CONF_OPTS += --with-crypto --enable-openssl-random
 NTP_DEPENDENCIES += openssl
 else
 NTP_CONF_OPTS += --without-crypto --disable-openssl-random