Message ID | a7b9f0a21bf6e0c3325a0d9a28a8503082cafd14.1510118606.git.green.hu@gmail.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
Series | Andes(nds32) Linux Kernel Port | expand |
+DT list On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu <green.hu@gmail.com> wrote: > From: Greentime Hu <greentime@andestech.com> Commit msg needed. > Signed-off-by: Rick Chen <rick@andestech.com> > Signed-off-by: Greentime Hu <greentime@andestech.com> > --- > .../interrupt-controller/andestech,ativic32.txt | 27 ++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt b/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt > new file mode 100644 > index 0000000..6bac908 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt > @@ -0,0 +1,27 @@ > +* Andestech Internal Vector Interrupt Controller > + > +The Internal Vector Interrupt Controller (IVIC) is a basic interrupt controller > +suitable for a simpler SoC platform not requiring a more sophisticated and > +bigger External Vector Interrupt Controller. > + > + > +Main node required properties: > + > +- compatible : should at least contain "andestech,ativic32". > +- interrupt-parent: Empty for the interrupt controller itself Drop this. > +- interrupt-controller : Identifies the node as an interrupt controller > +- #interrupt-cells: The number of cells to define the interrupts. Should be 2. > + The first cell is the IRQ number > + The second cell is used to specify mode: > + 1 = low-to-high edge triggered > + 2 = high-to-low edge triggered > + 4 = active high level-sensitive > + 8 = active low level-sensitive Just state 2 cells and refer to interrupt-controller/interrupts.txt. > + Default for internal sources should be set to 4 (active high). > + > +Examples: > + intc: interrupt-controller { > + compatible = "andestech,ativic32"; > + #interrupt-cells = <2>; > + interrupt-controller; > + }; > -- > 1.7.9.5 >
2017-11-08 21:25 GMT+08:00 Rob Herring <robh+dt@kernel.org>: > +DT list > > On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu <green.hu@gmail.com> wrote: >> From: Greentime Hu <greentime@andestech.com> > > Commit msg needed. Thanks. I will add commit msg in the next version patch. >> Signed-off-by: Rick Chen <rick@andestech.com> >> Signed-off-by: Greentime Hu <greentime@andestech.com> >> --- >> .../interrupt-controller/andestech,ativic32.txt | 27 ++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt b/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt >> new file mode 100644 >> index 0000000..6bac908 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt >> @@ -0,0 +1,27 @@ >> +* Andestech Internal Vector Interrupt Controller >> + >> +The Internal Vector Interrupt Controller (IVIC) is a basic interrupt controller >> +suitable for a simpler SoC platform not requiring a more sophisticated and >> +bigger External Vector Interrupt Controller. >> + >> + >> +Main node required properties: >> + >> +- compatible : should at least contain "andestech,ativic32". >> +- interrupt-parent: Empty for the interrupt controller itself > > Drop this. Thanks. I will fix it in the next version patch. >> +- interrupt-controller : Identifies the node as an interrupt controller >> +- #interrupt-cells: The number of cells to define the interrupts. Should be 2. >> + The first cell is the IRQ number >> + The second cell is used to specify mode: >> + 1 = low-to-high edge triggered >> + 2 = high-to-low edge triggered >> + 4 = active high level-sensitive >> + 8 = active low level-sensitive > > Just state 2 cells and refer to interrupt-controller/interrupts.txt. Thanks. I will fix it in the next version patch. >> + Default for internal sources should be set to 4 (active high). >> + >> +Examples: >> + intc: interrupt-controller { >> + compatible = "andestech,ativic32"; >> + #interrupt-cells = <2>; >> + interrupt-controller; >> + }; >> -- >> 1.7.9.5 >>
diff --git a/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt b/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt new file mode 100644 index 0000000..6bac908 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt @@ -0,0 +1,27 @@ +* Andestech Internal Vector Interrupt Controller + +The Internal Vector Interrupt Controller (IVIC) is a basic interrupt controller +suitable for a simpler SoC platform not requiring a more sophisticated and +bigger External Vector Interrupt Controller. + + +Main node required properties: + +- compatible : should at least contain "andestech,ativic32". +- interrupt-parent: Empty for the interrupt controller itself +- interrupt-controller : Identifies the node as an interrupt controller +- #interrupt-cells: The number of cells to define the interrupts. Should be 2. + The first cell is the IRQ number + The second cell is used to specify mode: + 1 = low-to-high edge triggered + 2 = high-to-low edge triggered + 4 = active high level-sensitive + 8 = active low level-sensitive + Default for internal sources should be set to 4 (active high). + +Examples: + intc: interrupt-controller { + compatible = "andestech,ativic32"; + #interrupt-cells = <2>; + interrupt-controller; + };