From patchwork Tue Nov 7 13:17:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 835260 X-Patchwork-Delegate: ian.stokes@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="unknown key hash" (0-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="lLglON0g"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yWVPC4fmmz9s74 for ; Wed, 8 Nov 2017 00:18:39 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 5D0AEBAA; Tue, 7 Nov 2017 13:17:46 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C318AB78 for ; Tue, 7 Nov 2017 13:17:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 67EB2439 for ; Tue, 7 Nov 2017 13:17:45 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20171107131743euoutp015abed0847fde374231cf2d6ad2470fa4~00CwtHEnP2503225032euoutp013 for ; Tue, 7 Nov 2017 13:17:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171107131743euoutp015abed0847fde374231cf2d6ad2470fa4~00CwtHEnP2503225032euoutp013 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1510060663; bh=pkprTVls0rKyRtwjrW87zL1GJMc4SKhe2V6ttN0MwJA=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=lLglON0gJSXYIi+7PlQ5jysVHERUITJsf+12sjOTeVJxfmQ37QjWTR7akBOOcCoLn IoM+h6ofI1rWk40TBiYfeowRq1MvfKOuStbjwJiUsVu/Kz0k9Q9PFolPMK2Y+WnnOf xmAZkV1tvxQ5fviupvi5T8LrBGIft3H6RPd3KQG8= Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171107131742eucas1p2c9d63d92f82992afbc8f24a442af2ed4~00Cv4Erd13145831458eucas1p2v; Tue, 7 Nov 2017 13:17:42 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges5.samsung.com (EUCPMTA) with SMTP id 64.A5.12743.672B10A5; Tue, 7 Nov 2017 13:17:42 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171107131741eucas1p2a3b5e8301ea97ef8725ce3ec3af1b235~00CvEzF4k3143831438eucas1p2l; Tue, 7 Nov 2017 13:17:41 +0000 (GMT) X-AuditID: cbfec7f5-f79d06d0000031c7-35-5a01b2766dfc Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AC.8E.18832.572B10A5; Tue, 7 Nov 2017 13:17:41 +0000 (GMT) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OZ100KAFU9625B0@eusync3.samsung.com>; Tue, 07 Nov 2017 13:17:41 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Tue, 07 Nov 2017 16:17:28 +0300 Message-id: <1510060648-30484-3-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1510060648-30484-1-git-send-email-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsWy7djP87plmxijDNb+YLGY9vk2u8WV9p/s FnM/PWd0YPZ4dvM/o0ffllWMAUxRXDYpqTmZZalF+nYJXBkfLr5iKZjHUbF+insD42q2LkZO DgkBE4k7VzYwQthiEhfurQeKc3EICSxllPgy7w2U85lR4vvSlXAdjQ8PsUIkljFKLL/5jAnC aWaSeN/zAGwWm4COxKnVR8BsEQFpide9b1hBbGaBYIkd64+BTRIWCJL4dHkeWA2LgKpEx6NG oDgHB6+Am8T2y7wQy+Qkbp7rZAaxOQXcJZ5sm8kIsktC4CarxJMvH5khilwkjj35A3WdsMSr 41vYIWwZic6Og0wQDc2MEg2rLkF1TwB6rnk5E0SVvcSpm1eZIK7jk5i0bTozyBUSArwSHW1C ECUeEtdmX4Va5ijR+3Qj1MezGCU2/ZrFPoFRegEjwypGkdTS4tz01GJTveLE3OLSvHS95Pzc TYzAODv97/jXHYxLj1kdYhTgYFTi4Z1xkCFKiDWxrLgy9xCjBAezkgjvdnWgEG9KYmVValF+ fFFpTmrxIUZpDhYlcV7bqLZIIYH0xJLU7NTUgtQimCwTB6dUA+OGZMUtu6bnXQz9KmG+7MoW O2Pt9ze+XYhjyH8yZffFM0xtu0IX88jN3BZmul+1Wo9Bu6TczcLEx1NXwWvKhYTFnWGzM8Mu mD5uVouP8RF2Lc0OebdRXMJ86R/1LPYdIhM7Pf1ko71z1a6KMBnxfLAQ4Y+7sO/qFtPJYr+n XeKqcfpm5femUImlOCPRUIu5qDgRABFVYimvAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHJMWRmVeSWpSXmKPExsVy+t/xq7qlmxijDNoXyFhM+3yb3eJK+092 i7mfnjM6MHs8u/mf0aNvyyrGAKYoLpuU1JzMstQifbsErowPF1+xFMzjqFg/xb2BcTVbFyMn h4SAiUTjw0OsELaYxIV764HiXBxCAksYJXZenccK4bQySVz/8pERpIpNQEfi1OojYLaIgLTE 6943YN3MAsESB4/9AopzcAgLBEh8eghWwiKgKtHxqJENJMwr4Cax/TIvxC45iZvnOplBbE4B d4kn22aClQsBlazd9YVpAiPvAkaGVYwiqaXFuem5xYZ6xYm5xaV56XrJ+bmbGIGhsO3Yz807 GC9tDD7EKMDBqMTD++EwQ5QQa2JZcWXuIUYJDmYlEd7t6kAh3pTEyqrUovz4otKc1OJDjNIc LErivL17VkcKCaQnlqRmp6YWpBbBZJk4OKUaGNm7VrL0njkcekL+oXPp7U+1S74mvZos4d9h /MUlyKDH8X9EAvvTe+93XO2dG97uHFIt8tqryEvqg8ibAxMeC/bHRM99nCsqKPZ5/ULzedZf GDhY7X68ZAtc8+fkgUspd1m3f7H+nq51RHt/ndN9rSNiswqqHxXLnZz8I2FXkBjrsaoZlT/f LlBiKc5INNRiLipOBAAYmy2qAQIAAA== X-CMS-MailID: 20171107131741eucas1p2a3b5e8301ea97ef8725ce3ec3af1b235 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171107131741eucas1p2a3b5e8301ea97ef8725ce3ec3af1b235 X-RootMTR: 20171107131741eucas1p2a3b5e8301ea97ef8725ce3ec3af1b235 References: <1510060648-30484-1-git-send-email-i.maximets@samsung.com> X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=disabled version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets , Heetae Ahn Subject: [ovs-dev] [PATCH 2/2] netdev-dpdk: Add comment about variables naming convention. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 872b133..9423109 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -330,6 +330,23 @@ enum dpdk_hw_ol_features { NETDEV_RX_CHECKSUM_OFFLOAD = 1 << 0, }; +/* + * In order to avoid confusion in variables names, following naming convention + * should be used, if possible: + * + * 'struct netdev' : 'netdev' + * 'struct netdev_dpdk' : 'dev' + * 'struct netdev_rxq' : 'rxq' + * 'struct netdev_rxq_dpdk' : 'rx' + * + * Example: + * struct netdev *netdev = netdev_from_name(name); + * struct netdev_dpdk *dev = netdev_dpdk_cast(netdev); + * + * Also, 'netdev' should be used instead of 'dev->up', where 'netdev' was + * already defined. + */ + struct netdev_dpdk { PADDED_MEMBERS_CACHELINE_MARKER(CACHE_LINE_SIZE, cacheline0, dpdk_port_t port_id;