| Message ID | 20171106140546.24643-1-jfreimann@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] net/socket: fix coverity issue | expand |
diff --git a/net/socket.c b/net/socket.c index e6b471c63d..09c9b2a5d1 100644 --- a/net/socket.c +++ b/net/socket.c @@ -373,7 +373,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, net_socket_read_poll(s, true); /* mcast: save bound address as dst */ - if (is_connected) { + if (is_connected && mcast != NULL) { s->dgram_dst = saddr; snprintf(nc->info_str, sizeof(nc->info_str), "socket: fd=%d (cloned mcast=%s:%d)",
This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-stable@nongnu.org Reported-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Jens Freimann <jfreimann@redhat.com> --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)