diff mbox series

[v3,05/21] vxlan: exit_net cleanup checks added

Message ID	498a33a1-a62e-d776-ae61-512740e52ff1@virtuozzo.com
State	Changes Requested, archived
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> From: Vasily Averin <vvs@virtuozzo.com> Subject: [PATCH v3 05/21] vxlan: exit_net cleanup checks added To: netdev@vger.kernel.org References: <4fdc4264-e338-6ee8-a662-7d98b45733a1@virtuozzo.com> Message-ID: <498a33a1-a62e-d776-ae61-512740e52ff1@virtuozzo.com> Date: Mon, 6 Nov 2017 16:23:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4fdc4264-e338-6ee8-a662-7d98b45733a1@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	exit_net checks for objects initialized in net_init hook \| expand [v2,00/21] exit_net checks for objects initialized in net_init hook [v3,01/21] grace: replace BUG_ON by WARN_ONCE in exit_net hook [v3,02/21] lockd: added cleanup checks in exit_net hook [v3,03/21] exit_net cleanup: geneve sock_list check [v3,04/21] ppp: exit_net cleanup checks added [v3,05/21] vxlan: exit_net cleanup checks added [v3,06/21] netdev: exit_net cleanup check added [v3,07/21] nfs4blocklayout: exit_net cleanup check added [v3,08/21] nfs client: exit_net cleanup check added [v3,09/21] fib_notifier: exit_net cleanup check added [v3,10/21] fib_rules: exit_net cleanup check added [v3,11/21] clusterip: exit_net cleanup check added [v3,12/21] xfrm6_tunnel: exit_net cleanup check added [v3,13/21] af_key: replace BUG_ON on WARN_ONCE in net_exit hook [v3,14/21] l2tp: exit_net cleanup check added [v3,15/21] nf_tables: exit_net cleanup check added [v3,16/21] nfnetlink_log: exit_net cleanup check added [v3,17/21] nfnetlink_gueue: exit_net cleanup check added [v3,18/21] x_tables: exit_net cleanup check added [v3,19/21] packet: exit_net cleanup check added [v3,20/21] phonet: exit_net cleanup check added [v3,21/21] sunrpc: exit_net cleanup check added

Commit Message

Vasily Averin Nov. 6, 2017, 1:23 p.m. UTC

Be sure that sock_list array initialized in net_init hook was return
to initial state

Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
 drivers/net/vxlan.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff mbox series

Patch

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index d7c49cf..acf5763 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -3704,6 +3704,7 @@  static void __net_exit vxlan_exit_net(struct net *net)
 	struct vxlan_net *vn = net_generic(net, vxlan_net_id);
 	struct vxlan_dev *vxlan, *next;
 	struct net_device *dev, *aux;
+	unsigned int h;
 	LIST_HEAD(list);
 
 	rtnl_lock();
@@ -3723,6 +3724,12 @@  static void __net_exit vxlan_exit_net(struct net *net)
 
 	unregister_netdevice_many(&list);
 	rtnl_unlock();
+
+	for (h = 0; h < PORT_HASH_SIZE; ++h)
+		if (WARN_ONCE(!hlist_empty(&vn->sock_list[h]),
+			      "net %x %s: sock_list is not empty\n",
+			      net->ns.inum, __func__))
+			break;
 }
 
 static struct pernet_operations vxlan_net_ops = {