diff mbox series

[12/21] l2tp: exit_net cleanup check added

Message ID	32b4a85d-85c4-0509-019e-27475ac70d58@virtuozzo.com
State	Changes Requested, archived
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> From: Vasily Averin <vvs@virtuozzo.com> Subject: [PATCH 12/21] l2tp: exit_net cleanup check added To: netdev@vger.kernel.org Message-ID: <32b4a85d-85c4-0509-019e-27475ac70d58@virtuozzo.com> Date: Sun, 5 Nov 2017 13:01:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	exit_net checks for objects initialized in net_init hook \| expand [00/21] exit_net checks for objects initialized in net_init hook [01/21] exit_net cleanup: geneve sock_list check [02/21] ppp: exit_net cleanup checks added [03/21] vxlan: exit_net cleanup checks added [04/21] netdev: exit_net cleanup check added [05/21] nfs4blocklayout: exit_net cleanup check added [06/21] nfs client: exit_net cleanup check added [07/21] fib_notifier: exit_net cleanup check added [08/21] fib_rules: exit_net cleanup check added [09/21] clusterip: exit_net cleanup check added [10/21] xfrm6_tunnel: exit_net cleanup check added [11/21] af_key: replace BUG_ON on WARN_ON in net_exit hook [12/21] l2tp: exit_net cleanup check added [13/21] nf_tables: exit_net cleanup check added [14/21] nfnetlink_log: exit_net cleanup check added [15/21] nfnetlink_gueue: exit_net cleanup check added [16/21] x_tables: exit_net cleanup check added [17/21] hashlimit: exit_net cleanup check added [18/21] recent: exit_net cleanup check added [19/21] packet: exit_net cleanup check added [20/21] phonet: exit_net cleanup check added [21/21] sunrpc: exit_net cleanup check added

Commit Message

Vasily Averin Nov. 5, 2017, 10:01 a.m. UTC

Be sure that l2tp_session_hlist array initialized in net_init hook was return
to initial state.

Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
 net/l2tp/l2tp_core.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff mbox series

Patch

diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index 02d6110..109fd36 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -1888,6 +1888,7 @@  static __net_exit void l2tp_exit_net(struct net *net)
 {
 	struct l2tp_net *pn = l2tp_pernet(net);
 	struct l2tp_tunnel *tunnel = NULL;
+	int hash;
 
 	rcu_read_lock_bh();
 	list_for_each_entry_rcu(tunnel, &pn->l2tp_tunnel_list, list) {
@@ -1897,6 +1898,11 @@  static __net_exit void l2tp_exit_net(struct net *net)
 
 	flush_workqueue(l2tp_wq);
 	rcu_barrier();
+
+	for (hash = 0; hash < L2TP_HASH_SIZE_2; hash++)
+		if (WARN(!hlist_empty(&pn->l2tp_session_hlist[hash]),
+			 "net %p exit: l2tp session_hlist is not empty\n", net))
+			break;
 }
 
 static struct pernet_operations l2tp_net_ops = {