From patchwork Sat Nov 4 21:26:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugene Rudoy X-Patchwork-Id: 834237 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=uclibc-ng.org (client-ip=2a00:1828:2000:679::23; helo=helium.openadk.org; envelope-from=devel-bounces@uclibc-ng.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Gm7jWWWX"; dkim-atps=neutral Received: from helium.openadk.org (helium.openadk.org [IPv6:2a00:1828:2000:679::23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yTsMk4yMyz9t2Z for ; Sun, 5 Nov 2017 08:26:39 +1100 (AEDT) Received: from helium.openadk.org (localhost [IPv6:::1]) by helium.openadk.org (Postfix) with ESMTP id F270210290; Sat, 4 Nov 2017 22:24:01 +0100 (CET) X-Original-To: devel@uclibc-ng.org Delivered-To: devel@helium.openadk.org Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by helium.openadk.org (Postfix) with ESMTPS id EA95010290 for ; Sat, 4 Nov 2017 22:23:59 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id r68so7557368wmr.3 for ; Sat, 04 Nov 2017 14:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XvRojH9LLVv2wAkXnbN4fehdz6oeoKC3zXMcJfLLKfE=; b=Gm7jWWWXbzzi/svZGfd1AsVrWylHz4fZLGtHj+JF+TBa6KjnESe7k/NU2ObfKwOxQ1 rFX3Mufpkc/OSkNgEoSZJpVH9AdcPQ+f1LIqtSfYw/fgIvUo2t69uVpEy8k6XNK/cceT NUpFb6i31FK4RP0OUKCEk6OgaXw9qqPDFahceY2lZCr0CrD98OcHnvr+hWJcKE0Lt2h8 aTvaqelxbMTdZBobv1oMgF733ENNJzxeNDuii6oQrtYV/J9um0brs/yDSLfqgz+3cFhS JHi1jvXrq/PucITkUv9T6rIW5qJDEbHgShZdcH0B+1MXPrDfYcsGP+vSMMVbgkK4cfqT gSwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XvRojH9LLVv2wAkXnbN4fehdz6oeoKC3zXMcJfLLKfE=; b=tq6DoJgYszAPkpg3oI+iLDJmukwxR/fD54g0QNncJyarKaGWptQoo1NAyspCV5PlXX 97FnWW8nof4HVZLQoICYGw2j0l/+hvOl2yav4IQxXbSISbksR1yIzDkEvPqWHgxeDHBK SKOb4On7qrIQkKSD9Jy4GBU9uEjhyLS36pjMJYPQmsgKZwlnymVrozivAy7jt3sxZKh1 Kx5PBVOBZec3PuzqkwK0T0BJNVr+4ObhI67JsbF08TFITX2tmjguiNysCIWkySCnQ2YP 333aXXIgaG2104iwdGc0NGD3Md+7pcvUcQplU/5kaKOfyIYYUxWVEjhRRnLqyy4NoP4n uASA== X-Gm-Message-State: AJaThX6n3lXpYkuAwfF21U8W4PAW0uT8EMbbSt5lC7zLAIHx0SUIDnNt EdqxCydfRAdZ5wo/qwRPAZt3vw== X-Google-Smtp-Source: ABhQp+SiG3tk3MIOulRyjo0Qy4J4WuIZaUJPhPJDj6sD+Row8+kNpvUuo94gJBhihQHYbJqbsUf9Ww== X-Received: by 10.28.48.143 with SMTP id w137mr2160034wmw.3.1509830790252; Sat, 04 Nov 2017 14:26:30 -0700 (PDT) Received: from bubonestvm.bgnet (aftr-37-201-227-185.unity-media.net. [37.201.227.185]) by smtp.gmail.com with ESMTPSA id h8sm3193569wme.30.2017.11.04.14.26.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 04 Nov 2017 14:26:29 -0700 (PDT) From: Eugene Rudoy To: devel@uclibc-ng.org Date: Sat, 4 Nov 2017 22:26:19 +0100 Message-Id: <20171104212621.3370-1-gene.devel@gmail.com> X-Mailer: git-send-email 2.14.2 Cc: Ralf.Friedl@online.de Subject: [uclibc-ng-devel] [PATCH 1/3] [mips] remove misleading comment about f_frsize field X-BeenThere: devel@uclibc-ng.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: uClibc-ng Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: devel-bounces@uclibc-ng.org Sender: "devel" It is supported both in the sense of being contained in mips version of statfs/statfs64 structs and also in the sense that it's filled by the corresponding kernel syscalls. It is UNsupported in that sense that it's value is the same as that of f_bsize (at least on older kernel versions, the oldest version tested is 2.6.13), s. [1] and [2] for details ([1] is the latest kernel version as of now, [2] is the oldest kernel version git history is available for). [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/fs/statfs.c?h=v4.14-rc7#n64 [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/fs/open.c?h=v2.6.12-rc2#n41 Follow-up of 68de9946e914d8c30dcc6667a059ea59e5b74cac Signed-off-by: Eugene Rudoy Signed-off-by: Ralf Friedl --- libc/sysdeps/linux/mips/bits/statfs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libc/sysdeps/linux/mips/bits/statfs.h b/libc/sysdeps/linux/mips/bits/statfs.h index 673120d1a..baa964532 100644 --- a/libc/sysdeps/linux/mips/bits/statfs.h +++ b/libc/sysdeps/linux/mips/bits/statfs.h @@ -26,7 +26,7 @@ struct statfs long int f_type; #define f_fstyp f_type long int f_bsize; - long int f_frsize; /* Fragment size - unsupported */ + long int f_frsize; #ifndef __USE_FILE_OFFSET64 __fsblkcnt_t f_blocks; __fsblkcnt_t f_bfree; @@ -53,7 +53,7 @@ struct statfs64 long int f_type; #define f_fstyp f_type long int f_bsize; - long int f_frsize; /* Fragment size - unsupported */ + long int f_frsize; __fsblkcnt64_t f_blocks; __fsblkcnt64_t f_bfree; __fsblkcnt64_t f_files;