diff mbox series

[uclibc-ng-devel,1/3,mips] remove misleading comment about f_frsize field

Message ID 20171104212621.3370-1-gene.devel@gmail.com
State Accepted
Headers show
Series [uclibc-ng-devel,1/3,mips] remove misleading comment about f_frsize field | expand

Commit Message

Eugene Rudoy Nov. 4, 2017, 9:26 p.m. UTC 
It is supported both in the sense of being contained in mips version
of statfs/statfs64 structs and also in the sense that it's filled by
the corresponding kernel syscalls.

It is UNsupported in that sense that it's value is the same as that
of f_bsize (at least on older kernel versions, the oldest version
tested is 2.6.13), s. [1] and [2] for details ([1] is the latest
kernel version as of now, [2] is the oldest kernel version git
history is available for).

[1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/fs/statfs.c?h=v4.14-rc7#n64
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/fs/open.c?h=v2.6.12-rc2#n41

Follow-up of 68de9946e914d8c30dcc6667a059ea59e5b74cac

Signed-off-by: Eugene Rudoy <gene.devel@gmail.com>
Signed-off-by: Ralf Friedl <Ralf.Friedl@online.de>
---
 libc/sysdeps/linux/mips/bits/statfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Waldemar Brodkorb Nov. 28, 2017, 6:41 p.m. UTC | #1 
Hi Eugene,
Eugene Rudoy wrote,

> It is supported both in the sense of being contained in mips version
> of statfs/statfs64 structs and also in the sense that it's filled by
> the corresponding kernel syscalls.
> 
> It is UNsupported in that sense that it's value is the same as that
> of f_bsize (at least on older kernel versions, the oldest version
> tested is 2.6.13), s. [1] and [2] for details ([1] is the latest
> kernel version as of now, [2] is the oldest kernel version git
> history is available for).

Thanks for the patches, I applied and pushed all three.
They are part of the latest release.

best regards
 Waldemar
diff mbox series

Patch

diff --git a/libc/sysdeps/linux/mips/bits/statfs.h b/libc/sysdeps/linux/mips/bits/statfs.h
index 673120d1a..baa964532 100644
--- a/libc/sysdeps/linux/mips/bits/statfs.h
+++ b/libc/sysdeps/linux/mips/bits/statfs.h
@@ -26,7 +26,7 @@  struct statfs
     long int f_type;
 #define f_fstyp f_type
     long int f_bsize;
-    long int f_frsize;	/* Fragment size - unsupported */
+    long int f_frsize;
 #ifndef __USE_FILE_OFFSET64
     __fsblkcnt_t f_blocks;
     __fsblkcnt_t f_bfree;
@@ -53,7 +53,7 @@  struct statfs64
     long int f_type;
 #define f_fstyp f_type
     long int f_bsize;
-    long int f_frsize;	/* Fragment size - unsupported */
+    long int f_frsize;
     __fsblkcnt64_t f_blocks;
     __fsblkcnt64_t f_bfree;
     __fsblkcnt64_t f_files;