| Message ID | 20171103212216.11772-1-yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Commit | 4013f11a5b71f238b36f45dcdeb46b7f7a01e600 |
| Headers | show |
| Series | suport/download: force svn to be non-interactive | expand |
Am 03.11.2017 um 22:22 schrieb Yann E. MORIN: > Fixes: > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: André Hentschel <nerv@dawncrow.de> > --- > support/download/svn | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/support/download/svn b/support/download/svn > index 77abf3d02d..9f27d71f86 100755 > --- a/support/download/svn > +++ b/support/download/svn > @@ -33,6 +33,6 @@ _svn() { > eval ${SVN} "${@}" > } > > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > > tar czf "${output}" "${basename}" > Signed-off-by: André Hentschel <nerv@dawncrow.de>
On 05-11-17 15:46, André Hentschel wrote: > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN: >> Fixes: >> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ >> >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> Cc: André Hentschel <nerv@dawncrow.de> >> --- >> support/download/svn | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/support/download/svn b/support/download/svn >> index 77abf3d02d..9f27d71f86 100755 >> --- a/support/download/svn >> +++ b/support/download/svn >> @@ -33,6 +33,6 @@ _svn() { >> eval ${SVN} "${@}" >> } >> >> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" >> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" >> >> tar czf "${output}" "${basename}" >> > > > Signed-off-by: André Hentschel <nerv@dawncrow.de> Signed-off-by is only relevant when you propagate a patch (create one or resend someone else's). The Signed-off-by is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. See http://elinux.org/Developer_Certificate_Of_Origin for more details. I guess you meant either Tested-by, Reviewed-by or Acked-by. Note that those three get picked up by patchwork, will be part of the git log, and will be reported in the release announcement. Regards, Arnout
André, All, On 2017-11-05 15:46 +0100, André Hentschel spake thusly: > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN: > > Fixes: > > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Cc: André Hentschel <nerv@dawncrow.de> > > --- > > support/download/svn | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/support/download/svn b/support/download/svn > > index 77abf3d02d..9f27d71f86 100755 > > --- a/support/download/svn > > +++ b/support/download/svn > > @@ -33,6 +33,6 @@ _svn() { > > eval ${SVN} "${@}" > > } > > > > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > > > > tar czf "${output}" "${basename}" > > > > Signed-off-by: André Hentschel <nerv@dawncrow.de> Did you mean "Tested-by" or "Reviewed-by" instead? Regards, Yann E. MORIN.
Am 03.11.2017 um 22:22 schrieb Yann E. MORIN: > Fixes: > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: André Hentschel <nerv@dawncrow.de> > --- > support/download/svn | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/support/download/svn b/support/download/svn > index 77abf3d02d..9f27d71f86 100755 > --- a/support/download/svn > +++ b/support/download/svn > @@ -33,6 +33,6 @@ _svn() { > eval ${SVN} "${@}" > } > > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > > tar czf "${output}" "${basename}" > Reviewed-by: André Hentschel <nerv@dawncrow.de>
Hello, On Sun, 5 Nov 2017 15:46:14 +0100, André Hentschel wrote: > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN: > > Fixes: > > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Cc: André Hentschel <nerv@dawncrow.de> > > --- > > support/download/svn | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/support/download/svn b/support/download/svn > > index 77abf3d02d..9f27d71f86 100755 > > --- a/support/download/svn > > +++ b/support/download/svn > > @@ -33,6 +33,6 @@ _svn() { > > eval ${SVN} "${@}" > > } > > > > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > > > > tar czf "${output}" "${basename}" > > > > > Signed-off-by: André Hentschel <nerv@dawncrow.de> Such a Signed-off-by doesn't make sense, because you're not passing the code to someone else. You probably wanted to give one (or several) of the following: - Reviewed-by: - Tested-by: - Acked-by: See the manual for the detailed definition of those tags. Thanks! Thomas
On 05-11-17 16:14, André Hentschel wrote: > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN: >> Fixes: >> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ >> >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> Cc: André Hentschel <nerv@dawncrow.de> >> --- >> support/download/svn | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/support/download/svn b/support/download/svn >> index 77abf3d02d..9f27d71f86 100755 >> --- a/support/download/svn >> +++ b/support/download/svn >> @@ -33,6 +33,6 @@ _svn() { >> eval ${SVN} "${@}" >> } >> >> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" >> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" >> >> tar czf "${output}" "${basename}" >> > > > Reviewed-by: André Hentschel <nerv@dawncrow.de> Thanks! Sorry that Thomas, Yann and I gave you the same message three times. Race conditions, difficult to avoid :-) Regards, Arnout
All, On 2017-11-05 17:34 +0100, Arnout Vandecappelle spake thusly: > On 05-11-17 16:14, André Hentschel wrote: > > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN: > >> Fixes: > >> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ > >> > >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > >> Cc: André Hentschel <nerv@dawncrow.de> > >> --- > >> support/download/svn | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/support/download/svn b/support/download/svn > >> index 77abf3d02d..9f27d71f86 100755 > >> --- a/support/download/svn > >> +++ b/support/download/svn > >> @@ -33,6 +33,6 @@ _svn() { > >> eval ${SVN} "${@}" > >> } > >> > >> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > >> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > >> > >> tar czf "${output}" "${basename}" > >> > > > > > > Reviewed-by: André Hentschel <nerv@dawncrow.de> > > Thanks! Sorry that Thomas, Yann and I gave you the same message three times. > Race conditions, difficult to avoid :-) lock(buildroot.mailing_list) Yeah I found it pretty funny in retrospect. A bit like the other discussion about BR2_REPRODUCIBLE where I basically repeated Thomas and Peter's words, when I should have just read the entire thread before replying. Regards, Yann E. MORIN.
On 2017-11-05 17:40 +0100, Yann E. MORIN spake thusly: > All, > > On 2017-11-05 17:34 +0100, Arnout Vandecappelle spake thusly: > > On 05-11-17 16:14, André Hentschel wrote: > > > Am 03.11.2017 um 22:22 schrieb Yann E. MORIN: > > >> Fixes: > > >> http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ > > >> > > >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > >> Cc: André Hentschel <nerv@dawncrow.de> > > >> --- > > >> support/download/svn | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >> diff --git a/support/download/svn b/support/download/svn > > >> index 77abf3d02d..9f27d71f86 100755 > > >> --- a/support/download/svn > > >> +++ b/support/download/svn > > >> @@ -33,6 +33,6 @@ _svn() { > > >> eval ${SVN} "${@}" > > >> } > > >> > > >> -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > > >> +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" > > >> > > >> tar czf "${output}" "${basename}" > > >> > > > > > > > > > Reviewed-by: André Hentschel <nerv@dawncrow.de> > > > > Thanks! Sorry that Thomas, Yann and I gave you the same message three times. > > Race conditions, difficult to avoid :-) > > lock(buildroot.mailing_list) > > Yeah I found it pretty funny in retrospect. A bit like the other > discussion about BR2_REPRODUCIBLE where I basically repeated Thomas and > Peter's words, when I should have just read the entire thread before > replying. Aha! got y'all stuck! unlock(buildroot.mailing_list) There, fixed. ;] Regards, Yann E. MORIN.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > Fixes: > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: André Hentschel <nerv@dawncrow.de> Committed, thanks.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > Fixes: > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: André Hentschel <nerv@dawncrow.de> Committed to 2017.02.x and 2017.08.x, thanks.
diff --git a/support/download/svn b/support/download/svn index 77abf3d02d..9f27d71f86 100755 --- a/support/download/svn +++ b/support/download/svn @@ -33,6 +33,6 @@ _svn() { eval ${SVN} "${@}" } -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'" tar czf "${output}" "${basename}"
Fixes: http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/ Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: André Hentschel <nerv@dawncrow.de> --- support/download/svn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)