From patchwork Wed Feb 16 12:23:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohan Kumar M X-Patchwork-Id: 83361 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A41BFB711B for ; Wed, 16 Feb 2011 23:47:06 +1100 (EST) Received: from localhost ([127.0.0.1]:59244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ppgmb-0003Pi-Fd for incoming@patchwork.ozlabs.org; Wed, 16 Feb 2011 07:47:01 -0500 Received: from [140.186.70.92] (port=47385 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PpglR-00035b-AT for qemu-devel@nongnu.org; Wed, 16 Feb 2011 07:45:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpglP-0007wJ-PO for qemu-devel@nongnu.org; Wed, 16 Feb 2011 07:45:49 -0500 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:36086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpglO-0007vs-Re for qemu-devel@nongnu.org; Wed, 16 Feb 2011 07:45:47 -0500 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by e28smtp04.in.ibm.com (8.14.4/8.13.1) with ESMTP id p1GCNI6E014659 for ; Wed, 16 Feb 2011 17:53:18 +0530 Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1GCNHVc3842200 for ; Wed, 16 Feb 2011 17:53:17 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1GCNGt6009606 for ; Wed, 16 Feb 2011 23:23:17 +1100 Received: from explorer.in.ibm.com ([9.124.35.46]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p1GCNG0n009565; Wed, 16 Feb 2011 23:23:16 +1100 From: "M. Mohan Kumar" To: qemu-devel@nongnu.org, Stefan Hajnoczi , "Daniel P. Berrange" , blauwirbel@gmail.com Date: Wed, 16 Feb 2011 17:53:13 +0530 Message-Id: <1297858995-24676-7-git-send-email-mohan@in.ibm.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1297858995-24676-1-git-send-email-mohan@in.ibm.com> References: <1297858995-24676-1-git-send-email-mohan@in.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 122.248.162.4 Cc: Subject: [Qemu-devel] [V5 PATCH 6/8] virtio-9p: Support for creating special files X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Add both server and client side interfaces to create special files (directory, device nodes, links and symbolic links) Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-clnt.c | 26 ++++++++++ hw/9pfs/virtio-9p-chroot-sv.c | 59 ++++++++++++++++++++++ hw/9pfs/virtio-9p-chroot.h | 2 + hw/9pfs/virtio-9p-local.c | 104 +++++++++++++++++++++++++++------------ 4 files changed, 160 insertions(+), 31 deletions(-) diff --git a/hw/9pfs/virtio-9p-chroot-clnt.c b/hw/9pfs/virtio-9p-chroot-clnt.c index 7f72add..30366d3 100644 --- a/hw/9pfs/virtio-9p-chroot-clnt.c +++ b/hw/9pfs/virtio-9p-chroot-clnt.c @@ -108,3 +108,29 @@ unlock: qemu_mutex_unlock(&fs_ctx->chroot_mutex); return fd; } + +int v9fs_create_special(FsContext *fs_ctx, + V9fsFileObjectRequest *request, int *error) +{ + int fd; + qemu_mutex_lock(&fs_ctx->chroot_mutex); + if (fs_ctx->chroot_ioerror) { + *error = EIO; + fd = -1; + goto unlock; + } else { + *error = 0; + } + v9fs_write_request(fs_ctx->chroot_socket, request); + fd = v9fs_receivefd(fs_ctx->chroot_socket, error); + if (fd == -EIO && *error == EIO) { + fs_ctx->chroot_ioerror = 1; + } +unlock: + qemu_mutex_unlock(&fs_ctx->chroot_mutex); + if (*error) { + return -1; + } else { + return 0; + } +} diff --git a/hw/9pfs/virtio-9p-chroot-sv.c b/hw/9pfs/virtio-9p-chroot-sv.c index bab5f7c..e3d8843 100644 --- a/hw/9pfs/virtio-9p-chroot-sv.c +++ b/hw/9pfs/virtio-9p-chroot-sv.c @@ -123,6 +123,59 @@ unset_uid: setfsuid(cur_uid); } +/* + * Create directory, symbolic link, link, device node and regular files + * Similar to create, but it does not return the fd of created object + * Returns 0 on success, returns errno on failure + */ +static void chroot_do_create_special(V9fsFileObjectRequest *request, + FdInfo *fd_info) +{ + int cur_uid, cur_gid; + + cur_uid = geteuid(); + cur_gid = getegid(); + + fd_info->fi_fd = -1; + fd_info->fi_error = 0; + + if (setfsuid(request->data.uid) < 0) { + fd_info->fi_error = errno; + return; + } + if (setfsgid(request->data.gid) < 0) { + fd_info->fi_error = errno; + goto unset_uid; + } + + switch (request->data.type) { + case T_MKDIR: + fd_info->fi_fd = mkdir(request->path.path, request->data.mode); + break; + case T_SYMLINK: + fd_info->fi_fd = symlink(request->path.old_path, request->path.path); + break; + case T_LINK: + fd_info->fi_fd = link(request->path.old_path, request->path.path); + break; + default: + fd_info->fi_fd = mknod(request->path.path, request->data.mode, + request->data.dev); + break; + } + + if (fd_info->fi_fd < 0) { + fd_info->fi_error = errno; + } else { + fd_info->fi_error = 0; + fd_info->fi_fd = 0; + } + + setfsgid(cur_gid); +unset_uid: + setfsuid(cur_uid); +} + static int chroot_daemonize(int chroot_sock) { sigset_t sigset; @@ -226,6 +279,12 @@ int v9fs_chroot(FsContext *fs_ctx) case T_CREATE: chroot_do_create(&request, &fd_info); break; + case T_MKDIR: + case T_SYMLINK: + case T_LINK: + case T_MKNOD: + chroot_do_create_special(&request, &fd_info); + break; default: fd_info.fi_fd = 0; fd_info.fi_error = EIO; diff --git a/hw/9pfs/virtio-9p-chroot.h b/hw/9pfs/virtio-9p-chroot.h index 057dcde..7ae1389 100644 --- a/hw/9pfs/virtio-9p-chroot.h +++ b/hw/9pfs/virtio-9p-chroot.h @@ -54,5 +54,7 @@ typedef struct V9fsFileObjectRequest int v9fs_chroot(FsContext *fs_ctx); int v9fs_request(FsContext *fs_ctx, V9fsFileObjectRequest *or, int *error); +int v9fs_create_special(FsContext *fs_ctx, + V9fsFileObjectRequest *request, int *error); #endif /* _QEMU_VIRTIO_9P_CHROOT_H */ diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index 51911dd..9975ed1 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/virtio-9p-local.c @@ -69,6 +69,39 @@ static int passthrough_create(FsContext *fs_ctx, const char *path, int flags, return fd; } +static int passthrough_create_special(FsContext *fs_ctx, const char *oldpath, + const char *path, FsCred *credp, int type) +{ + V9fsFileObjectRequest request; + int retval, error = 0; + + fill_request(&request, path, credp); + switch (type) { + case T_MKNOD: + request.data.type = T_MKNOD; + break; + case T_MKDIR: + request.data.type = T_MKDIR; + break; + case T_SYMLINK: + request.data.type = T_SYMLINK; + break; + case T_LINK: + request.data.type = T_LINK; + break; + } + if (oldpath) { + request.data.oldpath_len = strlen(oldpath); + strcpy(request.path.old_path, oldpath); + } + retval = v9fs_create_special(fs_ctx, &request, &error); + if (retval < 0) { + errno = error; + return 0; + } + return retval; +} + static int local_lstat(FsContext *fs_ctx, const char *path, struct stat *stbuf) { int err; @@ -286,8 +319,7 @@ static int local_mknod(FsContext *fs_ctx, const char *path, FsCred *credp) serrno = errno; goto err_end; } - } else if ((fs_ctx->fs_sm == SM_PASSTHROUGH) || - (fs_ctx->fs_sm == SM_NONE)) { + } else if (fs_ctx->fs_sm == SM_NONE) { err = mknod(rpath(fs_ctx, path), credp->fc_mode, credp->fc_rdev); if (err == -1) { return err; @@ -297,6 +329,12 @@ static int local_mknod(FsContext *fs_ctx, const char *path, FsCred *credp) serrno = errno; goto err_end; } + } else if (fs_ctx->fs_sm == SM_PASSTHROUGH) { + err = passthrough_create_special(fs_ctx, NULL, path, credp, T_MKNOD); + if (err < 0) { + serrno = errno; + goto err_end; + } } return err; @@ -323,8 +361,7 @@ static int local_mkdir(FsContext *fs_ctx, const char *path, FsCred *credp) serrno = errno; goto err_end; } - } else if ((fs_ctx->fs_sm == SM_PASSTHROUGH) || - (fs_ctx->fs_sm == SM_NONE)) { + } else if (fs_ctx->fs_sm == SM_NONE) { err = mkdir(rpath(fs_ctx, path), credp->fc_mode); if (err == -1) { return err; @@ -334,6 +371,12 @@ static int local_mkdir(FsContext *fs_ctx, const char *path, FsCred *credp) serrno = errno; goto err_end; } + } else if (fs_ctx->fs_sm == SM_PASSTHROUGH) { + err = passthrough_create_special(fs_ctx, NULL, path, credp, T_MKDIR); + if (err < 0) { + serrno = errno; + goto err_end; + } } return err; @@ -451,23 +494,19 @@ static int local_symlink(FsContext *fs_ctx, const char *oldpath, serrno = errno; goto err_end; } - } else if ((fs_ctx->fs_sm == SM_PASSTHROUGH) || - (fs_ctx->fs_sm == SM_NONE)) { + } else if (fs_ctx->fs_sm == SM_NONE) { err = symlink(oldpath, rpath(fs_ctx, newpath)); if (err) { return err; } err = lchown(rpath(fs_ctx, newpath), credp->fc_uid, credp->fc_gid); - if (err == -1) { - /* - * If we fail to change ownership and if we are - * using security model none. Ignore the error - */ - if (fs_ctx->fs_sm != SM_NONE) { - serrno = errno; - goto err_end; - } else - err = 0; + err = 0; + } else if (fs_ctx->fs_sm == SM_PASSTHROUGH) { + err = passthrough_create_special(fs_ctx, oldpath, newpath, credp, + T_SYMLINK); + if (err < 0) { + serrno = errno; + goto err_end; } } return err; @@ -478,24 +517,27 @@ err_end: return err; } -static int local_link(FsContext *ctx, const char *oldpath, const char *newpath) +static int local_link(FsContext *fs_ctx, const char *oldpath, + const char *newpath) { - char *tmp = qemu_strdup(rpath(ctx, oldpath)); int err, serrno = 0; - if (tmp == NULL) { - return -ENOMEM; - } - - err = link(tmp, rpath(ctx, newpath)); - if (err == -1) { - serrno = errno; - } - - qemu_free(tmp); - - if (err == -1) { - errno = serrno; + if (fs_ctx->fs_sm == SM_PASSTHROUGH) { + err = passthrough_create_special(fs_ctx, oldpath, newpath, NULL, + T_LINK); + if (err < 0) { + serrno = errno; + } + } else { + char *tmp = qemu_strdup(rpath(fs_ctx, oldpath)); + if (tmp == NULL) { + return -ENOMEM; + } + err = link(tmp, rpath(fs_ctx, newpath)); + if (err == -1) { + serrno = errno; + } + qemu_free(tmp); } return err;