From patchwork Thu Nov 2 23:15:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 833572 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="e34WDhcz"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ySgwN0KLtz9s8J for ; Fri, 3 Nov 2017 10:17:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934578AbdKBXQz (ORCPT ); Thu, 2 Nov 2017 19:16:55 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:53834 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932201AbdKBXQw (ORCPT ); Thu, 2 Nov 2017 19:16:52 -0400 Received: by mail-wr0-f193.google.com with SMTP id u40so1005764wrf.10; Thu, 02 Nov 2017 16:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oBmtbxUa8tpSmehW/jLe/xD7RH1mXDPB8JgeEMEiy5s=; b=e34WDhczo8AXy18UxPBPZ7qD1yO7uXQes+b8jIIPW/J7GycZqKLhOekS5FYDHlPmwU OxJQH5Iz+lbFwEdLTT8o2RIMIvn2TrLXQJkQFfTONI0jwSzlzMrc63441gAazis1EVOr Co1bWq4+hbefV4mMVvjSSgpyjCyqiMQK1QTj8NpncAdVUvvLh0FBiAdqY5pdi22GkkNo uWSrwQooDUek+OQk8+AEkZwEX+72L3OoZdDjwo+DjXiAQqTavWpsOh3fZEmN1JBtDJY2 rsiO6qMPcmSnGAmUknpFz3+Gt1i9KLZ+/GuhResxr+LsjWNIDBoYnJzD55G93mLTHpP7 8+Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oBmtbxUa8tpSmehW/jLe/xD7RH1mXDPB8JgeEMEiy5s=; b=aui5SWmTc/x36JHcRQsHzSQ06KpJmhmZIQ5IKswXInBszphatXKzN2iDjWbfSi9O3I DWbucH/fSWFDNsK3PaHevp9OzxZl1m8MeBkVRjZmkQmxL0HHFc2PyycR6KVl+UtKeFIS SWbxKoMHPrRJnH9W2dzWWzwIQWvBLPHljyuDenJmYmvV0IrUocPQOlqyaUYuSqX9SqGx huxGr/hr32IL7PGUBvGx552BKQyvoRCDktiNIvLrCge07YuBMRBIuldfCr+/B1qDoQnw M2whzhyJHKFBO8ykPA7bHRTWzOjPOkgjPlrYek+KXyRSCbJdUM69inAOhjFZEXd2YGR6 f0yA== X-Gm-Message-State: AMCzsaXE6RlIaeBzIPd3c1Jw8XXOVOfNba6qkSAlHHWG34rGg6NrQnY4 wOWtc3pOQwDGBkI7yM8P34d5wkKT X-Google-Smtp-Source: ABhQp+TjQ804WmQELgd8P3bxAGYQFqF+8JArpiFgavtKWWhgNHZC8hpWAe8gtibDR2lIOQZYZ6R7wA== X-Received: by 10.223.167.65 with SMTP id e1mr4570464wrd.280.1509664611105; Thu, 02 Nov 2017 16:16:51 -0700 (PDT) Received: from fainelli-desktop.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id o8sm2618177wrc.10.2017.11.02.16.16.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Nov 2017 16:16:50 -0700 (PDT) From: Florian Fainelli To: linux-gpio@vger.kernel.org Cc: Florian Fainelli , Linus Walleij , Rob Herring , Mark Rutland , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), ckeepax@opensource.cirrus.com, tony@atomide.com, ckeepax@opensource.wolfsonmicro.com, swarren@nvidia.com, andy.shevchenko@gmail.com, alcooperx@gmail.com, bcm-kernel-feedback-list@broadcom.com Subject: [PATCH v2 1/2] pinctrl: Allow a device to indicate when to force a state Date: Thu, 2 Nov 2017 16:15:50 -0700 Message-Id: <20171102231551.16220-2-f.fainelli@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171102231551.16220-1-f.fainelli@gmail.com> References: <20171102231551.16220-1-f.fainelli@gmail.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It may happen that a device needs to force applying a state, e.g: because it only defines one state of pin states (default) but loses power/register contents when entering low power modes. Add a pinctrl_dev::flags bitmask to help describe future quirks and define PINCTRL_FLG_FORCE_STATE as such a settable flag. Signed-off-by: Florian Fainelli --- drivers/pinctrl/core.c | 14 +++++++++++++- drivers/pinctrl/core.h | 4 ++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 4c8d5b23e4d0..c91359d48aa1 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1197,9 +1197,21 @@ int pinctrl_select_state(struct pinctrl *p, struct pinctrl_state *state) { struct pinctrl_setting *setting, *setting2; struct pinctrl_state *old_state = p->state; + bool force = false; int ret; - if (p->state == state) + if (p->state) { + list_for_each_entry(setting, &p->state->settings, node) { + if (setting->pctldev->flags & PINCTRL_FLG_FORCE_STATE) + force = true; + } + } + + /* Some controllers may want to force this operation when they define + * only one set of functions and lose power state, e.g: pinctrl-single + * with its pinctrl-single,low-power-state-loss property. + */ + if (p->state == state && !force) return 0; if (p->state) { diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h index 8cf2eba17c8c..8f900e152295 100644 --- a/drivers/pinctrl/core.h +++ b/drivers/pinctrl/core.h @@ -39,6 +39,7 @@ struct pinctrl_gpio_range; * @hog_sleep: sleep state for pins hogged by this device * @mutex: mutex taken on each pin controller specific action * @device_root: debugfs root for this device + * @flags: feature/quirk flags */ struct pinctrl_dev { struct list_head node; @@ -63,8 +64,11 @@ struct pinctrl_dev { #ifdef CONFIG_DEBUG_FS struct dentry *device_root; #endif + unsigned long flags; }; +#define PINCTRL_FLG_FORCE_STATE (1 << 0) + /** * struct pinctrl - per-device pin control state holder * @node: global list node