Message ID | 20171101184800.16416-1-jakub.kicinski@netronome.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series | [net-next] security: bpf: replace include of linux/bpf.h with forward declarations | expand |
On Wed, Nov 01, 2017 at 11:48:00AM -0700, Jakub Kicinski wrote: > Touching linux/bpf.h makes us rebuild a surprisingly large > portion of the kernel. Remove the unnecessary dependency > from security.h, it only needs forward declarations. > > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> Acked-by: Alexei Starovoitov <ast@kernel.org> thanks for fixing! I noticed larger rebuilds as well.
On 11/01/2017 07:48 PM, Jakub Kicinski wrote: > Touching linux/bpf.h makes us rebuild a surprisingly large > portion of the kernel. Remove the unnecessary dependency > from security.h, it only needs forward declarations. > > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
From: Jakub Kicinski <jakub.kicinski@netronome.com> Date: Wed, 1 Nov 2017 11:48:00 -0700 > Touching linux/bpf.h makes us rebuild a surprisingly large > portion of the kernel. Remove the unnecessary dependency > from security.h, it only needs forward declarations. > > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> Applied.
diff --git a/include/linux/security.h b/include/linux/security.h index 18800b0911e5..73f1ef625d40 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -31,7 +31,6 @@ #include <linux/string.h> #include <linux/mm.h> #include <linux/fs.h> -#include <linux/bpf.h> struct linux_binprm; struct cred; @@ -1732,6 +1731,10 @@ static inline void securityfs_remove(struct dentry *dentry) #endif #ifdef CONFIG_BPF_SYSCALL +union bpf_attr; +struct bpf_map; +struct bpf_prog; +struct bpf_prog_aux; #ifdef CONFIG_SECURITY extern int security_bpf(int cmd, union bpf_attr *attr, unsigned int size); extern int security_bpf_map(struct bpf_map *map, fmode_t fmode);