| Message ID | 20171031182835.9834-1-bjb@mojatatu.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [net-next] tc-testing: better check if thing is list | expand |
On Tue, Oct 31, 2017 at 2:28 PM, Brenda J. Butler <bjb@mojatatu.com> wrote: > Check if tcase[k] is an instance of a list (is or is derived from list) > instead of checking if it is a list. > > This will be useful if the data structures change to be something > that implements list, instead of being an actual list. In that > case, this code will not have to change. > > Signed-off-by: Brenda J. Butler <bjb@mojatatu.com> Acked-by: Lucas Bates <lucasb@mojatatu.com>
From: "Brenda J. Butler" <bjb@mojatatu.com> Date: Tue, 31 Oct 2017 14:28:35 -0400 > Check if tcase[k] is an instance of a list (is or is derived from list) > instead of checking if it is a list. > > This will be useful if the data structures change to be something > that implements list, instead of being an actual list. In that > case, this code will not have to change. > > Signed-off-by: Brenda J. Butler <bjb@mojatatu.com> Applied.
diff --git a/tools/testing/selftests/tc-testing/tdc_helper.py b/tools/testing/selftests/tc-testing/tdc_helper.py index c3254f861fb2..b4fbb0ce0cbe 100644 --- a/tools/testing/selftests/tc-testing/tdc_helper.py +++ b/tools/testing/selftests/tc-testing/tdc_helper.py @@ -57,7 +57,7 @@ def print_sll(items): def print_test_case(tcase): """ Pretty-printing of a given test case. """ for k in tcase.keys(): - if (type(tcase[k]) == list): + if (isinstance(tcase[k], list)): print(k + ":") print_list(tcase[k]) else:
Check if tcase[k] is an instance of a list (is or is derived from list) instead of checking if it is a list. This will be useful if the data structures change to be something that implements list, instead of being an actual list. In that case, this code will not have to change. Signed-off-by: Brenda J. Butler <bjb@mojatatu.com> --- tools/testing/selftests/tc-testing/tdc_helper.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)