diff mbox series

Remove old kludge in gcc.c

Message ID 1881785.XMnzOWHrYF@polaris
State New
Headers show
Series Remove old kludge in gcc.c | expand

Commit Message

Eric Botcazou Oct. 30, 2017, 10:30 a.m. UTC
Hi,

these lines in gcc.c date back to 2001:

/* By default there is no special suffix for target executables.  */
/* FIXME: when autoconf is fixed, remove the host check - dj */
#if defined(TARGET_EXECUTABLE_SUFFIX) && defined(HOST_EXECUTABLE_SUFFIX)
#define HAVE_TARGET_EXECUTABLE_SUFFIX
#endif

HOST_EXECUTABLE_SUFFIX and TARGET_EXECUTABLE_SUFFIX are defined only for VMS 
and DOS/Windows.  The effect is that ".exe" is forced on executables for these 
targets only if they are built as native and not if they are built as cross.

OK for the mainline?


2017-10-30  Eric Botcazou  <ebotcazou@adacore.com>

	* gcc.c (HAVE_TARGET_EXECUTABLE_SUFFIX): Remove old kludge.

Comments

Jeff Law Oct. 30, 2017, 2:32 p.m. UTC | #1
On 10/30/2017 04:30 AM, Eric Botcazou wrote:
> Hi,
> 
> these lines in gcc.c date back to 2001:
> 
> /* By default there is no special suffix for target executables.  */
> /* FIXME: when autoconf is fixed, remove the host check - dj */
> #if defined(TARGET_EXECUTABLE_SUFFIX) && defined(HOST_EXECUTABLE_SUFFIX)
> #define HAVE_TARGET_EXECUTABLE_SUFFIX
> #endif
> 
> HOST_EXECUTABLE_SUFFIX and TARGET_EXECUTABLE_SUFFIX are defined only for VMS 
> and DOS/Windows.  The effect is that ".exe" is forced on executables for these 
> targets only if they are built as native and not if they are built as cross.
> 
> OK for the mainline?
> 
> 
> 2017-10-30  Eric Botcazou  <ebotcazou@adacore.com>
> 
> 	* gcc.c (HAVE_TARGET_EXECUTABLE_SUFFIX): Remove old kludge.
> 
OK.

Jeff
diff mbox series

Patch

Index: gcc.c
===================================================================
--- gcc.c	(revision 254193)
+++ gcc.c	(working copy)
@@ -170,9 +170,10 @@  env_manager::restore ()
 
 
 /* By default there is no special suffix for target executables.  */
-/* FIXME: when autoconf is fixed, remove the host check - dj */
-#if defined(TARGET_EXECUTABLE_SUFFIX) && defined(HOST_EXECUTABLE_SUFFIX)
+#ifdef TARGET_EXECUTABLE_SUFFIX
 #define HAVE_TARGET_EXECUTABLE_SUFFIX
+#else
+#define TARGET_EXECUTABLE_SUFFIX ""
 #endif
 
 /* By default there is no special suffix for host executables.  */