diff mbox series

[PATCHv2] package/libbsd: not available for ARC

Message ID 20171029170041.13206-1-yann.morin.1998@free.fr
State Accepted
Headers show
Series [PATCHv2] package/libbsd: not available for ARC | expand

Commit Message

Yann E. MORIN Oct. 29, 2017, 5 p.m. UTC
libbsd has explicit, hard-coded checks about the architectures it can
work on, and ARC is not one of those.

We did not notice so far, because we only recently added support for
glibc on ARC (and only for a single variant) in 0633eb58a291 (toolchain:
add glibc support for ARCv2).

Add an explicit exclusion on arc.

Fixes:
    http://autobuild.buildroot.org/results/603baa77e95620ad1416e0d1dc4202c334801efc
    http://autobuild.buildroot.org/results/8a2ee5431501615cb150233e6d7bc9e7c3c5c1eb
    http://autobuild.buildroot.org/results/ea52364f536485ff4e43e3bc37f2175eb6178c5a
    http://autobuild.buildroot.org/results/32581f7a79372b525e4ad21e029ff0ede743ba94

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Evgeniy Didin <Evgeniy.Didin@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
Changes v1 -> v2:
  - fix and simplify dependency !BR2_arc  (Thomas)
  - enhance commit log  (Thomas)
---
 package/libbsd/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni Oct. 29, 2017, 5:16 p.m. UTC | #1
Hello,

On Sun, 29 Oct 2017 18:00:41 +0100, Yann E. MORIN wrote:
> libbsd has explicit, hard-coded checks about the architectures it can
> work on, and ARC is not one of those.
> 
> We did not notice so far, because we only recently added support for
> glibc on ARC (and only for a single variant) in 0633eb58a291 (toolchain:
> add glibc support for ARCv2).
> 
> Add an explicit exclusion on arc.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/603baa77e95620ad1416e0d1dc4202c334801efc
>     http://autobuild.buildroot.org/results/8a2ee5431501615cb150233e6d7bc9e7c3c5c1eb
>     http://autobuild.buildroot.org/results/ea52364f536485ff4e43e3bc37f2175eb6178c5a
>     http://autobuild.buildroot.org/results/32581f7a79372b525e4ad21e029ff0ede743ba94
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Evgeniy Didin <Evgeniy.Didin@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> ---
> Changes v1 -> v2:
>   - fix and simplify dependency !BR2_arc  (Thomas)
>   - enhance commit log  (Thomas)
> ---
>  package/libbsd/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
diff mbox series

Patch

diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in
index 9b5b89812f..11e4c4d974 100644
--- a/package/libbsd/Config.in
+++ b/package/libbsd/Config.in
@@ -1,7 +1,9 @@ 
 config BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
 	bool
-	# libbsd does not support the MicroBlaze ELF machine type (see local-elf.h)
-	default y if !BR2_microblaze
+	default y
+	# libbsd does not support those architectures (see src/local-elf.h)
+	depends on !BR2_microblaze
+	depends on !BR2_arc
 
 config BR2_PACKAGE_LIBBSD
 	bool "libbsd"