Message ID | 7hy3ntq50j.fsf@baylibre.com |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] Amlogic SoC updates for v4.15 | expand |
On Sun, Oct 29, 2017 at 5:43 PM, Kevin Hilman <khilman@baylibre.com> wrote: > ---------------------------------------------------------------- > Amlogic SoC updates for v4.15 > - add SMP support to Meson8/8b Pulled into next/soc. For my understanding, could you clarify what this line is needed for on meson? +textofs-$(CONFIG_ARCH_MESON) := 0x00208000 Thanks, Arnd
[ + Martin ] Arnd Bergmann <arnd@arndb.de> writes: > On Sun, Oct 29, 2017 at 5:43 PM, Kevin Hilman <khilman@baylibre.com> wrote: > >> ---------------------------------------------------------------- >> Amlogic SoC updates for v4.15 >> - add SMP support to Meson8/8b > > Pulled into next/soc. For my understanding, could you clarify what > this line is needed for on meson? > > +textofs-$(CONFIG_ARCH_MESON) := 0x00208000 I belive this is due to the first 2M being reserved for secure memory on some Meson8 SoCs, but maybe Martin can add more clarification if needed. Kevin
Hi Arnd, On Mon, Oct 30, 2017 at 11:26 AM, Arnd Bergmann <arnd@arndb.de> wrote: > On Sun, Oct 29, 2017 at 5:43 PM, Kevin Hilman <khilman@baylibre.com> wrote: > >> ---------------------------------------------------------------- >> Amlogic SoC updates for v4.15 >> - add SMP support to Meson8/8b > > Pulled into next/soc. For my understanding, could you clarify what > this line is needed for on meson? > > +textofs-$(CONFIG_ARCH_MESON) := 0x00208000 this was already part of Carlo's version of the SMP patches. I didn't question this change (I simply assumed that it's relevant - I never questioned "why" it was relevant) so far however, that was until Linus Lüssing (CC'ed) investigated a bug-report from Emiliano Ingrassia (also CC'ed). you can find his results here: [0] (tl;dr: kernel refuses to boot without this change when using a slightly modified multi_v7_defconfig) Linus even asked me to split this change out into a separate patch [1] however, by the time I came back home Kevin already sent out the pull request please let me know if - we can keep the patches the way they are right now - or if you want to separate this change into a separate patch Regards Martin [0] https://lkml.org/lkml/2017/10/28/148 [1] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005155.html
On Mon, Oct 30, 2017 at 10:52 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > Hi Arnd, > > On Mon, Oct 30, 2017 at 11:26 AM, Arnd Bergmann <arnd@arndb.de> wrote: >> On Sun, Oct 29, 2017 at 5:43 PM, Kevin Hilman <khilman@baylibre.com> wrote: >> >>> ---------------------------------------------------------------- >>> Amlogic SoC updates for v4.15 >>> - add SMP support to Meson8/8b >> >> Pulled into next/soc. For my understanding, could you clarify what >> this line is needed for on meson? >> >> +textofs-$(CONFIG_ARCH_MESON) := 0x00208000 > this was already part of Carlo's version of the SMP patches. I didn't > question this change (I simply assumed that it's relevant - I never > questioned "why" it was relevant) so far > however, that was until Linus Lüssing (CC'ed) investigated a > bug-report from Emiliano Ingrassia (also CC'ed). you can find his > results here: [0] > (tl;dr: kernel refuses to boot without this change when using a > slightly modified multi_v7_defconfig) > > Linus even asked me to split this change out into a separate patch [1] > however, by the time I came back home Kevin already sent out the pull request > > please let me know if > - we can keep the patches the way they are right now > - or if you want to separate this change into a separate patch > I think it's good enough to keep it this time, especially now that your explanation is in the mailing list archives. If you get into a similar situation again, splitting up the patch is better though. Arnd