[GIT,PULL] Amlogic SoC updates for v4.15

Message ID 7hy3ntq50j.fsf@baylibre.com
State New
Headers show
Series
  • [GIT,PULL] Amlogic SoC updates for v4.15
Related show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git tags/amlogic-soc

Message

Kevin Hilman Oct. 29, 2017, 4:43 p.m.
The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e:

  Linux 4.14-rc1 (2017-09-16 15:47:51 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git tags/amlogic-soc

for you to fetch changes up to dea54268f3925d05e75b9c6dec487a6515dc0ed5:

  ARM: meson: enable MESON_IRQ_GPIO in Kconfig for meson8b (2017-10-29 08:40:08 -0700)

----------------------------------------------------------------
Amlogic SoC updates for v4.15
- add SMP support to Meson8/8b

----------------------------------------------------------------
Carlo Caione (1):
      dt-bindings: Amlogic: Add Meson8 and Meson8b SMP related documentation

Jerome Brunet (1):
      ARM: meson: enable MESON_IRQ_GPIO in Kconfig for meson8b

Martin Blumenstingl (3):
      ARM: smp_scu: add a helper for powering on a specific CPU
      ARM: smp_scu: allow the platform code to read the SCU CPU status
      ARM: meson: Add SMP bringup code for Meson8 and Meson8b

 Documentation/devicetree/bindings/arm/amlogic/pmu.txt      |  18 ++++
 Documentation/devicetree/bindings/arm/amlogic/smp-sram.txt |  32 +++++++
 Documentation/devicetree/bindings/arm/cpus.txt             |   2 +
 arch/arm/Makefile                                          |   1 +
 arch/arm/include/asm/smp_scu.h                             |  12 +++
 arch/arm/kernel/smp_scu.c                                  |  43 +++++++--
 arch/arm/mach-meson/Kconfig                                |   2 +
 arch/arm/mach-meson/Makefile                               |   1 +
 arch/arm/mach-meson/platsmp.c                              | 440 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 545 insertions(+), 6 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/amlogic/pmu.txt
 create mode 100644 Documentation/devicetree/bindings/arm/amlogic/smp-sram.txt
 create mode 100644 arch/arm/mach-meson/platsmp.c

Comments

Arnd Bergmann Oct. 30, 2017, 10:26 a.m. | #1
On Sun, Oct 29, 2017 at 5:43 PM, Kevin Hilman <khilman@baylibre.com> wrote:

> ----------------------------------------------------------------
> Amlogic SoC updates for v4.15
> - add SMP support to Meson8/8b

Pulled into next/soc. For my understanding, could you clarify what
this line is needed for on meson?

+textofs-$(CONFIG_ARCH_MESON) := 0x00208000

Thanks,

    Arnd
Kevin Hilman Oct. 30, 2017, 11:12 a.m. | #2
[ + Martin ]
Arnd Bergmann <arnd@arndb.de> writes:

> On Sun, Oct 29, 2017 at 5:43 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>
>> ----------------------------------------------------------------
>> Amlogic SoC updates for v4.15
>> - add SMP support to Meson8/8b
>
> Pulled into next/soc. For my understanding, could you clarify what
> this line is needed for on meson?
>
> +textofs-$(CONFIG_ARCH_MESON) := 0x00208000

I belive this is due to the first 2M being reserved for secure memory
on some Meson8 SoCs, but maybe Martin can add more clarification if
needed.

Kevin
Martin Blumenstingl Oct. 30, 2017, 9:52 p.m. | #3
Hi Arnd,

On Mon, Oct 30, 2017 at 11:26 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Sun, Oct 29, 2017 at 5:43 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>
>> ----------------------------------------------------------------
>> Amlogic SoC updates for v4.15
>> - add SMP support to Meson8/8b
>
> Pulled into next/soc. For my understanding, could you clarify what
> this line is needed for on meson?
>
> +textofs-$(CONFIG_ARCH_MESON) := 0x00208000
this was already part of Carlo's version of the SMP patches. I didn't
question this change (I simply assumed that it's relevant - I never
questioned "why" it was relevant) so far
however, that was until Linus Lüssing (CC'ed) investigated a
bug-report from Emiliano Ingrassia (also CC'ed). you can find his
results here: [0]
(tl;dr: kernel refuses to boot without this change when using a
slightly modified multi_v7_defconfig)

Linus even asked me to split this change out into a separate patch [1]
however, by the time I came back home Kevin already sent out the pull request

please let me know if
- we can keep the patches the way they are right now
- or if you want to separate this change into a separate patch


Regards
Martin


[0] https://lkml.org/lkml/2017/10/28/148
[1] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005155.html
Arnd Bergmann Nov. 2, 2017, 3:49 p.m. | #4
On Mon, Oct 30, 2017 at 10:52 PM, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
> Hi Arnd,
>
> On Mon, Oct 30, 2017 at 11:26 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Sun, Oct 29, 2017 at 5:43 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>>
>>> ----------------------------------------------------------------
>>> Amlogic SoC updates for v4.15
>>> - add SMP support to Meson8/8b
>>
>> Pulled into next/soc. For my understanding, could you clarify what
>> this line is needed for on meson?
>>
>> +textofs-$(CONFIG_ARCH_MESON) := 0x00208000
> this was already part of Carlo's version of the SMP patches. I didn't
> question this change (I simply assumed that it's relevant - I never
> questioned "why" it was relevant) so far
> however, that was until Linus Lüssing (CC'ed) investigated a
> bug-report from Emiliano Ingrassia (also CC'ed). you can find his
> results here: [0]
> (tl;dr: kernel refuses to boot without this change when using a
> slightly modified multi_v7_defconfig)
>
> Linus even asked me to split this change out into a separate patch [1]
> however, by the time I came back home Kevin already sent out the pull request
>
> please let me know if
> - we can keep the patches the way they are right now
> - or if you want to separate this change into a separate patch
>

I think it's good enough to keep it this time, especially now that your
explanation is in the mailing list archives. If you get into a similar
situation again, splitting up the patch is better though.

     Arnd