| Message ID | 20171029161256.18607-2-bernd.kuhls@t-online.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v5,1/2] boinc: new package | expand |
Hello, On Sun, Oct 29, 2017 at 02:12 PM, Bernd Kuhls wrote: > No configure option present: > https://github.com/BOINC/boinc/blob/master/configure.ac#L497 A nit related to the url: when the master branch changes (drastic examples: 100 lines are removed from the file, or even a configure option is added for freetype) this url would point to a wrong location. A more future-proof url would be https://github.com/BOINC/boinc/blob/client_release/7.8/7.8.3/configure.ac#L497 as we trust they won't change a tag. Of course there is the super-safe url: https://github.com/BOINC/boinc/blob/efcd3928571992b30144db84b43af7470d8b2d6a/configure.ac#L497 Regards, Ricardo
Hello, On Sun, 29 Oct 2017 14:47:24 -0200, Ricardo Martincoski wrote: > A nit related to the url: when the master branch changes (drastic > examples: 100 lines are removed from the file, or even a configure > option is added for freetype) this url would point to a wrong location. > > A more future-proof url would be > https://github.com/BOINC/boinc/blob/client_release/7.8/7.8.3/configure.ac#L497 > as we trust they won't change a tag. Good point, I have used this URL when reworking Bernd's commit log. Thanks! Thomas
diff --git a/package/boinc/boinc.mk b/package/boinc/boinc.mk index 01fa66ac91..901f1ee986 100644 --- a/package/boinc/boinc.mk +++ b/package/boinc/boinc.mk @@ -26,6 +26,10 @@ BOINC_CONF_OPTS = \ --with-pkg-config=$(PKG_CONFIG_HOST_BINARY) \ --with-libcurl=$(STAGING_DIR)/usr +ifeq ($(BR2_PACKAGE_FREETYPE),y) +BOINC_DEPENDENCIES += freetype +endif + ifeq ($(BR2_PACKAGE_LIBFCGI),y) BOINC_DEPENDENCIES += libfcgi BOINC_CONF_OPTS += --enable-fcgi
No configure option present: https://github.com/BOINC/boinc/blob/master/configure.ac#L497 Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/boinc/boinc.mk | 4 ++++ 1 file changed, 4 insertions(+)