| Message ID | 9da18c4fbcb55130164735352b5ce9ba11b9a63c.1509270992.git.sathyanarayanan.kuppuswamy@linux.intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Cyrille Pitchen |
| Headers | show |
| Series | [v1,1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller | expand |
On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller. > > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Culling the CC list and adding relevant people. Patch looks IMO OK, but I'd like RB from Mika. > --- > drivers/mtd/spi-nor/intel-spi-pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c > index e826523..048c007 100644 > --- a/drivers/mtd/spi-nor/intel-spi-pci.c > +++ b/drivers/mtd/spi-nor/intel-spi-pci.c > @@ -64,6 +64,8 @@ static void intel_spi_pci_remove(struct pci_dev *pdev) > > static const struct pci_device_id intel_spi_pci_ids[] = { > { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info }, > + { PCI_VDEVICE(INTEL, 0xa1a4), (unsigned long)&bxt_info }, > + { PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info }, > { }, > }; > MODULE_DEVICE_TABLE(pci, intel_spi_pci_ids); >
On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote: > On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > > > This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller. > > > > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > Culling the CC list and adding relevant people. > Patch looks IMO OK, but I'd like RB from Mika. There is already a patch for Lewisburg queued for v4.15 here: http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e
On 10/29/2017 11:16 AM, Mika Westerberg wrote: > On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote: >> On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote: >>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >>> >>> This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller. >>> >>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> >> Culling the CC list and adding relevant people. >> Patch looks IMO OK, but I'd like RB from Mika. > > There is already a patch for Lewisburg queued for v4.15 here: > > http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e Heh, even better. Why does this patch add another ID ?
Hi Mika, On 10/29/2017 3:16 AM, Mika Westerberg wrote: > On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote: >> On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote: >>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >>> >>> This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller. >>> >>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> Culling the CC list and adding relevant people. >> Patch looks IMO OK, but I'd like RB from Mika. > There is already a patch for Lewisburg queued for v4.15 here: > > http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e Sorry, I did not know that we already have patch submitted for spi-nor support. So please ignore this patch. - Sathyanarayanan KN
Hi, On 10/29/2017 3:34 AM, Marek Vasut wrote: > On 10/29/2017 11:16 AM, Mika Westerberg wrote: >> On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote: >>> On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote: >>>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >>>> >>>> This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller. >>>> >>>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >>> Culling the CC list and adding relevant people. >>> Patch looks IMO OK, but I'd like RB from Mika. >> There is already a patch for Lewisburg queued for v4.15 here: >> >> http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e > Heh, even better. Why does this patch add another ID ? 0xA1A4 - its for production SKUs. 0xA224 - Its for super SKUs Mika, Shall I re-base this patch to add super SKU ID?
On Sun, Oct 29, 2017 at 12:18:28PM -0700, Kuppuswamy, Sathyanarayanan wrote:
> Mika, Shall I re-base this patch to add super SKU ID?
Yes, please.
diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c index e826523..048c007 100644 --- a/drivers/mtd/spi-nor/intel-spi-pci.c +++ b/drivers/mtd/spi-nor/intel-spi-pci.c @@ -64,6 +64,8 @@ static void intel_spi_pci_remove(struct pci_dev *pdev) static const struct pci_device_id intel_spi_pci_ids[] = { { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info }, + { PCI_VDEVICE(INTEL, 0xa1a4), (unsigned long)&bxt_info }, + { PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info }, { }, }; MODULE_DEVICE_TABLE(pci, intel_spi_pci_ids);