From patchwork Mon Feb 14 16:59:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 83140 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1D7A0B711C for ; Tue, 15 Feb 2011 04:09:43 +1100 (EST) Received: from localhost ([127.0.0.1]:36536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp1ve-0007Hd-Ny for incoming@patchwork.ozlabs.org; Mon, 14 Feb 2011 12:09:38 -0500 Received: from [140.186.70.92] (port=33677 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp1ob-000450-Me for qemu-devel@nongnu.org; Mon, 14 Feb 2011 12:02:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pp1oa-0007J2-Nh for qemu-devel@nongnu.org; Mon, 14 Feb 2011 12:02:21 -0500 Received: from mail-fx0-f45.google.com ([209.85.161.45]:57920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pp1oa-0007Ik-GJ for qemu-devel@nongnu.org; Mon, 14 Feb 2011 12:02:20 -0500 Received: by fxm12 with SMTP id 12so5580015fxm.4 for ; Mon, 14 Feb 2011 09:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=uTFFRbTIr0X56hV9H4QgLdZY8lYXExoceeCplfWZq5k=; b=tgJIrSbcvY/2GxF+hOyPU7P+4gNRXz4KEZBXUxEhoAt7A8apTESOAOCh9fjaIN28SW K9ZD831h+nrmO7C5nW7b1BRB7cgLFlb5GbccFVZNY064cBEF7iTb57fH3pznLkhBsx84 yTNQoSQTg+mUCvWYbZ9pf95i12N79EF4wCQ/k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=hNJvFXMmifxcL3Au12CO13t0T/KuqTvMJ1LrhpENPr8l/O2p9l9rHkdcB0+Jxj7Agy vw8Ymqt7AaRi0PJnZJFG7FuKWqcyuVKnMh+ofQJ8tk1L/tBuP5sdMDqWvVyoq+12YjMD yaATPNH7QoBcZ/jldKGuw+nq4NvViaG3giTyw= Received: by 10.223.79.79 with SMTP id o15mr2219054fak.30.1297702771543; Mon, 14 Feb 2011 08:59:31 -0800 (PST) Received: from localhost.localdomain ([86.57.155.118]) by mx.google.com with ESMTPS id 5sm1169469fak.23.2011.02.14.08.59.25 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Feb 2011 08:59:25 -0800 (PST) From: Vasily Khoruzhick To: "qemu-devel@nongnu.org" Date: Mon, 14 Feb 2011 18:59:10 +0200 Message-Id: <1297702750-32203-1-git-send-email-anarsoul@gmail.com> X-Mailer: git-send-email 1.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.45 Cc: Vasily Khoruzhick Subject: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org RST bit is (1 << 3) bit, not (1 << 2), fix condition that enables i2s if ENB is set and RST is not set. Signed-off-by: Vasily Khoruzhick --- hw/pxa2xx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index d966846..68b67ae 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -1631,7 +1631,7 @@ static void pxa2xx_i2s_write(void *opaque, target_phys_addr_t addr, } if (value & (1 << 4)) /* EFWR */ printf("%s: Attempt to use special function\n", __FUNCTION__); - s->enable = ((value ^ 4) & 5) == 5; /* ENB && !RST*/ + s->enable = ((value ^ (1 << 3)) & 9) == 9; /* ENB && !RST*/ pxa2xx_i2s_update(s); break; case SACR1: