diff mbox series

[U-Boot,2/2] tools: image: fix message when fail to add verification data for config

Message ID 1509084261-16126-2-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 76b9cbab25f832a25e51c50a221c0f1ff3632b7c
Delegated to: Tom Rini
Headers show
Series [U-Boot,1/2] tools: image: allow to sign image nodes without -K option | expand

Commit Message

Masahiro Yamada Oct. 27, 2017, 6:04 a.m. UTC
This function is called when signing configuration nodes.  Adjust
the error message.

I do not know why we do not need to show the error message in case of
ENOSPC.  Remove the if-conditional that seems unnecessary.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 tools/image-host.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Tom Rini Nov. 6, 2017, 11:28 p.m. UTC | #1
On Fri, Oct 27, 2017 at 03:04:21PM +0900, Masahiro Yamada wrote:

> This function is called when signing configuration nodes.  Adjust
> the error message.
> 
> I do not know why we do not need to show the error message in case of
> ENOSPC.  Remove the if-conditional that seems unnecessary.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/tools/image-host.c b/tools/image-host.c
index d42c1ca..2c0030b 100644
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -626,10 +626,8 @@  static int fit_config_process_sig(const char *keydir, void *keydest,
 	/* Write the public key into the supplied FDT file */
 	if (keydest) {
 		ret = info.crypto->add_verify_data(&info, keydest);
-		if (ret == -ENOSPC)
-			return -ENOSPC;
 		if (ret) {
-			printf("Failed to add verification data for '%s' signature node in '%s' image node\n",
+			printf("Failed to add verification data for '%s' signature node in '%s' configuration node\n",
 			       node_name, conf_name);
 		}
 		return ret;