Patchwork Build crc32c-intel in the kernel

login
register
mail settings
Submitter Loïc Minier
Date Feb. 14, 2011, 11:11 a.m.
Message ID <1297681887-16150-1-git-send-email-loic.minier@linaro.org>
Download mbox | patch
Permalink /patch/83076/
State Accepted
Headers show

Comments

Loïc Minier - Feb. 14, 2011, 11:11 a.m.
Apparently crc32c-intel wont ever be autoloaded if crc32c already is;
since crc32c is built into the kernel for various reasons, it's best to
build crc32c-intel as well; see LP #715835 for some related discussion.

Signed-off-by: Loïc Minier <loic.minier@linaro.org>
---
 debian.master/config/config.common.ubuntu |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Tim Gardner - Feb. 14, 2011, 3:55 p.m.
On 02/14/2011 04:11 AM, Loïc Minier wrote:
> Apparently crc32c-intel wont ever be autoloaded if crc32c already is;
> since crc32c is built into the kernel for various reasons, it's best to
> build crc32c-intel as well; see LP #715835 for some related discussion.
>
> Signed-off-by: Loïc Minier<loic.minier@linaro.org>
> ---
>   debian.master/config/config.common.ubuntu |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index ecd94ab..fb35a5a 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -978,7 +978,7 @@ CONFIG_CRYPTO_CAST5=m
>   CONFIG_CRYPTO_CAST6=m
>   CONFIG_CRYPTO_CBC=y
>   CONFIG_CRYPTO_CRC32C=y
> -CONFIG_CRYPTO_CRC32C_INTEL=m
> +CONFIG_CRYPTO_CRC32C_INTEL=y
>   CONFIG_CRYPTO_CRYPTD=m
>   CONFIG_CRYPTO_CTS=m
>   CONFIG_CRYPTO_DEFLATE=m

Loic - I already did this patch on Feb 10, "UBUNTU: [Config] 
CONFIG_CRYPTO_CRC32C_INTEL=y". Perhaps I was too cryptic :)

https://lists.ubuntu.com/archives/kernel-team/2011-February/014462.html

rtg
Loïc Minier - Feb. 14, 2011, 6:29 p.m.
On Mon, Feb 14, 2011, Tim Gardner wrote:
> Loic - I already did this patch on Feb 10, "UBUNTU: [Config]
> CONFIG_CRYPTO_CRC32C_INTEL=y". Perhaps I was too cryptic :)
> https://lists.ubuntu.com/archives/kernel-team/2011-February/014462.html

 Ah, I was expecting a patch to go in from your reply to the thread, but
 I didn't see one in master, which is why I sent one.  Now that I look
 closely, I see a new master-next branch in ubuntu-natty.git, which is
 why I didn't spot it.

   Thanks!

PS: is there a place I can read up on the master-next branch, how to use
it properly etc.?
Tim Gardner - Feb. 14, 2011, 7:30 p.m.
On 02/14/2011 11:29 AM, Loïc Minier wrote:
> On Mon, Feb 14, 2011, Tim Gardner wrote:
>> Loic - I already did this patch on Feb 10, "UBUNTU: [Config]
>> CONFIG_CRYPTO_CRC32C_INTEL=y". Perhaps I was too cryptic :)
>> https://lists.ubuntu.com/archives/kernel-team/2011-February/014462.html
>
>   Ah, I was expecting a patch to go in from your reply to the thread, but
>   I didn't see one in master, which is why I sent one.  Now that I look
>   closely, I see a new master-next branch in ubuntu-natty.git, which is
>   why I didn't spot it.
>
>     Thanks!
>
> PS: is there a place I can read up on the master-next branch, how to use
> it properly etc.?

Not sure if anything is in the wiki yet. master-next is intended to be 
used as a development branch whilst master is undergoing testing in the 
2 week cadence. We'll take patches against either branch.

rtg

Patch

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index ecd94ab..fb35a5a 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -978,7 +978,7 @@  CONFIG_CRYPTO_CAST5=m
 CONFIG_CRYPTO_CAST6=m
 CONFIG_CRYPTO_CBC=y
 CONFIG_CRYPTO_CRC32C=y
-CONFIG_CRYPTO_CRC32C_INTEL=m
+CONFIG_CRYPTO_CRC32C_INTEL=y
 CONFIG_CRYPTO_CRYPTD=m
 CONFIG_CRYPTO_CTS=m
 CONFIG_CRYPTO_DEFLATE=m