[v2,07/13] pkg-generic: add a subdirectory to the DL_DIR

Message ID	20171025201003.16105-8-ps.report@gmx.net
State	Superseded
Headers	show Return-Path: <buildroot-bounces@busybox.net> From: Peter Seiderer <ps.report@gmx.net> To: buildroot@buildroot.org Date: Wed, 25 Oct 2017 22:09:57 +0200 Message-Id: <20171025201003.16105-8-ps.report@gmx.net> In-Reply-To: <20171025201003.16105-1-ps.report@gmx.net> References: <20171025201003.16105-1-ps.report@gmx.net> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> Subject: [Buildroot] [PATCH v2 07/13] pkg-generic: add a subdirectory to the DL_DIR Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net>
Series	New DL_DIR organisation; git cache feature \| expand [v2,00/13] New DL_DIR organisation; git cache feature [v2,01/13] pkg-{download, generic}: remove source-check [v2,02/13] core/pkg-download: change all helpers to use common options [v2,03/13] download: put most of the infra in dl-wrapper [v2,04/13] packages: use new $($PKG)_DL_DIR) variable [v2,05/13] pkg-{download, generic}: use new $($(PKG)_DL_DIR) [v2,06/13] support/download: make sure the download folder is created [v2,07/13] pkg-generic: add a subdirectory to the DL_DIR [v2,08/13] pkg-download: support new subdir for mirrors [v2,09/13] pkg-generic: introduce _SAME_SOURCE_AS [v2,10/13] help/manual: update help about the new $(LIBFOO_DL_DIR) [v2,11/13] download: add flock call before dl-wrapper [v2,12/13] download: git: introduce cache feature [v2,13/13] WIP: support package with '-'

Message ID

20171025201003.16105-8-ps.report@gmx.net

State

Superseded

Headers

From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@buildroot.org
Date: Wed, 25 Oct 2017 22:09:57 +0200
Message-Id: <20171025201003.16105-8-ps.report@gmx.net>
In-Reply-To: <20171025201003.16105-1-ps.report@gmx.net>
References: <20171025201003.16105-1-ps.report@gmx.net>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Subject: [Buildroot] [PATCH v2 07/13] pkg-generic: add a subdirectory to the
	DL_DIR
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: buildroot-bounces@busybox.net
Sender: "buildroot" <buildroot-bounces@busybox.net>

Series

New DL_DIR organisation; git cache feature | expand

Commit Message

Peter Seiderer Oct. 25, 2017, 8:09 p.m. UTC

From: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

With all the previous changes, we are now ready to add a subdirectory to
the DL_DIR.
The structure will now be DL_DIR/PKG_NAME/{FILE1,FILE2}

This is needed for multiple reasons:
    - Avoid patches with name like SHA1.patch laying flat in DL_DIR,
    which makes it hard to know to which packages they apply
    - Avoid possible collisions if two releases have the same name
    (e.g: v01.tar)
    - Allow the possibility to handle a git cache per package in the
    newly created subdirectory.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
Changes v1 --> v2:
  - from https://github.com/maximeh/buildroot/commit/a53df6631be6d9fa43d8fd7fdb2f8b2903459334.patch
---
 package/pkg-generic.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 676625e0a6..d07ea0f885 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -441,7 +441,7 @@  endif
 
 $(2)_BASE_NAME	= $$(if $$($(2)_VERSION),$(1)-$$($(2)_VERSION),$(1))
 $(2)_RAW_BASE_NAME = $$(if $$($(2)_VERSION),$$($(2)_RAWNAME)-$$($(2)_VERSION),$$($(2)_RAWNAME))
-$(2)_DL_DIR	=  $$(DL_DIR)
+$(2)_DL_DIR 	=  $$(DL_DIR)/$$($(2)_RAWNAME)
 $(2)_DIR	=  $$(BUILD_DIR)/$$($(2)_BASE_NAME)
 
 ifndef $(2)_SUBDIR

[v2,07/13] pkg-generic: add a subdirectory to the DL_DIR

Commit Message

Patch