diff mbox series

rds: Fix uninitialized variable

Message ID 20171024160719.17726-1-Haakon.Bugge@oracle.com
State Superseded, archived
Delegated to: David Miller
Headers show
Series rds: Fix uninitialized variable | expand

Commit Message

Haakon Bugge Oct. 24, 2017, 4:07 p.m. UTC
send_flags needs to be initialized before calling
rds_ib_set_wr_signal_state().

Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
---
 net/rds/ib_send.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Haakon Bugge Oct. 24, 2017, 4:16 p.m. UTC | #1
Ignore this, sent the old one.

Håkon

> On 24 Oct 2017, at 18:07, Håkon Bugge <Haakon.Bugge@oracle.com> wrote:
> 
> send_flags needs to be initialized before calling
> rds_ib_set_wr_signal_state().
> 
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> ---
> net/rds/ib_send.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
> index 6ab39db..8f46755 100644
> --- a/net/rds/ib_send.c
> +++ b/net/rds/ib_send.c
> @@ -792,6 +792,7 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
> 		send->s_atomic_wr.compare_add_mask = op->op_m_fadd.nocarry_mask;
> 		send->s_atomic_wr.swap_mask = 0;
> 	}
> +	send->s_wr.send_flags = 0;
> 	nr_sig = rds_ib_set_wr_signal_state(ic, send, op->op_notify);
> 	send->s_atomic_wr.wr.num_sge = 1;
> 	send->s_atomic_wr.wr.next = NULL;
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index 6ab39db..8f46755 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -792,6 +792,7 @@  int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
 		send->s_atomic_wr.compare_add_mask = op->op_m_fadd.nocarry_mask;
 		send->s_atomic_wr.swap_mask = 0;
 	}
+	send->s_wr.send_flags = 0;
 	nr_sig = rds_ib_set_wr_signal_state(ic, send, op->op_notify);
 	send->s_atomic_wr.wr.num_sge = 1;
 	send->s_atomic_wr.wr.next = NULL;