mbox series

pull request (net): ipsec 2017-10-24

Message ID 1508841460-26369-1-git-send-email-steffen.klassert@secunet.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series pull request (net): ipsec 2017-10-24 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git master

Message

Steffen Klassert Oct. 24, 2017, 10:37 a.m. UTC
1) Fix a memleak when we don't find a inner_mode
   during bundle creation. From David Miller.

2) Fix a xfrm policy dump crash. We may crash
   on error when dumping policies via netlink.
   Fix this by initializing the policy walk
   with the cb->start method. This fix is a
   serious stable candidate. From Herbert Xu.

Please pull or let me know if there are problems.

Thanks!

The following changes since commit c0576e3975084d4699b7bfef578613fb8e1144f6:

  net: call cgroup_sk_alloc() earlier in sk_clone_lock() (2017-10-10 20:24:29 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git master

for you to fetch changes up to 1137b5e2529a8f5ca8ee709288ecba3e68044df2:

  ipsec: Fix aborted xfrm policy dump crash (2017-10-23 09:35:48 +0200)

----------------------------------------------------------------
David Miller (1):
      ipsec: Fix dst leak in xfrm_bundle_create().

Herbert Xu (1):
      ipsec: Fix aborted xfrm policy dump crash

 net/xfrm/xfrm_policy.c | 16 ++++++++--------
 net/xfrm/xfrm_user.c   | 25 +++++++++++++++----------
 2 files changed, 23 insertions(+), 18 deletions(-)

Comments

David Miller Oct. 24, 2017, 11:18 a.m. UTC | #1
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Tue, 24 Oct 2017 12:37:38 +0200

> 1) Fix a memleak when we don't find a inner_mode
>    during bundle creation. From David Miller.
> 
> 2) Fix a xfrm policy dump crash. We may crash
>    on error when dumping policies via netlink.
>    Fix this by initializing the policy walk
>    with the cb->start method. This fix is a
>    serious stable candidate. From Herbert Xu.
> 
> Please pull or let me know if there are problems.

Pulled, please submit #2 to -stable indeed!
Steffen Klassert Oct. 24, 2017, 11:35 a.m. UTC | #2
On Tue, Oct 24, 2017 at 08:18:32PM +0900, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@secunet.com>
> Date: Tue, 24 Oct 2017 12:37:38 +0200
> 
> > 1) Fix a memleak when we don't find a inner_mode
> >    during bundle creation. From David Miller.
> > 
> > 2) Fix a xfrm policy dump crash. We may crash
> >    on error when dumping policies via netlink.
> >    Fix this by initializing the policy walk
> >    with the cb->start method. This fix is a
> >    serious stable candidate. From Herbert Xu.
> > 
> > Please pull or let me know if there are problems.
> 
> Pulled, please submit #2 to -stable indeed!

I can do so, but whenever I sent something networking related
to -stable, it was ignored. I think this is because Greg expects
that you do the stable submissions for networking.
David Miller Oct. 24, 2017, 11:42 a.m. UTC | #3
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Tue, 24 Oct 2017 13:35:25 +0200

> On Tue, Oct 24, 2017 at 08:18:32PM +0900, David Miller wrote:
>> From: Steffen Klassert <steffen.klassert@secunet.com>
>> Date: Tue, 24 Oct 2017 12:37:38 +0200
>> 
>> > 1) Fix a memleak when we don't find a inner_mode
>> >    during bundle creation. From David Miller.
>> > 
>> > 2) Fix a xfrm policy dump crash. We may crash
>> >    on error when dumping policies via netlink.
>> >    Fix this by initializing the policy walk
>> >    with the cb->start method. This fix is a
>> >    serious stable candidate. From Herbert Xu.
>> > 
>> > Please pull or let me know if there are problems.
>> 
>> Pulled, please submit #2 to -stable indeed!
> 
> I can do so, but whenever I sent something networking related
> to -stable, it was ignored. I think this is because Greg expects
> that you do the stable submissions for networking.

Send it, CC: me, and I'll reply making sure Greg knows.

Thanks.