diff mbox series

[jkirsher/net-queue] i40e: Add programming descriptors to cleaned_count

Message ID 20171022011222.12997.53593.stgit@localhost.localdomain
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show
Series [jkirsher/net-queue] i40e: Add programming descriptors to cleaned_count | expand

Commit Message

Alexander H Duyck Oct. 22, 2017, 1:12 a.m. UTC 
From: Alexander Duyck <alexander.h.duyck@intel.com>

This patch updates the i40e driver to include programming descriptors in
the cleaned_count. Without this change it becomes possible for us to leak
memory as we don't trigger a large enough allocation when the time comes to
allocate new buffers and we end up overwriting a number of rx_buffers equal
to the number of programming descriptors we encountered.

Fixes: 0e626ff7ccbf ("i40e: Fix support for flow director programming status")
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Anders K. Pedersen | Cohaesio Oct. 22, 2017, 6:01 p.m. UTC | #1 
On lør, 2017-10-21 at 18:12 -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>

> 

> This patch updates the i40e driver to include programming descriptors

> in

> the cleaned_count. Without this change it becomes possible for us to

> leak

> memory as we don't trigger a large enough allocation when the time

> comes to

> allocate new buffers and we end up overwriting a number of rx_buffers

> equal

> to the number of programming descriptors we encountered.

> 

> Fixes: 0e626ff7ccbf ("i40e: Fix support for flow director programming

> status")

> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>


This patch solves the remaining memory leak we've seen, so

Tested-by: Anders K. Pedersen <akp@cohaesio.com>


Regards,
Anders
Paweł Staszewski Oct. 22, 2017, 11:15 p.m. UTC | #2 
Yes can confirm that after adding patch:

[jkirsher/net-queue PATCH] i40e: Add programming descriptors to 
cleaned_count


There is no memleak.



W dniu 2017-10-22 o 20:01, Anders K. Pedersen | Cohaesio pisze:
> On lør, 2017-10-21 at 18:12 -0700, Alexander Duyck wrote:
>> From: Alexander Duyck <alexander.h.duyck@intel.com>
>>
>> This patch updates the i40e driver to include programming descriptors
>> in
>> the cleaned_count. Without this change it becomes possible for us to
>> leak
>> memory as we don't trigger a large enough allocation when the time
>> comes to
>> allocate new buffers and we end up overwriting a number of rx_buffers
>> equal
>> to the number of programming descriptors we encountered.
>>
>> Fixes: 0e626ff7ccbf ("i40e: Fix support for flow director programming
>> status")
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> This patch solves the remaining memory leak we've seen, so
>
> Tested-by: Anders K. Pedersen <akp@cohaesio.com>
>
> Regards,
> Anders
Pavlos Parissis Oct. 27, 2017, 9:20 p.m. UTC | #3 
On 23 October 2017 at 01:15, Paweł Staszewski <pstaszewski@itcare.pl> wrote:
> Yes can confirm that after adding patch:
>
> [jkirsher/net-queue PATCH] i40e: Add programming descriptors to
> cleaned_count
>
>
> There is no memleak.
>
>

Somehow this patch isn't present in the current net-next repo.
Shouldn't it be there?

Cheers,
Pavlos
Paweł Staszewski Oct. 27, 2017, 10:21 p.m. UTC | #4 
from today it is in net.git

https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/log/?qt=grep&q=i40e

It will be later in net-next


Also can You please tell me what firmware You are using with Your nics ?

Those are X710 ?


Thanks

Paweł



W dniu 2017-10-27 o 23:20, Pavlos Parissis pisze:
> On 23 October 2017 at 01:15, Paweł Staszewski <pstaszewski@itcare.pl> wrote:
>> Yes can confirm that after adding patch:
>>
>> [jkirsher/net-queue PATCH] i40e: Add programming descriptors to
>> cleaned_count
>>
>>
>> There is no memleak.
>>
>>
> Somehow this patch isn't present in the current net-next repo.
> Shouldn't it be there?
>
> Cheers,
> Pavlos
>
Pavlos Parissis Oct. 27, 2017, 10:58 p.m. UTC | #5 
On 28 October 2017 at 00:21, Paweł Staszewski <pstaszewski@itcare.pl> wrote:
> from today it is in net.git
>
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/log/?qt=grep&q=i40e
>
> It will be later in net-next
>
>

I have to admit I am not that familiar with repo layout, I though
net-next holds what is going to be pushed to Linus's repo and
potentially some parts to linux-stable.

> Also can You please tell me what firmware You are using with Your nics ?
>

1.1752.0., but we use the firmware version that comes from HP, as we
use HP servers, see details here
https://communities.intel.com/message/501682#501682

> Those are X710 ?

Correct.

Cheers,
Pavlos
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 368722defacb..d6d352a6e6ea 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -2102,6 +2102,7 @@  static int i40e_clean_rx_irq(struct i40e_ring *rx_ring, int budget)
 
 		if (unlikely(i40e_rx_is_programming_status(qword))) {
 			i40e_clean_programming_status(rx_ring, rx_desc, qword);
+			cleaned_count++;
 			continue;
 		}
 		size = (qword & I40E_RXD_QW1_LENGTH_PBUF_MASK) >>