[ovs-dev,v2] rhel.rst: Add python-sphinx as a dependency.
diff mbox series

Message ID 1508491645-21387-1-git-send-email-guru@ovn.org
State Accepted
Headers show
Series
  • [ovs-dev,v2] rhel.rst: Add python-sphinx as a dependency.
Related show

Commit Message

Gurucharan Shetty Oct. 20, 2017, 9:27 a.m. UTC
Signed-off-by: Gurucharan Shetty <guru@ovn.org>
---
 Documentation/intro/install/rhel.rst | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Yi-Hung Wei Oct. 20, 2017, 8:12 p.m. UTC | #1
Thanks for the patch. LGTM.

Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>

BTW, I think we can also update the docs in fedora.rst. as the following.

--- a/Documentation/intro/install/fedora.rst
+++ b/Documentation/intro/install/fedora.rst
@@ -43,7 +43,7 @@ in the :doc:`general`. Specific packages (by package
name) include:
 - autoconf automake libtool
 - systemd-units openssl openssl-devel
 - python2-devel python3-devel
-- python2 python2-twisted python2-zope-interface python2-six
+- python2 python2-twisted python2-zope-interface python2-six python-sphinx
 - desktop-file-utils
 - groff graphviz
 - procps-ng

On Fri, Oct 20, 2017 at 2:27 AM, Gurucharan Shetty <guru@ovn.org> wrote:
> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> ---
>  Documentation/intro/install/rhel.rst | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
> index 86c5cf3..b68cb7d 100644
> --- a/Documentation/intro/install/rhel.rst
> +++ b/Documentation/intro/install/rhel.rst
> @@ -76,7 +76,11 @@ the below command::
>
>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
> -        libtool checkpolicy selinux-policy-devel
> +        libtool checkpolicy selinux-policy-devel python-sphinx
> +
> +.. note::
> +  If python-sphinx package is not available in RHEL, you can install it
> +  via pip with 'pip install sphinx'.
>
>  .. _rhel-bootstrapping:
>
> --
> 1.9.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Aaron Conole Oct. 20, 2017, 8:14 p.m. UTC | #2
Gurucharan Shetty <guru@ovn.org> writes:

> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

.. but possible minor nit (feel free to take or ignore):

> +.. note::
> +  If python-sphinx package is not available in RHEL, you can install it

s/RHEL/your version of RHEL/

> +  via pip with 'pip install sphinx'.
Gurucharan Shetty Oct. 20, 2017, 8:20 p.m. UTC | #3
Thanks you Yi-Hung and Aaron. I applied this with your suggestions.

On 20 October 2017 at 13:12, Yi-Hung Wei <yihung.wei@gmail.com> wrote:

> Thanks for the patch. LGTM.
>
> Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
>
> BTW, I think we can also update the docs in fedora.rst. as the following.
>
> --- a/Documentation/intro/install/fedora.rst
> +++ b/Documentation/intro/install/fedora.rst
> @@ -43,7 +43,7 @@ in the :doc:`general`. Specific packages (by package
> name) include:
>  - autoconf automake libtool
>  - systemd-units openssl openssl-devel
>  - python2-devel python3-devel
> -- python2 python2-twisted python2-zope-interface python2-six
> +- python2 python2-twisted python2-zope-interface python2-six python-sphinx
>  - desktop-file-utils
>  - groff graphviz
>  - procps-ng
>
> On Fri, Oct 20, 2017 at 2:27 AM, Gurucharan Shetty <guru@ovn.org> wrote:
> > Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> > ---
> >  Documentation/intro/install/rhel.rst | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/intro/install/rhel.rst
> b/Documentation/intro/install/rhel.rst
> > index 86c5cf3..b68cb7d 100644
> > --- a/Documentation/intro/install/rhel.rst
> > +++ b/Documentation/intro/install/rhel.rst
> > @@ -76,7 +76,11 @@ the below command::
> >
> >      $ yum install gcc make python-devel openssl-devel kernel-devel
> graphviz \
> >          kernel-debug-devel autoconf automake rpm-build
> redhat-rpm-config \
> > -        libtool checkpolicy selinux-policy-devel
> > +        libtool checkpolicy selinux-policy-devel python-sphinx
> > +
> > +.. note::
> > +  If python-sphinx package is not available in RHEL, you can install it
> > +  via pip with 'pip install sphinx'.
> >
> >  .. _rhel-bootstrapping:
> >
> > --
> > 1.9.1
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

Patch
diff mbox series

diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
index 86c5cf3..b68cb7d 100644
--- a/Documentation/intro/install/rhel.rst
+++ b/Documentation/intro/install/rhel.rst
@@ -76,7 +76,11 @@  the below command::
 
     $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
         kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
-        libtool checkpolicy selinux-policy-devel
+        libtool checkpolicy selinux-policy-devel python-sphinx
+
+.. note::
+  If python-sphinx package is not available in RHEL, you can install it
+  via pip with 'pip install sphinx'.
 
 .. _rhel-bootstrapping: