[ovs-dev] rhel.rst: Add python-sphinx as a dependency.
diff mbox series

Message ID 1508485150-7188-1-git-send-email-guru@ovn.org
State Superseded
Headers show
Series
  • [ovs-dev] rhel.rst: Add python-sphinx as a dependency.
Related show

Commit Message

Gurucharan Shetty Oct. 20, 2017, 7:39 a.m. UTC
Signed-off-by: Gurucharan Shetty <guru@ovn.org>
---
 Documentation/intro/install/rhel.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff Oct. 24, 2017, 9:38 p.m. UTC | #1
On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> ---
>  Documentation/intro/install/rhel.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
> index 86c5cf3..aff6ccf 100644
> --- a/Documentation/intro/install/rhel.rst
> +++ b/Documentation/intro/install/rhel.rst
> @@ -76,7 +76,7 @@ the below command::
>  
>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
> -        libtool checkpolicy selinux-policy-devel
> +        libtool checkpolicy selinux-policy-devel python-sphinx

For Debian, we just recommend installing the build-dependencies listed
in debian/control.  That has the advantage that it can't get out of
date.  It has the disadvantage, though, that it's not easy to cut and
paste (although "apt-get build-dep openvswitch" usually does the trick).
Maybe "yum" has some mode that installs dependencies from a spec file?
Aaron Conole Oct. 31, 2017, 7:47 p.m. UTC | #2
Ben Pfaff <blp@ovn.org> writes:

> On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
>> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
>> ---
>>  Documentation/intro/install/rhel.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
>> index 86c5cf3..aff6ccf 100644
>> --- a/Documentation/intro/install/rhel.rst
>> +++ b/Documentation/intro/install/rhel.rst
>> @@ -76,7 +76,7 @@ the below command::
>>  
>>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
>> -        libtool checkpolicy selinux-policy-devel
>> +        libtool checkpolicy selinux-policy-devel python-sphinx
>
> For Debian, we just recommend installing the build-dependencies listed
> in debian/control.  That has the advantage that it can't get out of
> date.  It has the disadvantage, though, that it's not easy to cut and
> paste (although "apt-get build-dep openvswitch" usually does the trick).
> Maybe "yum" has some mode that installs dependencies from a spec file?

For 'yum' distributions:

  yum-builddep

For 'dnf' distributions (newer Fedora, and future RHEL versions):

  dnf builddep
Ben Pfaff Oct. 31, 2017, 7:58 p.m. UTC | #3
On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:
> Ben Pfaff <blp@ovn.org> writes:
> 
> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
> >> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> >> ---
> >>  Documentation/intro/install/rhel.rst | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
> >> index 86c5cf3..aff6ccf 100644
> >> --- a/Documentation/intro/install/rhel.rst
> >> +++ b/Documentation/intro/install/rhel.rst
> >> @@ -76,7 +76,7 @@ the below command::
> >>  
> >>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
> >>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
> >> -        libtool checkpolicy selinux-policy-devel
> >> +        libtool checkpolicy selinux-policy-devel python-sphinx
> >
> > For Debian, we just recommend installing the build-dependencies listed
> > in debian/control.  That has the advantage that it can't get out of
> > date.  It has the disadvantage, though, that it's not easy to cut and
> > paste (although "apt-get build-dep openvswitch" usually does the trick).
> > Maybe "yum" has some mode that installs dependencies from a spec file?
> 
> For 'yum' distributions:
> 
>   yum-builddep
> 
> For 'dnf' distributions (newer Fedora, and future RHEL versions):
> 
>   dnf builddep

Would it be reasonable to change rhel.rst to recommend using one of
those tools, to ease future maintenance?
Aaron Conole Oct. 31, 2017, 8:06 p.m. UTC | #4
Ben Pfaff <blp@ovn.org> writes:

> On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:
>> Ben Pfaff <blp@ovn.org> writes:
>> 
>> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
>> >> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
>> >> ---
>> >>  Documentation/intro/install/rhel.rst | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >> 
>> >> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
>> >> index 86c5cf3..aff6ccf 100644
>> >> --- a/Documentation/intro/install/rhel.rst
>> >> +++ b/Documentation/intro/install/rhel.rst
>> >> @@ -76,7 +76,7 @@ the below command::
>> >>  
>> >>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>> >>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
>> >> -        libtool checkpolicy selinux-policy-devel
>> >> +        libtool checkpolicy selinux-policy-devel python-sphinx
>> >
>> > For Debian, we just recommend installing the build-dependencies listed
>> > in debian/control.  That has the advantage that it can't get out of
>> > date.  It has the disadvantage, though, that it's not easy to cut and
>> > paste (although "apt-get build-dep openvswitch" usually does the trick).
>> > Maybe "yum" has some mode that installs dependencies from a spec file?
>> 
>> For 'yum' distributions:
>> 
>>   yum-builddep
>> 
>> For 'dnf' distributions (newer Fedora, and future RHEL versions):
>> 
>>   dnf builddep
>
> Would it be reasonable to change rhel.rst to recommend using one of
> those tools, to ease future maintenance?

Sure.  Something like below?  I don't know about the wordsmithing, so
I'll defer that to Guru.

---

diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/
rhel.rst
index 86c5cf3..36bb661 100644
--- a/Documentation/intro/install/rhel.rst
+++ b/Documentation/intro/install/rhel.rst
@@ -72,11 +72,14 @@ Build Requirements
 
 To compile the RPMs, you will need to install the packages described in the
 :doc:`general` along with some additional packages. These can be installed with
-the below command::
+the below command for ``yum`` based distributions (but note that the
+openvswitch source RPM must be available somewhere)::
 
-    $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
-        kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
-        libtool checkpolicy selinux-policy-devel
+    $ yum-builddep openvswitch
+
+For ``dnf`` based distributions, use the following command::
+
+    $ dnf builddep rhel/openvswitch-fedora.spec
 
 .. _rhel-bootstrapping:
--
Gurucharan Shetty Nov. 1, 2017, 4:05 p.m. UTC | #5
On 31 October 2017 at 13:06, Aaron Conole <aconole@redhat.com> wrote:

> Ben Pfaff <blp@ovn.org> writes:
>
> > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:
> >> Ben Pfaff <blp@ovn.org> writes:
> >>
> >> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
> >> >> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> >> >> ---
> >> >>  Documentation/intro/install/rhel.rst | 2 +-
> >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >>
> >> >> diff --git a/Documentation/intro/install/rhel.rst
> b/Documentation/intro/install/rhel.rst
> >> >> index 86c5cf3..aff6ccf 100644
> >> >> --- a/Documentation/intro/install/rhel.rst
> >> >> +++ b/Documentation/intro/install/rhel.rst
> >> >> @@ -76,7 +76,7 @@ the below command::
> >> >>
> >> >>      $ yum install gcc make python-devel openssl-devel kernel-devel
> graphviz \
> >> >>          kernel-debug-devel autoconf automake rpm-build
> redhat-rpm-config \
> >> >> -        libtool checkpolicy selinux-policy-devel
> >> >> +        libtool checkpolicy selinux-policy-devel python-sphinx
> >> >
> >> > For Debian, we just recommend installing the build-dependencies listed
> >> > in debian/control.  That has the advantage that it can't get out of
> >> > date.  It has the disadvantage, though, that it's not easy to cut and
> >> > paste (although "apt-get build-dep openvswitch" usually does the
> trick).
> >> > Maybe "yum" has some mode that installs dependencies from a spec file?
> >>
> >> For 'yum' distributions:
> >>
> >>   yum-builddep
> >>
> >> For 'dnf' distributions (newer Fedora, and future RHEL versions):
> >>
> >>   dnf builddep
> >
> > Would it be reasonable to change rhel.rst to recommend using one of
> > those tools, to ease future maintenance?
>
> Sure.  Something like below?  I don't know about the wordsmithing, so
> I'll defer that to Guru.
>
> ---
>
> diff --git a/Documentation/intro/install/rhel.rst
> b/Documentation/intro/install/
> rhel.rst
> index 86c5cf3..36bb661 100644
> --- a/Documentation/intro/install/rhel.rst
> +++ b/Documentation/intro/install/rhel.rst
> @@ -72,11 +72,14 @@ Build Requirements
>
>  To compile the RPMs, you will need to install the packages described in
> the
>  :doc:`general` along with some additional packages. These can be
> installed with
> -the below command::
> +the below command for ``yum`` based distributions (but note that the
> +openvswitch source RPM must be available somewhere)::
>

Expecting source rpm while building the rpm, looks like is not going to
happen for majority of the cases. I took it that we will need it if
"yum-builddep openvswitch" needs to succeed?.





>
> -    $ yum install gcc make python-devel openssl-devel kernel-devel
> graphviz \
> -        kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
> -        libtool checkpolicy selinux-policy-devel
> +    $ yum-builddep openvswitch
> +
> +For ``dnf`` based distributions, use the following command::
> +
> +    $ dnf builddep rhel/openvswitch-fedora.spec
>
>  .. _rhel-bootstrapping:
> --
>
Aaron Conole Nov. 1, 2017, 5:21 p.m. UTC | #6
Guru Shetty <guru@ovn.org> writes:

> On 31 October 2017 at 13:06, Aaron Conole <aconole@redhat.com> wrote:
>
>  Ben Pfaff <blp@ovn.org> writes:
>
>  > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:
>  >> Ben Pfaff <blp@ovn.org> writes:
>  >>
>  >> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
>  >> >> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
>  >> >> ---
>  >> >>  Documentation/intro/install/rhel.rst | 2 +-
>  >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>  >> >>
>  >> >> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
>  >> >> index 86c5cf3..aff6ccf 100644
>  >> >> --- a/Documentation/intro/install/rhel.rst
>  >> >> +++ b/Documentation/intro/install/rhel.rst
>  >> >> @@ -76,7 +76,7 @@ the below command::
>  >> >>
>  >> >>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>  >> >>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
>  >> >> -        libtool checkpolicy selinux-policy-devel
>  >> >> +        libtool checkpolicy selinux-policy-devel python-sphinx
>  >> >
>  >> > For Debian, we just recommend installing the build-dependencies listed
>  >> > in debian/control.  That has the advantage that it can't get out of
>  >> > date.  It has the disadvantage, though, that it's not easy to cut and
>  >> > paste (although "apt-get build-dep openvswitch" usually does the trick).
>  >> > Maybe "yum" has some mode that installs dependencies from a spec file?
>  >>
>  >> For 'yum' distributions:
>  >>
>  >>   yum-builddep
>  >>
>  >> For 'dnf' distributions (newer Fedora, and future RHEL versions):
>  >>
>  >>   dnf builddep
>  >
>  > Would it be reasonable to change rhel.rst to recommend using one of
>  > those tools, to ease future maintenance?
>
>  Sure.  Something like below?  I don't know about the wordsmithing, so
>  I'll defer that to Guru.
>
>  ---
>
>  diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/
>  rhel.rst
>  index 86c5cf3..36bb661 100644
>  --- a/Documentation/intro/install/rhel.rst
>  +++ b/Documentation/intro/install/rhel.rst
>  @@ -72,11 +72,14 @@ Build Requirements
>
>   To compile the RPMs, you will need to install the packages described in the
>   :doc:`general` along with some additional packages. These can be installed with
>  -the below command::
>  +the below command for ``yum`` based distributions (but note that the
>  +openvswitch source RPM must be available somewhere)::
>
> Expecting source rpm while building the rpm, looks like is not going to happen for majority of the
> cases. I took it that we will need it if "yum-builddep openvswitch" needs to succeed?.

I didn't think about.  As I understand, `yum-builddep` requires the
source RPM.  That means we would need to build the SRPM (rpmbuild -bs)
first.

Maybe it would be better to document using the `mock` tool for this job
(since it should be included, and is designed for building the RPMs from
a clean chroot).  The upside is that it should be the same regardless of
RHEL/Fedora/CentOS.  I'm not sure about SUSE or other rpm-based
distributions, though.

>  -    $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>  -        kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
>  -        libtool checkpolicy selinux-policy-devel
>  +    $ yum-builddep openvswitch
>  +
>  +For ``dnf`` based distributions, use the following command::
>  +
>  +    $ dnf builddep rhel/openvswitch-fedora.spec
>
>   .. _rhel-bootstrapping:
>  --
Flavio Leitner Nov. 8, 2017, 5:31 p.m. UTC | #7
On Wed, 01 Nov 2017 13:21:22 -0400
Aaron Conole <aconole@redhat.com> wrote:

> Guru Shetty <guru@ovn.org> writes:
> 
> > On 31 October 2017 at 13:06, Aaron Conole <aconole@redhat.com> wrote:
> >
> >  Ben Pfaff <blp@ovn.org> writes:
> >  
> >  > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:  
> >  >> Ben Pfaff <blp@ovn.org> writes:
> >  >>  
> >  >> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:  
> >  >> >> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> >  >> >> ---
> >  >> >>  Documentation/intro/install/rhel.rst | 2 +-
> >  >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >  >> >>
> >  >> >> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
> >  >> >> index 86c5cf3..aff6ccf 100644
> >  >> >> --- a/Documentation/intro/install/rhel.rst
> >  >> >> +++ b/Documentation/intro/install/rhel.rst
> >  >> >> @@ -76,7 +76,7 @@ the below command::
> >  >> >>
> >  >> >>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
> >  >> >>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
> >  >> >> -        libtool checkpolicy selinux-policy-devel
> >  >> >> +        libtool checkpolicy selinux-policy-devel python-sphinx  
> >  >> >
> >  >> > For Debian, we just recommend installing the build-dependencies listed
> >  >> > in debian/control.  That has the advantage that it can't get out of
> >  >> > date.  It has the disadvantage, though, that it's not easy to cut and
> >  >> > paste (although "apt-get build-dep openvswitch" usually does the trick).
> >  >> > Maybe "yum" has some mode that installs dependencies from a spec file?  
> >  >>
> >  >> For 'yum' distributions:
> >  >>
> >  >>   yum-builddep
> >  >>
> >  >> For 'dnf' distributions (newer Fedora, and future RHEL versions):
> >  >>
> >  >>   dnf builddep  
> >  >
> >  > Would it be reasonable to change rhel.rst to recommend using one of
> >  > those tools, to ease future maintenance?  
> >
> >  Sure.  Something like below?  I don't know about the wordsmithing, so
> >  I'll defer that to Guru.
> >
> >  ---
> >
> >  diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/
> >  rhel.rst
> >  index 86c5cf3..36bb661 100644
> >  --- a/Documentation/intro/install/rhel.rst
> >  +++ b/Documentation/intro/install/rhel.rst
> >  @@ -72,11 +72,14 @@ Build Requirements
> >
> >   To compile the RPMs, you will need to install the packages described in the
> >   :doc:`general` along with some additional packages. These can be installed with
> >  -the below command::
> >  +the below command for ``yum`` based distributions (but note that the
> >  +openvswitch source RPM must be available somewhere)::
> >
> > Expecting source rpm while building the rpm, looks like is not going to happen for majority of the
> > cases. I took it that we will need it if "yum-builddep openvswitch" needs to succeed?.  
> 
> I didn't think about.  As I understand, `yum-builddep` requires the
> source RPM.  That means we would need to build the SRPM (rpmbuild -bs)
> first.

You can use both tools with the spec file:
[fleitner@plex ovs]$ sudo yum-builddep rhel/openvswitch-fedora.spec
[...]
 --> Already installed : selinux-policy-devel-3.13.1-260.13.fc26.noarch
 --> Already installed : systemd-233-6.fc26.x86_64
No uninstalled build requires

yum-builddep(1)

SYNOPSIS
       yum-builddep package

DESCRIPTION
       yum-builddep  is  a  program  which  installs the RPMs needed to build the
       specified package.  The source RPM  for  the  specified  package  must  be
       available  in a Yum repository (which will be automatically enabled, if it
       is disabled) or it can be a local source RPM or a spec file.
                                                    ^^^^^^^^^^^^^^^^

[fleitner@plex ovs]$ sudo dnf builddep rhel/openvswitch-fedora.spec 
[...]
Package python3-devel-3.6.2-8.fc26.x86_64 is already installed, skipping.
Package selinux-policy-devel-3.13.1-260.13.fc26.noarch is already installed, skipping.
Package systemd-233-6.fc26.x86_64 is already installed, skipping.
Dependencies resolved.
Nothing to do.
Complete!


DNF.PLUGIN.BUILDDEP(8)     
      Install  whatever  is  needed  to  build the given .src.rpm, .nosrc.rpm or
       .spec file.


fbl

> 
> Maybe it would be better to document using the `mock` tool for this job
> (since it should be included, and is designed for building the RPMs from
> a clean chroot).  The upside is that it should be the same regardless of
> RHEL/Fedora/CentOS.  I'm not sure about SUSE or other rpm-based
> distributions, though.
> 
> >  -    $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
> >  -        kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
> >  -        libtool checkpolicy selinux-policy-devel
> >  +    $ yum-builddep openvswitch
> >  +
> >  +For ``dnf`` based distributions, use the following command::
> >  +
> >  +    $ dnf builddep rhel/openvswitch-fedora.spec
> >
> >   .. _rhel-bootstrapping:
> >  --  
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff Nov. 8, 2017, 8:18 p.m. UTC | #8
On Wed, Nov 08, 2017 at 03:31:48PM -0200, Flavio Leitner wrote:
> On Wed, 01 Nov 2017 13:21:22 -0400
> Aaron Conole <aconole@redhat.com> wrote:
> 
> > Guru Shetty <guru@ovn.org> writes:
> > 
> > > On 31 October 2017 at 13:06, Aaron Conole <aconole@redhat.com> wrote:
> > >
> > >  Ben Pfaff <blp@ovn.org> writes:
> > >  
> > >  > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:  
> > >  >> Ben Pfaff <blp@ovn.org> writes:
> > >  >>  
> > >  >> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:  
> > >  >> >> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> > >  >> >> ---
> > >  >> >>  Documentation/intro/install/rhel.rst | 2 +-
> > >  >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >  >> >>
> > >  >> >> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
> > >  >> >> index 86c5cf3..aff6ccf 100644
> > >  >> >> --- a/Documentation/intro/install/rhel.rst
> > >  >> >> +++ b/Documentation/intro/install/rhel.rst
> > >  >> >> @@ -76,7 +76,7 @@ the below command::
> > >  >> >>
> > >  >> >>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
> > >  >> >>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
> > >  >> >> -        libtool checkpolicy selinux-policy-devel
> > >  >> >> +        libtool checkpolicy selinux-policy-devel python-sphinx  
> > >  >> >
> > >  >> > For Debian, we just recommend installing the build-dependencies listed
> > >  >> > in debian/control.  That has the advantage that it can't get out of
> > >  >> > date.  It has the disadvantage, though, that it's not easy to cut and
> > >  >> > paste (although "apt-get build-dep openvswitch" usually does the trick).
> > >  >> > Maybe "yum" has some mode that installs dependencies from a spec file?  
> > >  >>
> > >  >> For 'yum' distributions:
> > >  >>
> > >  >>   yum-builddep
> > >  >>
> > >  >> For 'dnf' distributions (newer Fedora, and future RHEL versions):
> > >  >>
> > >  >>   dnf builddep  
> > >  >
> > >  > Would it be reasonable to change rhel.rst to recommend using one of
> > >  > those tools, to ease future maintenance?  
> > >
> > >  Sure.  Something like below?  I don't know about the wordsmithing, so
> > >  I'll defer that to Guru.
> > >
> > >  ---
> > >
> > >  diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/
> > >  rhel.rst
> > >  index 86c5cf3..36bb661 100644
> > >  --- a/Documentation/intro/install/rhel.rst
> > >  +++ b/Documentation/intro/install/rhel.rst
> > >  @@ -72,11 +72,14 @@ Build Requirements
> > >
> > >   To compile the RPMs, you will need to install the packages described in the
> > >   :doc:`general` along with some additional packages. These can be installed with
> > >  -the below command::
> > >  +the below command for ``yum`` based distributions (but note that the
> > >  +openvswitch source RPM must be available somewhere)::
> > >
> > > Expecting source rpm while building the rpm, looks like is not going to happen for majority of the
> > > cases. I took it that we will need it if "yum-builddep openvswitch" needs to succeed?.  
> > 
> > I didn't think about.  As I understand, `yum-builddep` requires the
> > source RPM.  That means we would need to build the SRPM (rpmbuild -bs)
> > first.
> 
> You can use both tools with the spec file:
> [fleitner@plex ovs]$ sudo yum-builddep rhel/openvswitch-fedora.spec

Hey, that seems about perfect.  Can we recommend using that?
Flavio Leitner Nov. 14, 2017, 10:34 p.m. UTC | #9
On Wed, 8 Nov 2017 12:18:36 -0800
Ben Pfaff <blp@ovn.org> wrote:

> On Wed, Nov 08, 2017 at 03:31:48PM -0200, Flavio Leitner wrote:
> > On Wed, 01 Nov 2017 13:21:22 -0400
> > Aaron Conole <aconole@redhat.com> wrote:
> > 
> > > Guru Shetty <guru@ovn.org> writes:
> > > 
> > > > On 31 October 2017 at 13:06, Aaron Conole <aconole@redhat.com> wrote:
> > > >
> > > >  Ben Pfaff <blp@ovn.org> writes:
> > > >  
> > > >  > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:  
> > > >  >> Ben Pfaff <blp@ovn.org> writes:
> > > >  >>  
> > > >  >> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:  
> > > >  >> >> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
> > > >  >> >> ---
> > > >  >> >>  Documentation/intro/install/rhel.rst | 2 +-
> > > >  >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >  >> >>
> > > >  >> >> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
> > > >  >> >> index 86c5cf3..aff6ccf 100644
> > > >  >> >> --- a/Documentation/intro/install/rhel.rst
> > > >  >> >> +++ b/Documentation/intro/install/rhel.rst
> > > >  >> >> @@ -76,7 +76,7 @@ the below command::
> > > >  >> >>
> > > >  >> >>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
> > > >  >> >>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
> > > >  >> >> -        libtool checkpolicy selinux-policy-devel
> > > >  >> >> +        libtool checkpolicy selinux-policy-devel python-sphinx  
> > > >  >> >
> > > >  >> > For Debian, we just recommend installing the build-dependencies listed
> > > >  >> > in debian/control.  That has the advantage that it can't get out of
> > > >  >> > date.  It has the disadvantage, though, that it's not easy to cut and
> > > >  >> > paste (although "apt-get build-dep openvswitch" usually does the trick).
> > > >  >> > Maybe "yum" has some mode that installs dependencies from a spec file?  
> > > >  >>
> > > >  >> For 'yum' distributions:
> > > >  >>
> > > >  >>   yum-builddep
> > > >  >>
> > > >  >> For 'dnf' distributions (newer Fedora, and future RHEL versions):
> > > >  >>
> > > >  >>   dnf builddep  
> > > >  >
> > > >  > Would it be reasonable to change rhel.rst to recommend using one of
> > > >  > those tools, to ease future maintenance?  
> > > >
> > > >  Sure.  Something like below?  I don't know about the wordsmithing, so
> > > >  I'll defer that to Guru.
> > > >
> > > >  ---
> > > >
> > > >  diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/
> > > >  rhel.rst
> > > >  index 86c5cf3..36bb661 100644
> > > >  --- a/Documentation/intro/install/rhel.rst
> > > >  +++ b/Documentation/intro/install/rhel.rst
> > > >  @@ -72,11 +72,14 @@ Build Requirements
> > > >
> > > >   To compile the RPMs, you will need to install the packages described in the
> > > >   :doc:`general` along with some additional packages. These can be installed with
> > > >  -the below command::
> > > >  +the below command for ``yum`` based distributions (but note that the
> > > >  +openvswitch source RPM must be available somewhere)::
> > > >
> > > > Expecting source rpm while building the rpm, looks like is not going to happen for majority of the
> > > > cases. I took it that we will need it if "yum-builddep openvswitch" needs to succeed?.  
> > > 
> > > I didn't think about.  As I understand, `yum-builddep` requires the
> > > source RPM.  That means we would need to build the SRPM (rpmbuild -bs)
> > > first.
> > 
> > You can use both tools with the spec file:
> > [fleitner@plex ovs]$ sudo yum-builddep rhel/openvswitch-fedora.spec
> 
> Hey, that seems about perfect.  Can we recommend using that?

I posted this patch that uses in-tree spec file and also uses
RPM Development Tools group to simplify the process:

https://mail.openvswitch.org/pipermail/ovs-dev/2017-November/340929.html

Thanks,

Patch
diff mbox series

diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
index 86c5cf3..aff6ccf 100644
--- a/Documentation/intro/install/rhel.rst
+++ b/Documentation/intro/install/rhel.rst
@@ -76,7 +76,7 @@  the below command::
 
     $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
         kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
-        libtool checkpolicy selinux-policy-devel
+        libtool checkpolicy selinux-policy-devel python-sphinx
 
 .. _rhel-bootstrapping: