| Message ID | 20171020115942.26732-1-mikey@neuling.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/9] phb4: Update comment | expand |
On Fri, 2017-10-20 at 22:59 +1100, Michael Neuling wrote: > No functional change. Super critical comment... > Signed-off-by: Michael Neuling <mikey@neuling.org> > --- > hw/phb4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/phb4.c b/hw/phb4.c > index c64ded92f9..492716857b 100644 > --- a/hw/phb4.c > +++ b/hw/phb4.c > @@ -1140,7 +1140,7 @@ static int64_t phb4_ioda_reset(struct phb *phb, bool purge) > > /* Additional OPAL specific inits */ > > - /* Clear RTT and PELTV */ > + /* Clear RTT and PELTV and pest */ and PEST, not pest :-) > if (p->tbl_rtt) > memcpy((void *)p->tbl_rtt, p->rte_cache, RTT_TABLE_SIZE); > if (p->tbl_peltv)
On Fri, 2017-10-20 at 14:54 +0200, Benjamin Herrenschmidt wrote: > On Fri, 2017-10-20 at 22:59 +1100, Michael Neuling wrote: > > No functional change. > > Super critical comment... > > > Signed-off-by: Michael Neuling <mikey@neuling.org> > > --- > > hw/phb4.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/phb4.c b/hw/phb4.c > > index c64ded92f9..492716857b 100644 > > --- a/hw/phb4.c > > +++ b/hw/phb4.c > > @@ -1140,7 +1140,7 @@ static int64_t phb4_ioda_reset(struct phb *phb, bool > > purge) > > > > /* Additional OPAL specific inits */ > > > > - /* Clear RTT and PELTV */ > > + /* Clear RTT and PELTV and pest */ > > and PEST, not pest :-) You're a pest! :-P Mikey > > > if (p->tbl_rtt) > > memcpy((void *)p->tbl_rtt, p->rte_cache, RTT_TABLE_SIZE); > > if (p->tbl_peltv) > >
diff --git a/hw/phb4.c b/hw/phb4.c index c64ded92f9..492716857b 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -1140,7 +1140,7 @@ static int64_t phb4_ioda_reset(struct phb *phb, bool purge) /* Additional OPAL specific inits */ - /* Clear RTT and PELTV */ + /* Clear RTT and PELTV and pest */ if (p->tbl_rtt) memcpy((void *)p->tbl_rtt, p->rte_cache, RTT_TABLE_SIZE); if (p->tbl_peltv)
No functional change. Signed-off-by: Michael Neuling <mikey@neuling.org> --- hw/phb4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)