diff mbox series

[U-Boot,8/9] x86: fsp: graphics: Add some notes about the graphics info hob

Message ID 1508376060-29425-8-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit dc80d3b2309b7c6f94daa2a2bd843b8febfa0369
Delegated to: Bin Meng
Headers show
Series [U-Boot,1/9] x86: galileo: Fix boot failure | expand

Commit Message

Bin Meng Oct. 19, 2017, 1:20 a.m. UTC
On some platforms (eg: Braswell), the FSP will not produce the
graphics info HOB unless you plug some cables to the display
interface (eg: HDMI) on the board. Add such notes in the FSP
video driver.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/lib/fsp/fsp_graphics.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Simon Glass Oct. 22, 2017, 2:36 p.m. UTC | #1
On 19 October 2017 at 03:20, Bin Meng <bmeng.cn@gmail.com> wrote:
> On some platforms (eg: Braswell), the FSP will not produce the
> graphics info HOB unless you plug some cables to the display
> interface (eg: HDMI) on the board. Add such notes in the FSP
> video driver.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  arch/x86/lib/fsp/fsp_graphics.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Bin Meng Oct. 27, 2017, 7:12 a.m. UTC | #2
On Sun, Oct 22, 2017 at 10:36 PM, Simon Glass <sjg@chromium.org> wrote:
> On 19 October 2017 at 03:20, Bin Meng <bmeng.cn@gmail.com> wrote:
>> On some platforms (eg: Braswell), the FSP will not produce the
>> graphics info HOB unless you plug some cables to the display
>> interface (eg: HDMI) on the board. Add such notes in the FSP
>> video driver.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  arch/x86/lib/fsp/fsp_graphics.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/arch/x86/lib/fsp/fsp_graphics.c b/arch/x86/lib/fsp/fsp_graphics.c
index a19b067..af71276 100644
--- a/arch/x86/lib/fsp/fsp_graphics.c
+++ b/arch/x86/lib/fsp/fsp_graphics.c
@@ -37,6 +37,10 @@  static int save_vesa_mode(struct vesa_mode_info *vesa)
 	/*
 	 * If there is no graphics info structure, bail out and keep
 	 * running on the serial console.
+	 *
+	 * Note: on some platforms (eg: Braswell), the FSP will not produce
+	 * the graphics info HOB unless you plug some cables to the display
+	 * interface (eg: HDMI) on the board.
 	 */
 	if (!ginfo) {
 		debug("FSP graphics hand-off block not found\n");