Patchwork [U-Boot] cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too

login
register
mail settings
Submitter Steffen Sledz
Date Feb. 11, 2011, 2:30 p.m.
Message ID <1297434651-7431-1-git-send-email-sledz@dresearch.de>
Download mbox | patch
Permalink /patch/82763/
State Accepted
Commit 2c9f48af7315ab7eeba739bec37256b246c64819
Headers show

Comments

Steffen Sledz - Feb. 11, 2011, 2:30 p.m.
Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
Signed-off-by: Steffen Sledz <sledz@dresearch.de>
---
 drivers/mtd/cfi_flash.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Steffen Sledz - Feb. 21, 2011, 8:30 a.m.
Am 11.02.2011 15:30, schrieb Steffen Sledz:
> Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
> Signed-off-by: Steffen Sledz <sledz@dresearch.de>
> ---
>  drivers/mtd/cfi_flash.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index dd394a8..527a3a5 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
> @@ -1924,7 +1924,8 @@ ulong flash_get_size (phys_addr_t base, int banknum)
>  
>  		/* Do manufacturer-specific fixups */
>  		switch (info->manufacturer_id) {
> -		case 0x0001:
> +		case 0x0001: /* AMD */
> +		case 0x0037: /* AMIC */
>  			flash_fixup_amd(info, &qry);
>  			break;
>  		case 0x001f:

Ping!
Stefan Roese - Feb. 21, 2011, 10:14 a.m.
Hi Steffen,

On Monday 21 February 2011 09:30:35 Steffen Sledz wrote:
> Am 11.02.2011 15:30, schrieb Steffen Sledz:
> > Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
> > Signed-off-by: Steffen Sledz <sledz@dresearch.de>
> > ---
> > 
> >  drivers/mtd/cfi_flash.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> > index dd394a8..527a3a5 100644
> > --- a/drivers/mtd/cfi_flash.c
> > +++ b/drivers/mtd/cfi_flash.c
> > @@ -1924,7 +1924,8 @@ ulong flash_get_size (phys_addr_t base, int
> > banknum)
> > 
> >  		/* Do manufacturer-specific fixups */
> >  		switch (info->manufacturer_id) {
> > 
> > -		case 0x0001:
> > +		case 0x0001: /* AMD */
> > +		case 0x0037: /* AMIC */
> > 
> >  			flash_fixup_amd(info, &qry);
> >  			break;
> >  		
> >  		case 0x001f:
> Ping!

This patch is not really a bug-fix. So I have it queued for the upcoming 
"next" branch (will open with -rc2).

But I do have a small question about the patch: Who is the author of this 
patch? You (Steffen) or Mario? If its Mario, then you should add a "From: 
Mario Schuknecht <m.schuknecht@dresearch.de>" line at the beginning of the 
mail body. If its yourself, then you should switch the Signed-off-by lines 
(author should be the first here).

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
Steffen Sledz - Feb. 21, 2011, 12:12 p.m.
Am 21.02.2011 11:14, schrieb Stefan Roese:
> Hi Steffen,
> 
> On Monday 21 February 2011 09:30:35 Steffen Sledz wrote:
>> Am 11.02.2011 15:30, schrieb Steffen Sledz:
>>> Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
>>> Signed-off-by: Steffen Sledz <sledz@dresearch.de>
>>> ...
>> Ping!
> 
> This patch is not really a bug-fix. So I have it queued for the upcoming 
> "next" branch (will open with -rc2).

OK, no problem.

> But I do have a small question about the patch: Who is the author of this 
> patch? You (Steffen) or Mario? If its Mario, then you should add a "From: 
> Mario Schuknecht <m.schuknecht@dresearch.de>" line at the beginning of the 
> mail body. If its yourself, then you should switch the Signed-off-by lines 
> (author should be the first here).

Mario is the main author. I'll send  an update to the patch.

Steffen

Patch

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index dd394a8..527a3a5 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -1924,7 +1924,8 @@  ulong flash_get_size (phys_addr_t base, int banknum)
 
 		/* Do manufacturer-specific fixups */
 		switch (info->manufacturer_id) {
-		case 0x0001:
+		case 0x0001: /* AMD */
+		case 0x0037: /* AMIC */
 			flash_fixup_amd(info, &qry);
 			break;
 		case 0x001f: