diff mbox series

[v2,02/39] MAINTAINERS: add entries for dma/i82374

Message ID 20171017001209.32276-3-f4bug@amsat.org
State Superseded, archived
Headers show
Series remove i386/pc dependency from non-PC world (part 1) | expand

Commit Message

Philippe Mathieu-Daudé Oct. 17, 2017, 12:11 a.m. UTC 
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Huth Oct. 17, 2017, 6:59 a.m. UTC | #1 
On 17.10.2017 02:11, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6f56c1349b..cfd9010e27 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -713,6 +713,7 @@ F: hw/ppc/prep_systemio.c
>  F: hw/ppc/rs6000_mc.c
>  F: hw/pci-host/prep.[hc]
>  F: hw/isa/pc87312.[hc]
> +F: hw/dma/i82374.c
>  F: pc-bios/ppc_rom.bin
>  
>  sPAPR
> @@ -854,6 +855,7 @@ F: hw/misc/pc-testdev.c
>  F: hw/timer/hpet*
>  F: hw/timer/i8254*
>  F: hw/timer/mc146818rtc*
> +F: include/hw/dma/i8257_dma.h

Does not match $subject. And the file does not exist yet (you just
create it in patch 39). And I think you should CC: the corresponding
maintainers so that they have a chance to say yes or no.

 Thomas
Philippe Mathieu-Daudé Oct. 17, 2017, 4:30 p.m. UTC | #2 
On 10/17/2017 03:59 AM, Thomas Huth wrote:
> On 17.10.2017 02:11, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 2 ++
[...]
>>  sPAPR
>> @@ -854,6 +855,7 @@ F: hw/misc/pc-testdev.c
>>  F: hw/timer/hpet*
>>  F: hw/timer/i8254*
>>  F: hw/timer/mc146818rtc*
>> +F: include/hw/dma/i8257_dma.h
> 
> Does not match $subject. And the file does not exist yet (you just
> create it in patch 39). And I think you should CC: the corresponding
> maintainers so that they have a chance to say yes or no.

Oops... fair enough ;)
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 6f56c1349b..cfd9010e27 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -713,6 +713,7 @@  F: hw/ppc/prep_systemio.c
 F: hw/ppc/rs6000_mc.c
 F: hw/pci-host/prep.[hc]
 F: hw/isa/pc87312.[hc]
+F: hw/dma/i82374.c
 F: pc-bios/ppc_rom.bin
 
 sPAPR
@@ -854,6 +855,7 @@  F: hw/misc/pc-testdev.c
 F: hw/timer/hpet*
 F: hw/timer/i8254*
 F: hw/timer/mc146818rtc*
+F: include/hw/dma/i8257_dma.h
 F: include/hw/i2c/pm_smbus.h
 F: include/hw/timer/hpet.h
 F: include/hw/timer/i8254*