| Message ID | 1508189042-19591-1-git-send-email-dsahern@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] tcp: Use pI6c in tcp tracepoint | expand |
On Mon, Oct 16, 2017 at 2:24 PM, David Ahern <dsahern@gmail.com> wrote: > The compact form for IPv6 addresses is more user friendly than the full > version. For example: > compact: 2001:db8:1::1 > full: 2001:0db8:0001:0000:0000:0000:0000:0004i > > Update the tcp tracepoint to show the compact form. > > Signed-off-by: David Ahern <dsahern@gmail.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> I was planning to send a same patch based on your suggestion, you are faster than me. ;)
On 10/16/17 3:41 PM, Cong Wang wrote: > I was planning to send a same patch based on your > suggestion, you are faster than me. ;) > I would have sent that patch hours ago, but got hung up on the testing. See the second patch.
On Mon, Oct 16, 2017 at 02:24:02PM -0700, David Ahern wrote: > The compact form for IPv6 addresses is more user friendly than the full > version. For example: > compact: 2001:db8:1::1 > full: 2001:0db8:0001:0000:0000:0000:0000:0004i > > Update the tcp tracepoint to show the compact form. > > Signed-off-by: David Ahern <dsahern@gmail.com> nice improvement. Acked-by: Alexei Starovoitov <ast@kernel.org>
From: David Ahern <dsahern@gmail.com> Date: Mon, 16 Oct 2017 14:24:02 -0700 > The compact form for IPv6 addresses is more user friendly than the full > version. For example: > compact: 2001:db8:1::1 > full: 2001:0db8:0001:0000:0000:0000:0000:0004i > > Update the tcp tracepoint to show the compact form. > > Signed-off-by: David Ahern <dsahern@gmail.com> Applied.
diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h index 3d1cbd072b7e..1ffab6d96e94 100644 --- a/include/trace/events/tcp.h +++ b/include/trace/events/tcp.h @@ -57,7 +57,7 @@ TRACE_EVENT(tcp_retransmit_skb, } ), - TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6 daddrv6=%pI6", + TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c", __entry->sport, __entry->dport, __entry->saddr, __entry->daddr, __entry->saddr_v6, __entry->daddr_v6) );
The compact form for IPv6 addresses is more user friendly than the full version. For example: compact: 2001:db8:1::1 full: 2001:0db8:0001:0000:0000:0000:0000:0004i Update the tcp tracepoint to show the compact form. Signed-off-by: David Ahern <dsahern@gmail.com> --- include/trace/events/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)