| Message ID | 1508164005-57189-2-git-send-email-u9012063@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev,1/2] acinclude: Add support for grep option. | expand |
On 10/16/2017 07:26 AM, William Tu wrote: > The HAVE_SKB_GSO_UDP checks whether skbuff.h defines SKB_GSO_UDP. > However, it falsely returns yes because it finds SKB_GSO_UDP_TUNNEL. > Thus, add exact match "-w" option for the grep command. > > Fixes: ad283644f0e4 ("acinclude: Check for SKB_GSO_UDP") > Signed-off-by: William Tu <u9012063@gmail.com> > Cc: Greg Rose <gvrose8192@gmail.com> > --- > acinclude.m4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 543e1e3f0630..3158c20fbe55 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -769,7 +769,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ > [nf_conntrack_helper_put], > [OVS_DEFINE(HAVE_NF_CONNTRACK_HELPER_PUT)]) > OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h],[SKB_GSO_UDP], > - [OVS_DEFINE([HAVE_SKB_GSO_UDP])]) > + [OVS_DEFINE([HAVE_SKB_GSO_UDP])], [], [-w]) > OVS_GREP_IFELSE([$KSRC/include/net/dst.h],[DST_NOCACHE], > [OVS_DEFINE([HAVE_DST_NOCACHE])]) > OVS_FIND_FIELD_IFELSE([$KSRC/include/net/rtnetlink.h], [rtnl_link_ops], > Tested-by: Greg Rose <gvrose8192@gmail.com> Reviewed-by: Greg Rose <gvrose8192@gmail.com>
diff --git a/acinclude.m4 b/acinclude.m4 index 543e1e3f0630..3158c20fbe55 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -769,7 +769,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ [nf_conntrack_helper_put], [OVS_DEFINE(HAVE_NF_CONNTRACK_HELPER_PUT)]) OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h],[SKB_GSO_UDP], - [OVS_DEFINE([HAVE_SKB_GSO_UDP])]) + [OVS_DEFINE([HAVE_SKB_GSO_UDP])], [], [-w]) OVS_GREP_IFELSE([$KSRC/include/net/dst.h],[DST_NOCACHE], [OVS_DEFINE([HAVE_DST_NOCACHE])]) OVS_FIND_FIELD_IFELSE([$KSRC/include/net/rtnetlink.h], [rtnl_link_ops],
The HAVE_SKB_GSO_UDP checks whether skbuff.h defines SKB_GSO_UDP. However, it falsely returns yes because it finds SKB_GSO_UDP_TUNNEL. Thus, add exact match "-w" option for the grep command. Fixes: ad283644f0e4 ("acinclude: Check for SKB_GSO_UDP") Signed-off-by: William Tu <u9012063@gmail.com> Cc: Greg Rose <gvrose8192@gmail.com> --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)