s390: fix zfcpdump-config
diff mbox series

Message ID 1507803683-4265-1-git-send-email-xnox@ubuntu.com
State New
Headers show
Series
  • s390: fix zfcpdump-config
Related show

Commit Message

Dimitri John Ledkov Oct. 12, 2017, 10:21 a.m. UTC
zipl from s390-tools generates root=/dev/ram0 kernel cmdline for
zfcpdump, thus BLK_DEV_RAM is required.

zfcpdump initrd mounts DEBUG_FS, thus is also required.

Bug-Ubuntu: https://launchpad.net/bugs/1722735
Bug-Ubuntu: https://launchpad.net/bugs/1719290

Signed-off-by: Dimitri John Ledkov <xnox@ubuntu.com>
---
 arch/s390/configs/zfcpdump_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Seth Forshee Oct. 16, 2017, 12:46 p.m. UTC | #1
On Thu, Oct 12, 2017 at 11:21:23AM +0100, Dimitri John Ledkov wrote:
> zipl from s390-tools generates root=/dev/ram0 kernel cmdline for
> zfcpdump, thus BLK_DEV_RAM is required.
> 
> zfcpdump initrd mounts DEBUG_FS, thus is also required.
> 
> Bug-Ubuntu: https://launchpad.net/bugs/1722735
> Bug-Ubuntu: https://launchpad.net/bugs/1719290
> 
> Signed-off-by: Dimitri John Ledkov <xnox@ubuntu.com>

I assume this for artful? We've already applied a patch to enable
debugfs [1], though not one for CONFIG_BLK_DEV_RAM.

[1] https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/artful/commit/?id=3beb958e0bdfe7299f2a03b85932058055c52648
Dimitri John Ledkov Oct. 23, 2017, 11:05 a.m. UTC | #2
On 16 October 2017 at 13:46, Seth Forshee <seth.forshee@canonical.com> wrote:
> On Thu, Oct 12, 2017 at 11:21:23AM +0100, Dimitri John Ledkov wrote:
>> zipl from s390-tools generates root=/dev/ram0 kernel cmdline for
>> zfcpdump, thus BLK_DEV_RAM is required.
>>
>> zfcpdump initrd mounts DEBUG_FS, thus is also required.
>>
>> Bug-Ubuntu: https://launchpad.net/bugs/1722735
>> Bug-Ubuntu: https://launchpad.net/bugs/1719290
>>
>> Signed-off-by: Dimitri John Ledkov <xnox@ubuntu.com>
>
> I assume this for artful? We've already applied a patch to enable
> debugfs [1], though not one for CONFIG_BLK_DEV_RAM.
>

This got fixed in the zfcpdump-kernel package by apw see
https://launchpad.net/ubuntu/+source/zfcpdump-kernel/4.13-0ubuntu1

This is now merged upstream in v4.14-rc5, thus no further actions are
required w.r.t. this patch. And any changes wrt. zfcpdup_defconfig can
be dropped when moving to v4.14-rc5 or later.

Patch
diff mbox series

diff --git a/arch/s390/configs/zfcpdump_defconfig b/arch/s390/configs/zfcpdump_defconfig
index afa46a7..04e042e 100644
--- a/arch/s390/configs/zfcpdump_defconfig
+++ b/arch/s390/configs/zfcpdump_defconfig
@@ -27,6 +27,7 @@  CONFIG_NET=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 # CONFIG_FIRMWARE_IN_KERNEL is not set
+CONFIG_BLK_DEV_RAM=y
 # CONFIG_BLK_DEV_XPRAM is not set
 # CONFIG_DCSSBLK is not set
 # CONFIG_DASD is not set
@@ -59,6 +60,7 @@  CONFIG_CONFIGFS_FS=y
 # CONFIG_NETWORK_FILESYSTEMS is not set
 CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_FS=y
 CONFIG_DEBUG_KERNEL=y
 CONFIG_PANIC_ON_OOPS=y
 # CONFIG_SCHED_DEBUG is not set