| Message ID | 20171016101618.GA16785@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Testsuite,SPARC,ARM] Fix vect-multitypes-1.c test on SPARC64 and ARMEB. | expand |
Ping
Hi Tamar, > This patch fixes a regression introduced by r253451. > The target needs all three conditions to be true before it can > vectorize unaligned accesses. This patch turns the erroneous || > into an &&. > > regtested on aarch64-none-elf, arm-none-linux-gnueabihf, > x86_64-pc-linux-gnu, armeb-none-linux-gnueabihf and > sparc64-unknown-linux-gnu. > > OK for trunk? > > And for the GCC-7 branch? > > Thanks, > Tamar > > gcc/testsuite/ > 2017-10-16 Tamar Christina <tamar.christina@arm.com> > > * gcc.dg/vect/vect-multitypes-1.c: Correct target selector. Just a nit: we usually keep a space before and after braces in DejaGnu statements, so {! vect_hw_misalign } -> { ! vect_hw_misalign } Ok for mainline with that fixed, and the gcc-7 branch after a bit of soak time. Thanks. Rainer
diff --git a/gcc/testsuite/gcc.dg/vect/vect-multitypes-1.c b/gcc/testsuite/gcc.dg/vect/vect-multitypes-1.c index fd7cacb483d9cfbea6d909ba12e67544fa32a190..49e304180e7b01d41a0922b5358d30ae3af88d24 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-multitypes-1.c +++ b/gcc/testsuite/gcc.dg/vect/vect-multitypes-1.c @@ -83,5 +83,5 @@ int main (void) /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 2 "vect" { xfail { vect_no_align && { ! vect_hw_misalign } } } } } */ /* { dg-final { scan-tree-dump-times "Alignment of access forced using peeling" 2 "vect" { xfail {{ vect_no_align && { ! vect_hw_misalign } } || {vect_sizes_32B_16B }}} } } */ -/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 4 "vect" { xfail {{ vect_no_align && { ! vect_hw_misalign } } || {vect_sizes_32B_16B }}} } } */ +/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 4 "vect" { target { vect_no_align && { {! vect_hw_misalign } && vect_sizes_32B_16B } } }} } */