Patchwork [ARM] Limit thumb2 test to thumb2 targets

login
register
mail settings
Submitter Andrew Stubbs
Date Feb. 10, 2011, 3:29 p.m.
Message ID <4D54046D.4090807@codesourcery.com>
Download mbox | patch
Permalink /patch/82615/
State New
Headers show

Comments

Andrew Stubbs - Feb. 10, 2011, 3:29 p.m.
I'm posting this patch on behalf of Jie.

The patch simply prevents a test failure on non-thumb2 targets.

OK?

Andrew
Ramana Radhakrishnan - Feb. 11, 2011, 9:04 p.m.
On Thu, Feb 10, 2011 at 3:29 PM, Andrew Stubbs <ams@codesourcery.com> wrote:
> I'm posting this patch on behalf of Jie.
>
> The patch simply prevents a test failure on non-thumb2 targets.
>
> OK?

Looks obvious to me given that the testcase was intended to be Thumb2
only though I can't approve or reject your patch.

Ramana



>
> Andrew
>
Ramana Radhakrishnan - Feb. 25, 2011, 12:40 a.m.
On 10/02/2011 15:29, Andrew Stubbs wrote:
> I'm posting this patch on behalf of Jie.
>
> The patch simply prevents a test failure on non-thumb2 targets.
>
> OK?
>

OK.

Cheers,
Ramana
Andrew Stubbs - Feb. 25, 2011, 10:26 a.m.
On 25/02/11 00:40, Ramana Radhakrishnan wrote:
> OK.

Committed, thanks.

Andrew

P.S. Congratulations on approving your first official patch as 
maintainer. :)
Richard Earnshaw - March 30, 2011, 3:22 p.m.
On Thu, 2011-02-10 at 15:29 +0000, Andrew Stubbs wrote:
> I'm posting this patch on behalf of Jie.
> 
> The patch simply prevents a test failure on non-thumb2 targets.
> 
> OK?
> 
> Andrew


2010-09-30  Jie Zhang  <jie@codesourcery.com>

        gcc/testsuite/
        * gcc.target/arm/neon-thumb2-move.c: Add
        dg-require-effective-target arm_thumb2_ok.

Just in case this never got checked in, OK.

R.

Patch

2010-09-30  Jie Zhang  <jie@codesourcery.com>

	gcc/testsuite/
	* gcc.target/arm/neon-thumb2-move.c: Add
	dg-require-effective-target arm_thumb2_ok.

--- a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
+++ b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
@@ -1,5 +1,6 @@ 
 /* { dg-do compile } */
 /* { dg-require-effective-target arm_neon_ok } */
+/* { dg-require-effective-target arm_thumb2_ok } */
 /* { dg-options "-O2 -mthumb -march=armv7-a" } */
 /* { dg-add-options arm_neon } */