diff mbox series

[U-Boot,1/2] wandboard: Remove cpu type check prior to setup_sata()

Message ID 1508073667-5402-1-git-send-email-festevam@gmail.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series [U-Boot,1/2] wandboard: Remove cpu type check prior to setup_sata() | expand

Commit Message

Fabio Estevam Oct. 15, 2017, 1:21 p.m. UTC
From: Fabio Estevam <fabio.estevam@nxp.com>

Inside setup_sata() there is a cpu type check, so there is no need to
do this check in the board file.

This also brings the benefit to allowing setup_sata() to be called for the
mx6qp wandboard variant.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 board/wandboard/wandboard.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Heinrich Schuchardt Oct. 18, 2017, 4:53 p.m. UTC | #1
On 10/15/2017 03:21 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Inside setup_sata() there is a cpu type check, so there is no need to
> do this check in the board file.
> 
> This also brings the benefit to allowing setup_sata() to be called for the
> mx6qp wandboard variant.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  board/wandboard/wandboard.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
> index adfcf48..3f12b50 100644
> --- a/board/wandboard/wandboard.c
> +++ b/board/wandboard/wandboard.c
> @@ -380,9 +380,7 @@ int board_early_init_f(void)
>  	setup_display();
>  #endif
>  #ifdef CONFIG_SATA
> -	/* Only mx6q wandboard has SATA */
> -	if (is_cpu_type(MXC_CPU_MX6Q))
> -		setup_sata();
> +	setup_sata();
>  #endif
>  
>  	return 0;
> 
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
diff mbox series

Patch

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index adfcf48..3f12b50 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -380,9 +380,7 @@  int board_early_init_f(void)
 	setup_display();
 #endif
 #ifdef CONFIG_SATA
-	/* Only mx6q wandboard has SATA */
-	if (is_cpu_type(MXC_CPU_MX6Q))
-		setup_sata();
+	setup_sata();
 #endif
 
 	return 0;