diff mbox series

[U-Boot] net: fec_mxc: Change "error frame" message to debug level

Message ID 1508072508-4987-1-git-send-email-festevam@gmail.com
State Accepted
Commit 41b93679fd69bbb8c335eb212a3f8aa6c9c662db
Delegated to: Stefano Babic
Headers show
Series [U-Boot] net: fec_mxc: Change "error frame" message to debug level | expand

Commit Message

Fabio Estevam Oct. 15, 2017, 1:01 p.m. UTC 
From: Fabio Estevam <fabio.estevam@nxp.com>

As reported by Jonathan Gray:

"After the recent changes to add SimpleNetworkProtocol to efi_loader
when booting off mmc via an efi payload that doesn't use
SimpleNetworkProtocol U-Boot's fec_mxc driver will now display
various "error frame" messages.
....
MMC Device 1 not found
MMC Device 2 not found
MMC Device 3 not found
Scanning disks on sata...
Found 6 disks
reading efi/boot/bootarm.efi
67372 bytes read in 32 ms (2 MiB/s)
## Starting EFI application at 12000000 ...
>> OpenBSD/armv7 BOOTARM 1.0
error frame: 0x8f57ec40 0x00003d74
error frame: 0x8f57ec40 0x00007079
error frame: 0x8f57ec40 0x00006964
error frame: 0x8f57ec40 0x00006f6f
error frame: 0x8f57ec40 0x0000726f
error frame: 0x8f57ec40 0x00002074
error frame: 0x8f57ec40 0x00006f6f"

Heinrich Schuchardt explains:

"A receive FIFO overrun can be expected if network packages are not
processed.
With the network patches we check if a package is available quite often."

Move the "error frame" messages to debug level so that a clean output
log can be seen.

Reported-by: Jonathan Gray <jsg@jsg.id.au>
Suggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/net/fec_mxc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Oct. 30, 2017, 11:42 p.m. UTC | #1 
Hi Joe,

On Sun, Oct 15, 2017 at 11:01 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> As reported by Jonathan Gray:
>
> "After the recent changes to add SimpleNetworkProtocol to efi_loader
> when booting off mmc via an efi payload that doesn't use
> SimpleNetworkProtocol U-Boot's fec_mxc driver will now display
> various "error frame" messages.
> ....
> MMC Device 1 not found
> MMC Device 2 not found
> MMC Device 3 not found
> Scanning disks on sata...
> Found 6 disks
> reading efi/boot/bootarm.efi
> 67372 bytes read in 32 ms (2 MiB/s)
> ## Starting EFI application at 12000000 ...
>>> OpenBSD/armv7 BOOTARM 1.0
> error frame: 0x8f57ec40 0x00003d74
> error frame: 0x8f57ec40 0x00007079
> error frame: 0x8f57ec40 0x00006964
> error frame: 0x8f57ec40 0x00006f6f
> error frame: 0x8f57ec40 0x0000726f
> error frame: 0x8f57ec40 0x00002074
> error frame: 0x8f57ec40 0x00006f6f"
>
> Heinrich Schuchardt explains:
>
> "A receive FIFO overrun can be expected if network packages are not
> processed.
> With the network patches we check if a package is available quite often."
>
> Move the "error frame" messages to debug level so that a clean output
> log can be seen.
>
> Reported-by: Jonathan Gray <jsg@jsg.id.au>
> Suggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Do you think this one can be applied for 2017.11?

Thanks
Fabio Estevam Oct. 31, 2017, 11:29 a.m. UTC | #2 
Hi Joe,

On Mon, Oct 30, 2017 at 9:42 PM, Fabio Estevam <festevam@gmail.com> wrote:

> Do you think this one can be applied for 2017.11?

Stefano has applied it:
http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commit;h=41b93679fd69bbb8c335eb212a3f8aa6c9c662db

Thanks
diff mbox series

Patch

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index f16b299..433e19f 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -882,7 +882,7 @@  static int fec_recv(struct eth_device *dev)
 			len = frame_length;
 		} else {
 			if (bd_status & FEC_RBD_ERR)
-				printf("error frame: 0x%08x 0x%08x\n",
+				debug("error frame: 0x%08x 0x%08x\n",
 				       addr, bd_status);
 		}