| Message ID | b4125c6cf42d4d028a9c04f4989627ac1eb83257.1508062280.git.lucien.xin@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | rtnetlink: a bunch of fixes for userspace notifications in changing dev properties | expand |
On 10/15/17 4:13 AM, Xin Long wrote: > As I said in patch 'rtnetlink: bring NETDEV_CHANGEMTU event process back > in rtnetlink_event', removing NETDEV_POST_TYPE_CHANGE event was not the > right fix for the redundant notifications issue. > > So bring this event process back to rtnetlink_event and the old redundant > notifications issue would be fixed in the later patch 'rtnetlink: check > DO_SETLINK_NOTIFY correctly in do_setlink'. > > Fixes: aef091ae58aa ("rtnetlink: Do not generate notifications for POST_TYPE_CHANGE event") > Signed-off-by: Xin Long <lucien.xin@gmail.com> > --- > net/core/rtnetlink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c > index bf47360..8e44fd5 100644 > --- a/net/core/rtnetlink.c > +++ b/net/core/rtnetlink.c > @@ -4284,6 +4284,7 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi > case NETDEV_CHANGENAME: > case NETDEV_FEAT_CHANGE: > case NETDEV_BONDING_FAILOVER: > + case NETDEV_POST_TYPE_CHANGE: > case NETDEV_NOTIFY_PEERS: > case NETDEV_RESEND_IGMP: > case NETDEV_CHANGEINFODATA: > Acked-by: David Ahern <dsahern@gmail.com>
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index bf47360..8e44fd5 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -4284,6 +4284,7 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi case NETDEV_CHANGENAME: case NETDEV_FEAT_CHANGE: case NETDEV_BONDING_FAILOVER: + case NETDEV_POST_TYPE_CHANGE: case NETDEV_NOTIFY_PEERS: case NETDEV_RESEND_IGMP: case NETDEV_CHANGEINFODATA:
As I said in patch 'rtnetlink: bring NETDEV_CHANGEMTU event process back in rtnetlink_event', removing NETDEV_POST_TYPE_CHANGE event was not the right fix for the redundant notifications issue. So bring this event process back to rtnetlink_event and the old redundant notifications issue would be fixed in the later patch 'rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink'. Fixes: aef091ae58aa ("rtnetlink: Do not generate notifications for POST_TYPE_CHANGE event") Signed-off-by: Xin Long <lucien.xin@gmail.com> --- net/core/rtnetlink.c | 1 + 1 file changed, 1 insertion(+)