From patchwork Sat Oct 14 06:06:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Hawkins X-Patchwork-Id: 825795 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-85830-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="ZzSvij3J"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yDYyK1xP7z9sNx for ; Sat, 14 Oct 2017 17:07:05 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=QDSbFaZDg71x/OBVw4p3rtMKeWKWJ0Vg3OpB6VtJKmsVkZP64Vzoc bWy1dR4q0yX3PEuGlgs+3OCaw/RZNoDNCCAgrIPwyWmNg3DeMjVI/WV2fZTRrhok ZxIZMU72wjYysihVToYxD9Te/MMxLcB2tbWuz4rw+z1AgMRdF1VSD4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=t5yNV1hNBVpc7Wzz9NdL1nUnaEE=; b=ZzSvij3JPsDFGMVVGs7vvFKbezYP 4N5LauFUHZ0ds/H57NCvS67Ooz11dN9tjZ3cnDF+1UEi3EbrsZCieh7ebG7t9c1C ZPve4k9MJGKtOmggiO0lRpJcUGUMUx1vmfB06aWpvgpl5xZVcGDdVBZIKAERbZKi 70ey2IQASM3UJJI= Received: (qmail 44655 invoked by alias); 14 Oct 2017 06:06:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 44642 invoked by uid 89); 14 Oct 2017 06:06:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=Hawkins, hawkins, gentle, Hx-languages-length:1993 X-HELO: mail-qk0-f175.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=zaH6OJaSrBcur4W7i8IGO8zGeSUys9uC8MH0CjkCal0=; b=KhMIimH+gKdpA6CVmfqhrHX2TqVubaNQBbnAr0/8cb19Odao1O28LClquc6DbUJY/C dmHWDPPX81zguD3Iz/Y8+wvEWTKob0V+6oaTNsKO4hIvR5W/jjB3NZ9ShAofGLrTCrmk +srC5RPf8KQJ+8VD37p0bT5JDAGtmqtG2Nyi8UCraleHuYEQRWdkwNVxT7HP3+7hO7HQ Z0+fdTwwjIsB+JQpzm20xwl/ZlOobTTPBblXcolnT8XMhDSdUO/Eg4PpeExSktxw9/IV rB1UnqCRQf3W/w31IAeVSf60hDomvT/eb8IFXQmzDO0CyxHhhutkCEq/DBLeVpyI0c2f ZFXw== X-Gm-Message-State: AMCzsaVBQLRZCqusFBoiZP81BR0n2PBVi8OJQrLFxgyi5SrgXs3Kffoe 9A/KvozpO6L1QFgLa+vpZF0YCL0HXes= X-Google-Smtp-Source: AOwi7QAwaZIOmlQ4eeZdlCLuAOYOquxi/jp2q0upxMfMpRZnGjCLvJDSWVhdq1blsVaPFVKatEiYig== X-Received: by 10.55.192.204 with SMTP id v73mr5268467qkv.117.1507961215475; Fri, 13 Oct 2017 23:06:55 -0700 (PDT) From: Will Hawkins To: libc-alpha@sourceware.org, hawkinsw@borlaugic.com Subject: [PATCH] resolv: Remove bogus targets that build ga_test Date: Sat, 14 Oct 2017 02:06:39 -0400 Message-Id: <20171014060639.24703-1-hawkinsw@borlaugic.com> Hello everyone. This is my first patch submission attempt to glibc -- please be gentle. I tried very hard to follow the patch submission instructions but I am sure that I did something wrong. Please just let me know what to correct and I will absolutely make the appropriate changes and try again. Thank you for all that you do for the community! Will --- commit msg: Remove the bogus targets that supposedly build ga_test. ga_test.c was added to resolv very early in the development process but does not appear to be an actual test program. The target for building this file is tests but because the glibc Make system is built the way it is, the target is overriden by higher-level tests targets and, therefore, the ga_test program is never built. Removing the target makes the resolv/Makefile less confusing. Tested by building on 64 bit host running Kernel 4.10.0-19 configured with --prefix=/home/hawkinsw/code/glibc-build/install --enable-hardcoded-path-in-tests --disable-mathvec --- 2017-10-13 Will Hawkins * resolv/Makefile: Remove bogus targets that build resolv/ga_test. --- diff --git a/resolv/Makefile b/resolv/Makefile index cb082d9872..0f1fcc1014 100644 --- a/resolv/Makefile +++ b/resolv/Makefile @@ -101,10 +101,6 @@ routines += $(libnss_dns-routines) $(libresolv-routines) static-only-routines += $(libnss_dns-routines) $(libresolv-routines) endif -ifeq (yesyes,$(build-shared)$(have-thread-library)) -tests: $(objpfx)ga_test -endif - ifeq ($(run-built-tests),yes) ifneq (no,$(PERL)) tests-special += $(objpfx)mtrace-tst-leaks.out @@ -134,8 +130,6 @@ $(objpfx)libnss_dns.so: $(objpfx)libresolv.so # The asynchronous name lookup code needs the thread library. $(objpfx)libanl.so: $(shared-thread-library) -$(objpfx)ga_test: $(objpfx)libanl.so $(shared-thread-library) - $(objpfx)tst-res_hconf_reorder: $(libdl) $(shared-thread-library) tst-res_hconf_reorder-ENV = RESOLV_REORDER=on