resolv: Remove bogus targets that build ga_test
diff mbox series

Message ID 20171014060639.24703-1-hawkinsw@borlaugic.com
State New
Headers show
Series
  • resolv: Remove bogus targets that build ga_test
Related show

Commit Message

Will Hawkins Oct. 14, 2017, 6:06 a.m. UTC
Hello everyone. 

This is my first patch submission attempt to glibc -- please be gentle.

I tried very hard to follow the patch submission instructions but 
I am sure that I did something wrong. Please just let me know what 
to correct and I will absolutely make the appropriate changes and 
try again.

Thank you for all that you do for the community!
Will

--- commit msg:
Remove the bogus targets that supposedly build ga_test. ga_test.c
was added to resolv very early in the development process but does
not appear to be an actual test program. The target for building
this file is tests but because the glibc Make system is built the
way it is, the target is overriden by higher-level tests targets
and, therefore, the ga_test program is never built. Removing the
target makes the resolv/Makefile less confusing.

Tested by building on 64 bit host running Kernel 4.10.0-19 configured 
with 
 --prefix=/home/hawkinsw/code/glibc-build/install 
 --enable-hardcoded-path-in-tests 
 --disable-mathvec
---

2017-10-13  Will Hawkins <hawkinsw@borlaugic.com>

	* resolv/Makefile: Remove bogus targets that build resolv/ga_test.

---

Comments

Carlos O'Donell Oct. 14, 2017, 6:21 a.m. UTC | #1
On 10/13/2017 11:06 PM, Will Hawkins wrote:
> Hello everyone. 
> 
> This is my first patch submission attempt to glibc -- please be gentle.
> 
> I tried very hard to follow the patch submission instructions but 
> I am sure that I did something wrong. Please just let me know what 
> to correct and I will absolutely make the appropriate changes and 
> try again.
> 
> Thank you for all that you do for the community!

Thank you for your fisrt patch!
 
Overall this patch looks good, there are some nit's I'll pick later,
but right now I have a request:

Can you delete resolv/ga_test.c? It's a useless test program with no
license on it at all. We don't need it. Now that you've removed it
from the resolv/Makefile, we should delete it also.

Send a v2 patch with it removed?

> --- commit msg:
> Remove the bogus targets that supposedly build ga_test. ga_test.c
> was added to resolv very early in the development process but does
> not appear to be an actual test program. The target for building
> this file is tests but because the glibc Make system is built the
> way it is, the target is overriden by higher-level tests targets
> and, therefore, the ga_test program is never built. Removing the
> target makes the resolv/Makefile less confusing.
> 
> Tested by building on 64 bit host running Kernel 4.10.0-19 configured 
> with 
>  --prefix=/home/hawkinsw/code/glibc-build/install 
>  --enable-hardcoded-path-in-tests 
>  --disable-mathvec
> ---
> 
> 2017-10-13  Will Hawkins <hawkinsw@borlaugic.com>> 
> 	* resolv/Makefile: Remove bogus targets that build resolv/ga_test.
> 
> diff --git a/resolv/Makefile b/resolv/Makefile
> index cb082d9872..0f1fcc1014 100644
> --- a/resolv/Makefile
> +++ b/resolv/Makefile
> @@ -101,10 +101,6 @@ routines                += $(libnss_dns-routines) $(libresolv-routines)
>  static-only-routines    += $(libnss_dns-routines) $(libresolv-routines)
>  endif
>  
> -ifeq (yesyes,$(build-shared)$(have-thread-library))
> -tests: $(objpfx)ga_test
> -endif
> -
>  ifeq ($(run-built-tests),yes)
>  ifneq (no,$(PERL))
>  tests-special += $(objpfx)mtrace-tst-leaks.out
> @@ -134,8 +130,6 @@ $(objpfx)libnss_dns.so: $(objpfx)libresolv.so
>  # The asynchronous name lookup code needs the thread library.
>  $(objpfx)libanl.so: $(shared-thread-library)
>  
> -$(objpfx)ga_test: $(objpfx)libanl.so $(shared-thread-library)
> -
>  $(objpfx)tst-res_hconf_reorder: $(libdl) $(shared-thread-library)
>  tst-res_hconf_reorder-ENV = RESOLV_REORDER=on
> 
> ---
>

Patch
diff mbox series

diff --git a/resolv/Makefile b/resolv/Makefile
index cb082d9872..0f1fcc1014 100644
--- a/resolv/Makefile
+++ b/resolv/Makefile
@@ -101,10 +101,6 @@  routines                += $(libnss_dns-routines) $(libresolv-routines)
 static-only-routines    += $(libnss_dns-routines) $(libresolv-routines)
 endif
 
-ifeq (yesyes,$(build-shared)$(have-thread-library))
-tests: $(objpfx)ga_test
-endif
-
 ifeq ($(run-built-tests),yes)
 ifneq (no,$(PERL))
 tests-special += $(objpfx)mtrace-tst-leaks.out
@@ -134,8 +130,6 @@  $(objpfx)libnss_dns.so: $(objpfx)libresolv.so
 # The asynchronous name lookup code needs the thread library.
 $(objpfx)libanl.so: $(shared-thread-library)
 
-$(objpfx)ga_test: $(objpfx)libanl.so $(shared-thread-library)
-
 $(objpfx)tst-res_hconf_reorder: $(libdl) $(shared-thread-library)
 tst-res_hconf_reorder-ENV = RESOLV_REORDER=on