diff mbox series

[U-Boot] i2c: remove DECLARE_GLOBAL_DATA_PTR from i2c-uclass

Message ID 1507890543-13038-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit c4e5990ad20e9d387dd0f1e6649c7676b869bc0d
Delegated to: Heiko Schocher
Headers show
Series [U-Boot] i2c: remove DECLARE_GLOBAL_DATA_PTR from i2c-uclass | expand

Commit Message

Masahiro Yamada Oct. 13, 2017, 10:29 a.m. UTC
No global pointer is used in this file.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/i2c/i2c-uclass.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Heiko Schocher Oct. 16, 2017, 6:26 a.m. UTC | #1
Hello Masahiro,

Am 13.10.2017 um 12:29 schrieb Masahiro Yamada:
> No global pointer is used in this file.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>   drivers/i2c/i2c-uclass.c | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
Masahiro Yamada Oct. 17, 2017, 8:40 a.m. UTC | #2
Hi Heiko.

2017-10-16 15:26 GMT+09:00 Heiko Schocher <hs@denx.de>:
> Hello Masahiro,
>
> Am 13.10.2017 um 12:29 schrieb Masahiro Yamada:
>>
>> No global pointer is used in this file.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>   drivers/i2c/i2c-uclass.c | 2 --
>>   1 file changed, 2 deletions(-)
>
>
> Reviewed-by: Heiko Schocher <hs@denx.de>
>

FYI.
Looks like this was delegated to you.
Heiko Schocher Oct. 17, 2017, 10:11 a.m. UTC | #3
Hello Masahiro,

Am 17.10.2017 um 10:40 schrieb Masahiro Yamada:
> Hi Heiko.
> 
> 2017-10-16 15:26 GMT+09:00 Heiko Schocher <hs@denx.de>:
>> Hello Masahiro,
>>
>> Am 13.10.2017 um 12:29 schrieb Masahiro Yamada:
>>>
>>> No global pointer is used in this file.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> ---
>>>
>>>    drivers/i2c/i2c-uclass.c | 2 --
>>>    1 file changed, 2 deletions(-)
>>
>>
>> Reviewed-by: Heiko Schocher <hs@denx.de>
>>
> 
> FYI.
> Looks like this was delegated to you.

Yes, travis build is running.

bye,
Heiko
Heiko Schocher Oct. 17, 2017, 2:27 p.m. UTC | #4
Hello Masahiro,

Am 13.10.2017 um 12:29 schrieb Masahiro Yamada:
> No global pointer is used in this file.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>   drivers/i2c/i2c-uclass.c | 2 --
>   1 file changed, 2 deletions(-)

Thanks!

Applied to u-boot-i2c.git

bye,
Heiko
diff mbox series

Patch

diff --git a/drivers/i2c/i2c-uclass.c b/drivers/i2c/i2c-uclass.c
index 1397f34..920811a 100644
--- a/drivers/i2c/i2c-uclass.c
+++ b/drivers/i2c/i2c-uclass.c
@@ -12,8 +12,6 @@ 
 #include <dm/device-internal.h>
 #include <dm/lists.h>
 
-DECLARE_GLOBAL_DATA_PTR;
-
 #define I2C_MAX_OFFSET_LEN	4
 
 /* Useful debugging function */