Patchwork [U-Boot] fsl: update CRC after system EEPROM identifier

login
register
mail settings
Submitter Timur Tabi
Date Feb. 9, 2011, 7:40 p.m.
Message ID <1297280451-20009-1-git-send-email-timur@freescale.com>
Download mbox | patch
Permalink /patch/82525/
State Accepted
Commit 3fee334c85fd16904f8d23487247508cceab0228
Delegated to: Kumar Gala
Headers show

Comments

Timur Tabi - Feb. 9, 2011, 7:40 p.m.
The "mac id" command is used to initialize the EEPROM data to a specific
format, but it was not updating the CRC.  This didn't cause any real
problems, because writing the data to the EEPROM will always update the
CRC anyway, but it did result in a bogus CRC warning.

Signed-off-by: Timur Tabi <timur@freescale.com>
---
 board/freescale/common/sys_eeprom.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Timur Tabi - Feb. 9, 2011, 9:08 p.m.
On Wed, Feb 9, 2011 at 1:40 PM, Timur Tabi <timur@freescale.com> wrote:
> The "mac id" command is used to initialize the EEPROM data to a specific
> format, but it was not updating the CRC.  This didn't cause any real
> problems, because writing the data to the EEPROM will always update the
> CRC anyway, but it did result in a bogus CRC warning.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---

That should say, "after setting EEPROM identifier"
Kumar Gala - Feb. 10, 2011, 5:30 a.m.
On Feb 9, 2011, at 3:08 PM, Timur Tabi wrote:

> On Wed, Feb 9, 2011 at 1:40 PM, Timur Tabi <timur@freescale.com> wrote:
>> The "mac id" command is used to initialize the EEPROM data to a specific
>> format, but it was not updating the CRC.  This didn't cause any real
>> problems, because writing the data to the EEPROM will always update the
>> CRC anyway, but it did result in a bogus CRC warning.
>> 
>> Signed-off-by: Timur Tabi <timur@freescale.com>
>> ---
> 
> That should say, "after setting EEPROM identifier"

Fixed, committed to 85xx

- k

Patch

diff --git a/board/freescale/common/sys_eeprom.c b/board/freescale/common/sys_eeprom.c
index 11dfd84..3ecfb06 100644
--- a/board/freescale/common/sys_eeprom.c
+++ b/board/freescale/common/sys_eeprom.c
@@ -361,6 +361,7 @@  int do_mac(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 #else
 		memcpy(e.id, "CCID", sizeof(e.id));
 #endif
+		update_crc();
 		return 0;
 	}