Patchwork ObjC++: update testcase

login
register
mail settings
Submitter Nicola Pero
Date Feb. 9, 2011, 7:33 p.m.
Message ID <1297280013.24633352@192.168.4.58>
Download mbox | patch
Permalink /patch/82523/
State New
Headers show

Comments

Nicola Pero - Feb. 9, 2011, 7:33 p.m.
This patch fixes one ObjC++ testcase which is currently failing because
it has not been updated for changes in compiler warnings.  The corresponding
ObjC testcase was updated when the compiler change was committed (yesterday),
but the ObjC++ one wasn't.

I just noticed the testsuite failures, and would like to remove the noise.

Ok to commit to trunk/4.6 ?

Thanks
Mike Stump - Feb. 9, 2011, 7:46 p.m.
On Feb 9, 2011, at 11:33 AM, Nicola Pero wrote:
> This patch fixes one ObjC++ testcase which is currently failing because
> it has not been updated for changes in compiler warnings.  The corresponding
> ObjC testcase was updated when the compiler change was committed (yesterday),
> but the ObjC++ one wasn't.
> 
> I just noticed the testsuite failures, and would like to remove the noise.
> 
> Ok to commit to trunk/4.6 ?

Ok.
Andreas Krebbel - Feb. 10, 2011, 11:56 a.m.
> Index: ChangeLog
> ===================================================================
> --- ChangeLog   (revision 169979)
> +++ ChangeLog   (working copy)
> @@ -1,3 +1,8 @@
> +2011-02-09  Nicola Pero  <nicola.pero@meta-innovation.com>
> +
> +       * obj-c++.dg/attributes/method-noreturn-1.mm: Updated test for
> +       change (PR 47646) in compiler warnings.
> +
Eric already fixed this:
http://gcc.gnu.org/ml/gcc-patches/2011-02/msg00618.html

-Andreas-

Patch

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 169979)
+++ ChangeLog   (working copy)
@@ -1,3 +1,8 @@ 
+2011-02-09  Nicola Pero  <nicola.pero@meta-innovation.com>
+
+       * obj-c++.dg/attributes/method-noreturn-1.mm: Updated test for
+       change (PR 47646) in compiler warnings.
+
 2011-02-09  Janus Weil  <janus@gcc.gnu.org>
 
        PR fortran/47637
Index: obj-c++.dg/attributes/method-noreturn-1.mm
===================================================================
--- obj-c++.dg/attributes/method-noreturn-1.mm  (revision 169979)
+++ obj-c++.dg/attributes/method-noreturn-1.mm  (working copy)
@@ -18,11 +18,11 @@ 
 + (id) method1
 {
   return self;  /* { dg-warning "function declared .noreturn. has a .return. statement" } */
-}               /* { dg-warning ".noreturn. function does return" } */
+}               /* { dg-warning ".noreturn. function does return" "" { target *-*-* } 20 } */
 - (id) method2
 {
   return self;  /* { dg-warning "function declared .noreturn. has a .return. statement" } */
-}               /* { dg-warning ".noreturn. function does return" } */
+}               /* { dg-warning ".noreturn. function does return" "" { target *-*-* } 24 } */
 + (id) method3
 {
   abort ();