| Message ID | 20171013012455.10737-2-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] MAINTAINERS: Fix scsi path | expand |
On 13.10.2017 03:24, Fam Zheng wrote: > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 772ac209e1..da3c78df47 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -982,7 +982,7 @@ S: Supported > F: include/hw/scsi/* > F: include/scsi/* > F: hw/scsi/* > -F: util/scsi* > +F: scsi/* scsi/* is already covered by the new "Block SCSI subsystem" section, so I think you can also simply remove that line instead. Thomas
On Fri, 10/13 10:04, Thomas Huth wrote: > On 13.10.2017 03:24, Fam Zheng wrote: > > Signed-off-by: Fam Zheng <famz@redhat.com> > > --- > > MAINTAINERS | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 772ac209e1..da3c78df47 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -982,7 +982,7 @@ S: Supported > > F: include/hw/scsi/* > > F: include/scsi/* > > F: hw/scsi/* > > -F: util/scsi* > > +F: scsi/* > > scsi/* is already covered by the new "Block SCSI subsystem" section, so > I think you can also simply remove that line instead. I didn't notice that section existing, should the two be merged into one? Fam
On 13.10.2017 10:20, Fam Zheng wrote: > On Fri, 10/13 10:04, Thomas Huth wrote: >> On 13.10.2017 03:24, Fam Zheng wrote: >>> Signed-off-by: Fam Zheng <famz@redhat.com> >>> --- >>> MAINTAINERS | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 772ac209e1..da3c78df47 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -982,7 +982,7 @@ S: Supported >>> F: include/hw/scsi/* >>> F: include/scsi/* >>> F: hw/scsi/* >>> -F: util/scsi* >>> +F: scsi/* >> >> scsi/* is already covered by the new "Block SCSI subsystem" section, so >> I think you can also simply remove that line instead. > > I didn't notice that section existing, should the two be merged into one? I don't think so. One section is about the emulated SCSI devices, and the other one about the SCSI block backend code, so that's two different parts. Some other ideas though: 1) I think "include/scsi/*" should be removed from the SCSI devices section, it is already handled in the "Block SCSI subsystem" - and headers that are related to devices should go into include/hw/scsi/ anyway instead. 2) The orphan LSI53C895A section could maybe be removed from the MAINTAINERS file? It's of no use in its current "Orphan" state, and the file is already covered by the generic SCSI devices section. Thomas
On Fri, 10/13 10:30, Thomas Huth wrote: > On 13.10.2017 10:20, Fam Zheng wrote: > > On Fri, 10/13 10:04, Thomas Huth wrote: > >> On 13.10.2017 03:24, Fam Zheng wrote: > >>> Signed-off-by: Fam Zheng <famz@redhat.com> > >>> --- > >>> MAINTAINERS | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/MAINTAINERS b/MAINTAINERS > >>> index 772ac209e1..da3c78df47 100644 > >>> --- a/MAINTAINERS > >>> +++ b/MAINTAINERS > >>> @@ -982,7 +982,7 @@ S: Supported > >>> F: include/hw/scsi/* > >>> F: include/scsi/* > >>> F: hw/scsi/* > >>> -F: util/scsi* > >>> +F: scsi/* > >> > >> scsi/* is already covered by the new "Block SCSI subsystem" section, so > >> I think you can also simply remove that line instead. > > > > I didn't notice that section existing, should the two be merged into one? > > I don't think so. One section is about the emulated SCSI devices, and > the other one about the SCSI block backend code, so that's two different > parts. > > Some other ideas though: > > 1) I think "include/scsi/*" should be removed from the SCSI devices > section, it is already handled in the "Block SCSI subsystem" - and > headers that are related to devices should go into include/hw/scsi/ > anyway instead. > > 2) The orphan LSI53C895A section could maybe be removed from the > MAINTAINERS file? It's of no use in its current "Orphan" state, and the > file is already covered by the generic SCSI devices section. OK, that sounds good to me. Fam
diff --git a/MAINTAINERS b/MAINTAINERS index 772ac209e1..da3c78df47 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -982,7 +982,7 @@ S: Supported F: include/hw/scsi/* F: include/scsi/* F: hw/scsi/* -F: util/scsi* +F: scsi/* F: tests/virtio-scsi-test.c T: git git://github.com/bonzini/qemu.git scsi-next
Signed-off-by: Fam Zheng <famz@redhat.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)