From patchwork Thu Oct 12 17:34:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 824998 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ztPj9S6H"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yCdKg3l47z9t2r for ; Fri, 13 Oct 2017 04:35:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbdJLRew (ORCPT ); Thu, 12 Oct 2017 13:34:52 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:51199 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752246AbdJLReu (ORCPT ); Thu, 12 Oct 2017 13:34:50 -0400 Received: by mail-pf0-f180.google.com with SMTP id m63so5837602pfk.7 for ; Thu, 12 Oct 2017 10:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VrbrS2hSrxYOz9pcfLYPKzxuiKn5t2fyXqgO+frrxe0=; b=ztPj9S6HENKbq7/99Lu3XmWg5WgYTUmopC7XQMf08ZEJgx0hRW9OJxspQLSf1ksVIN qTmqPHB24Fj+TH8n+Iifz+MbeowRY9t8WVz4NrEm5LU+PTmzuYbj+CusTwBNgfKLMeR0 k8oMDsSYnMprAScvYTXr6GPdQAdHoL3+XH3W1vLTx24Eq0Fg0j6YqrFedCnFKZ6HKJgX +iiDlDMV8G9449UxSKa/RYw7Cqse0qqdMIgKpHqNbWDgQG7u103GCFqX/gtOjuPoFLsF vbXgUrPRdS33LHpqU7YNBtKDnjBIYffmld+/6GMwhWY86XF4ZFGx8Gj9HO7/CmuCyOeS C4BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VrbrS2hSrxYOz9pcfLYPKzxuiKn5t2fyXqgO+frrxe0=; b=bqcU6yO0LkzV9c+vBD58j+UAfLX2fT42vUdiyt4PCih/2qvmYjm+Mw4pjovBzQBjjU 7JZa5bGVLB/I5Tc6ZbIgmNqKF3I7KYj9SxFsoTbXTRokVDljA8eb2AqyHNYvwAmBREWp P+gJ3VYxuEixBu3m1QTlUkpgHY0fH9igIYaajvULszYV3Hz1gRk9qahltgGHyxVP5Cpt ++bCkI7eMJIvyRrbAqItRhatZwBnng0wtkvsQU5AJhJ2Ay4fxo+vLyBQpl8DsmWBF86Q NIKgN+aw2wTZ0DQfyf47PqNjxCCswv6nYBkQCR0U2xzKfGSg8JXQ9ZsgANJFlCBr2ae2 2BVQ== X-Gm-Message-State: AMCzsaUNxxZH0oR4EUgzad+8d+q91r3pZo2vdlpA12pUq4Ci3etAHJ30 /iYdHWAPQka2g/VqS3x+vYwU+HrN X-Google-Smtp-Source: AOwi7QDG7isO0fY0Fe0CKdYUtcw10twnBWQcZjifu1qmrN6ZtGUrF3zoVZ3tGMAgW5Ix8msVWVjIRA== X-Received: by 10.99.124.88 with SMTP id l24mr780677pgn.397.1507829690102; Thu, 12 Oct 2017 10:34:50 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([75.53.12.129]) by smtp.gmail.com with ESMTPSA id q8sm25037929pfk.100.2017.10.12.10.34.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Oct 2017 10:34:49 -0700 (PDT) From: Jakub Kicinski To: netdev@vger.kernel.org Cc: oss-drivers@netronome.com, Jakub Kicinski Subject: [PATCH net-next 02/12] nfp: bpf: reorder arguments to emit_ld_field_any() Date: Thu, 12 Oct 2017 10:34:08 -0700 Message-Id: <20171012173418.4029-3-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171012173418.4029-1-jakub.kicinski@netronome.com> References: <20171012173418.4029-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ld_field instruction has the following format in NFP assembler: ld_field[dst, 1000, src, <<24] reoder parameters to emit_ld_field_any() to make it closer to the familiar assembler order. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c b/drivers/net/ethernet/netronome/nfp/bpf/jit.c index 13148f30fc4c..cf8a6eb3ec99 100644 --- a/drivers/net/ethernet/netronome/nfp/bpf/jit.c +++ b/drivers/net/ethernet/netronome/nfp/bpf/jit.c @@ -402,8 +402,8 @@ __emit_ld_field(struct nfp_prog *nfp_prog, enum shf_sc sc, } static void -emit_ld_field_any(struct nfp_prog *nfp_prog, enum shf_sc sc, u8 shift, - swreg dst, u8 bmask, swreg src, bool zero) +emit_ld_field_any(struct nfp_prog *nfp_prog, swreg dst, u8 bmask, swreg src, + enum shf_sc sc, u8 shift, bool zero) { struct nfp_insn_re_regs reg; int err; @@ -424,7 +424,7 @@ static void emit_ld_field(struct nfp_prog *nfp_prog, swreg dst, u8 bmask, swreg src, enum shf_sc sc, u8 shift) { - emit_ld_field_any(nfp_prog, sc, shift, dst, bmask, src, false); + emit_ld_field_any(nfp_prog, dst, bmask, src, sc, shift, false); } static void emit_nop(struct nfp_prog *nfp_prog)