Patchwork [-next] can: softing_cs needs slab.h

login
register
mail settings
Submitter Randy Dunlap
Date Feb. 9, 2011, 4:44 p.m.
Message ID <20110209084456.802370fa.randy.dunlap@oracle.com>
Download mbox | patch
Permalink /patch/82499/
State Accepted
Delegated to: David Miller
Headers show

Comments

Randy Dunlap - Feb. 9, 2011, 4:44 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>

softing_cs.c uses kzalloc & kfree, so it needs to include linux/slab.h.

drivers/net/can/softing/softing_cs.c:234: error: implicit declaration of function 'kfree'
drivers/net/can/softing/softing_cs.c:271: error: implicit declaration of function 'kzalloc'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/net/can/softing/softing_cs.c |    1 +
 1 file changed, 1 insertion(+)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Feb. 9, 2011, 8:43 p.m.
From: Randy Dunlap <randy.dunlap@Oracle.COM>
Date: Wed, 9 Feb 2011 08:44:56 -0800

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> softing_cs.c uses kzalloc & kfree, so it needs to include linux/slab.h.
> 
> drivers/net/can/softing/softing_cs.c:234: error: implicit declaration of function 'kfree'
> drivers/net/can/softing/softing_cs.c:271: error: implicit declaration of function 'kzalloc'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied, thanks Randy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-next-20110209.orig/drivers/net/can/softing/softing_cs.c
+++ linux-next-20110209/drivers/net/can/softing/softing_cs.c
@@ -19,6 +19,7 @@ 
 
 #include <linux/module.h>
 #include <linux/kernel.h>
+#include <linux/slab.h>
 
 #include <pcmcia/cistpl.h>
 #include <pcmcia/ds.h>