[U-Boot,2/2] x86: Turn off running VGA ROM during S3 resume

Message ID 1507810078-29955-2-git-send-email-bmeng.cn@gmail.com
State Accepted
Delegated to: Bin Meng
Headers show
Series
  • [U-Boot,1/2] x86: baytrail: Fix unstable ACPI S3 resume
Related show

Commit Message

Bin Meng Oct. 12, 2017, 12:07 p.m.
This is only needed when graphics console is used. For kernel with
native graphics driver, this can be turned off to speed up.

Change this option's default to n in the Kconfig.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Stefan Roese Oct. 13, 2017, 11:09 a.m. | #1
On 12.10.2017 14:07, Bin Meng wrote:
> This is only needed when graphics console is used. For kernel with
> native graphics driver, this can be turned off to speed up.
> 
> Change this option's default to n in the Kconfig.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
>   arch/x86/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 38a6187..c869ae2 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -677,7 +677,6 @@ config HAVE_ACPI_RESUME
>   config S3_VGA_ROM_RUN
>   	bool "Re-run VGA option ROMs on S3 resume"
>   	depends on HAVE_ACPI_RESUME
> -	default y if HAVE_ACPI_RESUME
>   	help
>   	  Execute VGA option ROMs in U-Boot when resuming from S3. Normally
>   	  this is needed when graphics console is being used in the kernel.
> 

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Bin Meng Oct. 19, 2017, 3:36 a.m. | #2
On Fri, Oct 13, 2017 at 7:09 PM, Stefan Roese <sr@denx.de> wrote:
> On 12.10.2017 14:07, Bin Meng wrote:
>>
>> This is only needed when graphics console is used. For kernel with
>> native graphics driver, this can be turned off to speed up.
>>
>> Change this option's default to n in the Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>   arch/x86/Kconfig | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 38a6187..c869ae2 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -677,7 +677,6 @@ config HAVE_ACPI_RESUME
>>   config S3_VGA_ROM_RUN
>>         bool "Re-run VGA option ROMs on S3 resume"
>>         depends on HAVE_ACPI_RESUME
>> -       default y if HAVE_ACPI_RESUME
>>         help
>>           Execute VGA option ROMs in U-Boot when resuming from S3.
>> Normally
>>           this is needed when graphics console is being used in the
>> kernel.
>>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
>

applied to u-boot-x86, thanks!

Patch

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 38a6187..c869ae2 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -677,7 +677,6 @@  config HAVE_ACPI_RESUME
 config S3_VGA_ROM_RUN
 	bool "Re-run VGA option ROMs on S3 resume"
 	depends on HAVE_ACPI_RESUME
-	default y if HAVE_ACPI_RESUME
 	help
 	  Execute VGA option ROMs in U-Boot when resuming from S3. Normally
 	  this is needed when graphics console is being used in the kernel.